Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(derive): Additional Stage Metrics #326

Merged
merged 1 commit into from
Jun 27, 2024
Merged

feat(derive): Additional Stage Metrics #326

merged 1 commit into from
Jun 27, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jun 27, 2024 •
edited
Loading

Description

Adds two more stage metrics.

  • Batch reader errors with labels.
  • Batch compression ratio tracked as a gauge.

@refcell refcell changed the title feat(derive): more stage metrics feat(derive): Additional Stage Metrics Jun 27, 2024
@refcell refcell mentioned this pull request Jun 27, 2024
Merged
@refcell Graphite App
Copy link
Collaborator Author

refcell commented Jun 27, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell requested a review from clabby June 27, 2024 13:54
@refcell refcell added K-feature Kind: feature A-derive Area: kona-derive crate M-metrics Meta: metric related labels Jun 27, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review June 27, 2024 13:56
@refcell refcell self-assigned this Jun 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.8%. Comparing base (d3f1493) to head (8b74061).

Files Patch % Lines
crates/derive/src/stages/channel_reader.rs 60.0% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell mentioned this pull request Jun 27, 2024
Merged
@refcell refcell changed the base branch from refcell/granular-provider-metrics to main June 27, 2024 17:49
@refcell refcell enabled auto-merge June 27, 2024 17:50
@refcell refcell added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 961d4a5 Jun 27, 2024
14 checks passed
@refcell refcell mentioned this pull request Jun 27, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
Closed
This was referenced Jun 27, 2024
Merged
Merged
Merged
Merged
@clabby clabby deleted the refcell/stage-metrics branch July 2, 2024 03:37
This was referenced Jul 8, 2024
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Closed
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-derive Area: kona-derive crate K-feature Kind: feature M-metrics Meta: metric related
Projects
None yet
Milestone
Phase 2: Kona Derivation Pipeline
Development

Successfully merging this pull request may close these issues.
3 participants
@refcell @codecov-commenter @clabby