Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): Graceful Payload Validation #327

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jun 27, 2024

Description

  • Makes payload validation graceful - returning a Result<bool>.
  • Rejiggers the pipeline to allow the consumer to peek at attributes for validation. This makes downstream validation easier such that if validation errors, no additional tracking needs to be done to re-try validation.

@refcell refcell changed the title fix(examples): don't panic on validation fetch failure fix(examples): Graceful Payload Validation Jun 27, 2024
@refcell refcell self-assigned this Jun 27, 2024
@refcell refcell requested a review from clabby June 27, 2024 15:10
@refcell refcell marked this pull request as ready for review June 27, 2024 15:10
crates/derive/src/pipeline/core.rs Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.7%. Comparing base (961d4a5) to head (7db86ae).

Files Patch % Lines
crates/derive/src/pipeline/core.rs 0.0% 4 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell changed the base branch from refcell/stage-metrics to main June 27, 2024 18:07
@refcell refcell added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 0c59a50 Jun 27, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
@clabby clabby deleted the refcell/fix-validation branch July 2, 2024 03:37
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
This was referenced Jul 8, 2024
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants