Timeout before the openshift route times out #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not timing out before undercuts usefulness of our log-traceback-middleware in django-ansible-base that logs a traceback from requests that get timed out -- because uwsgi or gunicorn has to send the timeout signal to the worker handling the request. Also leads to issues where requests that envoy has already timed out are filling up queues of the workers of the components. Also, configure nginx to return a 503 if WSGI server doesn't respond. Co-Authored-By: Elijah DeLee <[email protected]>
|
LGTM |
|
Pretty straight forward. Looks like there is a little legwork for me to test locally. Anyway you could provide some screenshots of the local deployment you have configmaps with these changes after applied? |
|
|
|
|
|
forgot to include event stream screenshot
|
ttuffin
reviewed
Jul 16, 2025
… since they seem to get used there, rectify naming mishap with eda_gunicorn_... vs just gunicorn_...
rebeccahhh
force-pushed
the
timeout_api_before_proxy
branch
from
29a1b4c to
08b2204
Compare
|
rebeccahhh
commented
Jul 16, 2025
| event_stream_nginx_port: 8000 | ||
| event_stream_server_name: "{{ ansible_operator_meta.name }}-event-stream" | ||
| event_stream_django_port: 8002 | ||
|
|
There was a problem hiding this comment.
@ttuffin I ended up moving this out of defaults over to vars, it seems like this is the more "correct" spot for these based on the other variables present in this file that get used in the gunicorn --bind statements. If the vars are here it works as I expect in terms of correctly setting the vars in the deployment/pod.
aknochow
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not timing out before undercuts usefulness of our log-traceback-middleware in django-ansible-base that logs a traceback from requests that get timed out -- because uwsgi or gunicorn has to send the timeout signal to the worker handling the request. Also leads to issues where requests that envoy has already timed out are filling up queues of the workers of the components.
Also, configure nginx to return a 503 if WSGI server doesn't respond.
Similar changes for the AWX operator: ansible/awx-operator#2056