Skip to content

Conversation

@rebeccahhh
Copy link
Member

@rebeccahhh rebeccahhh commented Sep 2, 2025

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Summary

add tasks to check CR for annotations and update timeout based on the passed value
These new tasks will:

  • check for annotation for client_request_timeout
  • if annotation is present, override default value (currently set to 30s)
  • log message noting the change

follow up PR of: #294

Additional Information

matching PRS for other operators:

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2025

@rebeccahhh
Copy link
Member Author

image

@rebeccahhh
Copy link
Member Author

settable via CR (I picked 300 so it would be evident it wasn't the original 30)

@rebeccahhh rebeccahhh marked this pull request as ready for review September 3, 2025 20:49
@rebeccahhh rebeccahhh changed the title [DRAFT] set client_request_timeout from annotation in the CR set client_request_timeout from annotation in the CR Sep 4, 2025
… passed value

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@rebeccahhh rebeccahhh force-pushed the set_timeout_using_cr_annotation branch from 963c9c8 to 39c7600 Compare October 15, 2025 22:03
@rebeccahhh
Copy link
Member Author

updated with origin/main

@sonarqubecloud
Copy link

@aknochow aknochow merged commit 94ba1e8 into ansible:main Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants