set api timeout to match proxy timeout #2056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rebeccahhh
requested review from
AlanCoding,
aknochow,
dsavineau and
rooftopcellist
kdelee
reviewed
Jul 2, 2025
| deny all; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
see i fyou can get rid of this whitespace diff
rebeccahhh
changed the title
rooftopcellist
approved these changes
Jul 3, 2025
Timeout before the openshift route times out not timing out before undercuts usefulness of our log-traceback-middleware in django-ansible-base that logs a traceback from requests that get timed out -- because uwsgi or gunicorn has to send the timeout signal to the worker handling the request. Also leads to issues where requests that envoy has already timed out are filling up queues of the workers of the components. Also, configure nginx to return a 503 if WSGI server doesn't respond. Co-Authored-By: Elijah DeLee <[email protected]>
rebeccahhh
force-pushed
the
timeout_api_before_proxy
branch
from
f34477d to
aaeb880
Compare
|
Whitespace removed ✅ |
aknochow
pushed a commit
to aknochow/awx-operator
that referenced
this pull request
Jul 29, 2025
feat: set api timeout to match proxy timeout Timeout before the openshift route times out not timing out before undercuts usefulness of our log-traceback-middleware in django-ansible-base that logs a traceback from requests that get timed out -- because uwsgi or gunicorn has to send the timeout signal to the worker handling the request. Also leads to issues where requests that envoy has already timed out are filling up queues of the workers of the components. Also, configure nginx to return a 503 if WSGI server doesn't respond. Co-authored-by: Elijah DeLee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Timeout before the openshift route times out
not timing out before undercuts usefulness of our log-traceback-middleware in django-ansible-base that logs a traceback from requests that get timed out -- because uwsgi or gunicorn has to send the timeout signal to the worker handling the request. Also leads to issues where requests that envoy has already timed out are filling up queues of the workers of the components.
Also, configure nginx to return a 503 if WSGI server doesn't respond.
ISSUE TYPE
ADDITIONAL INFORMATION
This makes no changes to the CR, it just aligns existing timeouts for nginx and uwsgi to the known default timeout of 30 seconds, which is not currently configurable because we don't allow route annotations.