feat(id): brand SessionID through Drizzle and Zod schemas#16953
Merged
kitlangton merged 11 commits intodevfrom Mar 11, 2026
Merged
feat(id): brand SessionID through Drizzle and Zod schemas#16953kitlangton merged 11 commits intodevfrom
kitlangton merged 11 commits intodevfrom
Conversation
2 tasks
kitlangton
changed the title
Introduce Effect branded ProjectID type into Drizzle table columns and Zod schemas so the brand flows through z.infer automatically. Adds ProjectID.zod helper to bridge Effect brands into Zod, eliminating manual Omit & intersect type overrides.
- Remove unnecessary WorkspaceInfoType alias import - Use input.projectID instead of config.projectID in workspace create - Compare against ProjectID.global instead of String coercion in test
Same pattern as ProjectID: add branded SessionID type with
SessionID.zod helper, type Drizzle columns with $type<SessionID>(),
and replace all z.string()/Identifier.schema("session") usages.
Brand flows through z.infer automatically, mapped at boundaries.
- import.ts: inline SessionID.make() in toRow spread, use row.id for session_id - export.ts: brand sessionID at CLI arg boundary, remove redundant as string cast
SessionID.make("test-session") and MessageID.make("test-id") bypass
zod validation but safeParse still checks startsWith prefixes at
runtime. Use the proper constructors that generate valid prefixed IDs.
kitlangton
force-pushed
the
feat/branded-session-id
branch
from
b38a9c1 to
860610c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #16948 (ProjectID).
Summary
SessionIDtype with.make(),.descending(), and.zodstaticsSessionIDthrough Drizzle columns (SessionTable.id,session_idFKs,parent_id)Identifier.schema("session")andsessionID: z.string()withSessionID.zodSessionID.make()Test plan
bun turbo typecheckpassesbun testpasses