feat(id): brand ProjectID through Drizzle and Zod schemas#16948
Merged
kitlangton merged 4 commits intodevfrom Mar 11, 2026
Merged
feat(id): brand ProjectID through Drizzle and Zod schemas#16948kitlangton merged 4 commits intodevfrom
kitlangton merged 4 commits intodevfrom
Conversation
Introduce Effect branded ProjectID type into Drizzle table columns and Zod schemas so the brand flows through z.infer automatically. Adds ProjectID.zod helper to bridge Effect brands into Zod, eliminating manual Omit & intersect type overrides.
kitlangton
commented
Mar 11, 2026
kitlangton
commented
Mar 11, 2026
kitlangton
commented
Mar 11, 2026
kitlangton
commented
Mar 11, 2026
kitlangton
commented
Mar 11, 2026
- Remove unnecessary WorkspaceInfoType alias import - Use input.projectID instead of config.projectID in workspace create - Compare against ProjectID.global instead of String coercion in test
2 tasks
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectIDtype with.make(),.global, and.zodstaticsProjectIDthrough Drizzle columns ($type<ProjectID>()) and Zod schemas (ProjectID.zod)Omit<...> & { projectID: ProjectID }overrides withz.inferpropagationProjectID.make()Test plan
bun turbo typecheckpassesbun testpasses