feat(id): brand MessageID through Drizzle and Zod schemas#16956
Merged
kitlangton merged 3 commits intofeat/branded-session-idfrom Mar 11, 2026
Merged
feat(id): brand MessageID through Drizzle and Zod schemas#16956kitlangton merged 3 commits intofeat/branded-session-idfrom
kitlangton merged 3 commits intofeat/branded-session-idfrom
Conversation
kitlangton
commented
Mar 11, 2026
kitlangton
commented
Mar 11, 2026
Same pattern as ProjectID/SessionID: add branded MessageID type with
MessageID.zod and MessageID.ascending() helpers, type Drizzle columns
with $type<MessageID>(), and replace all Identifier.schema("message")
and z.string() usages. Brand flows through z.infer automatically.
- Replace MessageID.make(Identifier.ascending("message")) with MessageID.ascending()
- Remove as any casts in import.ts by destructuring out column-stored fields
- Revert unrelated account.ts changes
kitlangton
force-pushed
the
feat/branded-message-id
branch
from
3b865e2 to
2ca9fb5
Compare
The rebase dropped the MessageID test fix. Tests were using plain
strings ("test-id", "parent-id") which fail zod's startsWith("msg")
validation.
kitlangton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #16953 (SessionID).
Summary
MessageIDtype with.make(),.ascending(), and.zodstaticsMessageIDthrough Drizzle columns and Zod schemas across session logic, message-v2, prompt, compaction, tools, server routes, and CLIMessageID.make()Test plan
bun turbo typecheckpassesbun testpasses