Update deb to new generic cataloger pattern#1288
Merged
Conversation
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
Contributor
Author
|
re: 1287. yeah, I'm starting to chain PRs... I need to rebase this one so it won't include it |
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
wagoodman
force-pushed
the
update-deb-generic-cataloger
branch
from
b39bd71 to
0f73ff8
Compare
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com> Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1281 , porting the DEB cataloger to the new
generic.Cataloger.This PR also makes the following adjustments:
internal/pkgtesthelper with a builder pattern approach (the DEB cataloger needs these extra use cases and a multi-constructor based approach would become untenable here)cataloger.Catalogerinterface topkg.Catalogerwas necessary. This is additionally consistent with the plan in Top-level API should be more composable #558 .