Skip to content

Update cataloger tests to use pkgtest utils#1287

Merged
wagoodman merged 1 commit intomainfrom
use-new-generic-cataloger-test-pkg
Oct 25, 2022
Merged

Update cataloger tests to use pkgtest utils#1287
wagoodman merged 1 commit intomainfrom
use-new-generic-cataloger-test-pkg

Conversation

@wagoodman
Copy link
Copy Markdown
Contributor

This is a follow up to #1286 to use the new internal/pkgtest utils for testing. For consistency I'm also updating deep comparison references with cmp equivalents.

Note: this can't be merged until it is rebased with main

@wagoodman wagoodman requested a review from a team October 24, 2022 21:13
@wagoodman wagoodman changed the title update cataloger tests to use pkgtest utils Update cataloger tests to use pkgtest utils Oct 24, 2022
Base automatically changed from update-dotnet-generic-cataloger to main October 24, 2022 21:17
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 24, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    11.3ms ± 1%     8.3ms ± 0%  -26.08%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.34ms ±11%    0.92ms ± 1%  -31.07%  (p=0.016 n=5+4)
ImagePackageCatalogers/python-package-cataloger-2            3.23ms ± 1%    2.38ms ± 1%  -26.38%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.05ms ± 1%    0.75ms ± 1%  -29.19%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         738µs ± 0%     514µs ± 1%  -30.34%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     875µs ± 1%     602µs ± 2%  -31.24%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.26ms ± 1%    0.87ms ± 1%  -31.13%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      14.3ms ± 1%    10.2ms ± 1%  -28.58%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.24ms ± 3%    0.91ms ± 2%  -27.12%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.20µs ± 1%    1.62µs ± 1%  -26.10%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.37ms ± 0%    0.99ms ± 1%  -27.95%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    701µs ± 0%     476µs ± 0%  -32.17%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%   -0.03%  (p=0.016 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             944kB ± 0%     944kB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     213kB ± 0%     213kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     203kB ± 0%     203kB ± 0%     ~     (p=0.198 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     301kB ± 0%     302kB ± 0%   +0.06%  (p=0.040 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                376kB ± 0%     376kB ± 0%   +0.05%  (p=0.032 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%     ~     (p=0.690 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.24k ± 0%     4.24k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             16.5k ± 0%     16.5k ± 0%     ~     (p=0.198 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.50k ± 0%     5.50k ± 0%     ~     (p=0.095 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.57k ± 0%     4.57k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.11k ± 0%     8.11k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.802 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.39k ± 0%     5.39k ± 0%     ~     (all equal)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.32k ± 0%     7.32k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.58k ± 0%     3.58k ± 0%     ~     (all equal)

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman force-pushed the use-new-generic-cataloger-test-pkg branch from a6c9773 to 41bc813 Compare October 24, 2022 23:24
@wagoodman wagoodman merged commit bd5adbc into main Oct 25, 2022
@wagoodman wagoodman deleted the use-new-generic-cataloger-test-pkg branch October 25, 2022 15:20
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants