Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I2I: Multi-selector support for visibility trigger #26823

Closed
7 of 8 tasks
micajuine-ho opened this issue Feb 14, 2020 · 5 comments · Fixed by #34950
Closed
7 of 8 tasks

I2I: Multi-selector support for visibility trigger #26823

micajuine-ho opened this issue Feb 14, 2020 · 5 comments · Fixed by #34950
Assignees
@micajuine-ho
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code WG: analytics

Comments

@micajuine-ho
Copy link
Contributor

micajuine-ho commented Feb 14, 2020 •
edited
Loading

Follow up to #11380.

NOTE: This only applies to visibility triggers as well as static content (i.e. no mustache template selectors, no dynamic content). At this time, visibility triggers only work for amp-elements.

Summary

  • Multi-selector support: Add support for a single visibility trigger to support multiple selectors
  • QuerySelectorAll support: Add support for a visibility trigger’s selector(s) to track all elements have the selector(s) (instead of the first element)

Design document

External Doc

Design Proposal

  • Multi-selector: Add array support for the selector field within a visibility trigger
  • QuerySelectorAll: All selectors within the multi-selector array will be treated as querySelectorAll
  • Restrict listeners (and requests) for elements that do not have a data-var-* attribute

See the design doc above for details.

Motivation

In amp-analytics, it is hard for publishers to track the visibility of elements that share selectors. Our current implementation only allows a one-to-one mapping between a single element and visibility trigger. This presents a challenge for publishers who would like to track the visibility of all similar elements, such as all amp-ads or all paragraphs in an article.

Launch tracker

/cc @lannka @zhouyx
@micajuine-ho micajuine-ho added the INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code label Feb 14, 2020
@micajuine-ho micajuine-ho self-assigned this Feb 14, 2020
@zhouyx
Copy link
Contributor

zhouyx commented Feb 14, 2020

Thank you @micajuine-ho this is going to save a lot of configurations!
Could you please highlight the format of the chosen proposal.

@micajuine-ho micajuine-ho mentioned this issue Feb 19, 2020
Merged
@micajuine-ho
Copy link
Contributor Author

Could you please highlight the format of the chosen proposal.

Updated!

This was referenced Feb 20, 2020
Merged
Merged
Merged
Closed
@micajuine-ho micajuine-ho mentioned this issue Feb 28, 2020
Closed
@zhouyx zhouyx mentioned this issue Jun 10, 2020
Closed
@micajuine-ho micajuine-ho mentioned this issue Jun 18, 2020
Closed
@micajuine-ho micajuine-ho mentioned this issue Jul 7, 2020
Merged
@enderton
Copy link

enderton commented Oct 9, 2020

Hello! We've been following this issue, and are very excited for these changes to improve our impression analytics logic (and have tried it locally in development). Is there a known timeline for when the experiment flag will be removed (for the querySelectorAll portion)? Thanks.

@micajuine-ho
Copy link
Contributor Author

Hi @enderton, have you used this feature with the experiment flag on?

@enderton
Copy link

enderton commented Oct 9, 2020

Yes - in local and staged environments, yes (via toggling in dev tools AMP.toggleExperiment('visibility-trigger-improvements').

Is not yet in production code served by AMP CDN, so have not used https://amp.dev/documentation/guides-and-tutorials/learn/experimental/#served-from-cdn.ampproject.org.

It's our understanding that we could not enable this experiment for all users, so have held off making part of production code.

@micajuine-ho micajuine-ho mentioned this issue Oct 26, 2020
Merged
This was referenced Nov 23, 2020
Merged
Merged
@micajuine-ho micajuine-ho mentioned this issue Mar 24, 2021
Open
@micajuine-ho micajuine-ho mentioned this issue Jun 22, 2021
Merged
github-actions bot pushed a commit to mohammed-ibra/amphtml that referenced this issue Mar 1, 2024
@mohammed-ibra
🚮 Sweep experiments older than 2023-03-01
c07dffa 
Sweep experiments last flipped globally up to 2023-03-01:

- (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1
- (2020-11-19, cac0248) `amp-accordion-display-locking`: 1
- (2020-08-14, 77ced1d) `expand-json-targeting`: 1
- (2021-01-27, b738789) `visibility-trigger-improvements`: 1
- (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1
- (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1
- (2021-03-17, db781bd) `amp-consent-granular-consent`: 1
- (2021-03-23, 1115f6c) `amp-cid-backup`: 1

---

### Cleanup issues

Close these once they've been addressed and this PR has been merged:

- [ ] `adsense-ad-size-optimization`: ampproject#24165
- [ ] `visibility-trigger-improvements`: ampproject#26823
- [ ] `amp-cid-backup`: ampproject#29484

---

### ⚠️ Javascript source files require intervention

The following may contain errors and/or require intervention to remove superfluous conditionals:

- [ ] `extensions/amp-a4a/0.1/amp-a4a.js`
- [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js`
- [ ] `extensions/amp-accordion/0.1/amp-accordion.js`
- [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js`
- [ ] `extensions/amp-analytics/0.1/analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-events.js`
- [ ] `extensions/amp-consent/0.1/amp-consent.js`
- [ ] `extensions/amp-consent/0.1/consent-ui.js`
- [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js`
- [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js`
- [ ] `src/custom-element.js`
- [ ] `src/service/cid-impl.js`
- [ ] `test/unit/test-custom-element.js`

Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup)

---

### ⚠️ HTML files may still contain references

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- [ ] `examples/accordion.amp.html`
- [ ] `examples/amp-consent/amp-consent-3p-postmessage.html`
- [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html`
- [ ] `test/manual/amp-consent/amp-consent-granular-consent.html`

Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
@github-actions github-actions bot mentioned this issue Mar 1, 2024
Draft
23 tasks
github-actions bot pushed a commit to mohammed-ibra/amphtml that referenced this issue Apr 1, 2024
@mohammed-ibra
🚮 Sweep experiments older than 2023-04-01
3e4bcb7 
Sweep experiments last flipped globally up to 2023-04-01:

- (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1
- (2020-11-19, cac0248) `amp-accordion-display-locking`: 1
- (2020-08-14, 77ced1d) `expand-json-targeting`: 1
- (2021-01-27, b738789) `visibility-trigger-improvements`: 1
- (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1
- (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1
- (2021-03-17, db781bd) `amp-consent-granular-consent`: 1
- (2021-03-23, 1115f6c) `amp-cid-backup`: 1

---

### Cleanup issues

Close these once they've been addressed and this PR has been merged:

- [ ] `adsense-ad-size-optimization`: ampproject#24165
- [ ] `visibility-trigger-improvements`: ampproject#26823
- [ ] `amp-cid-backup`: ampproject#29484

---

### ⚠️ Javascript source files require intervention

The following may contain errors and/or require intervention to remove superfluous conditionals:

- [ ] `extensions/amp-a4a/0.1/amp-a4a.js`
- [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js`
- [ ] `extensions/amp-accordion/0.1/amp-accordion.js`
- [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js`
- [ ] `extensions/amp-analytics/0.1/analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-events.js`
- [ ] `extensions/amp-consent/0.1/amp-consent.js`
- [ ] `extensions/amp-consent/0.1/consent-ui.js`
- [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js`
- [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js`
- [ ] `src/custom-element.js`
- [ ] `src/service/cid-impl.js`
- [ ] `test/unit/test-custom-element.js`

Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup)

---

### ⚠️ HTML files may still contain references

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- [ ] `examples/accordion.amp.html`
- [ ] `examples/amp-consent/amp-consent-3p-postmessage.html`
- [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html`
- [ ] `test/manual/amp-consent/amp-consent-granular-consent.html`

Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Draft
23 tasks
github-actions bot pushed a commit to mohammed-ibra/amphtml that referenced this issue May 1, 2024
@mohammed-ibra
🚮 Sweep experiments older than 2023-05-01
36be40a 
Sweep experiments last flipped globally up to 2023-05-01:

- (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1
- (2020-11-19, cac0248) `amp-accordion-display-locking`: 1
- (2020-08-14, 77ced1d) `expand-json-targeting`: 1
- (2021-01-27, b738789) `visibility-trigger-improvements`: 1
- (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1
- (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1
- (2021-03-17, db781bd) `amp-consent-granular-consent`: 1
- (2021-03-23, 1115f6c) `amp-cid-backup`: 1

---

### Cleanup issues

Close these once they've been addressed and this PR has been merged:

- [ ] `adsense-ad-size-optimization`: ampproject#24165
- [ ] `visibility-trigger-improvements`: ampproject#26823
- [ ] `amp-cid-backup`: ampproject#29484

---

### ⚠️ Javascript source files require intervention

The following may contain errors and/or require intervention to remove superfluous conditionals:

- [ ] `extensions/amp-a4a/0.1/amp-a4a.js`
- [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js`
- [ ] `extensions/amp-accordion/0.1/amp-accordion.js`
- [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js`
- [ ] `extensions/amp-analytics/0.1/analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-events.js`
- [ ] `extensions/amp-consent/0.1/amp-consent.js`
- [ ] `extensions/amp-consent/0.1/consent-ui.js`
- [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js`
- [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js`
- [ ] `src/custom-element.js`
- [ ] `src/service/cid-impl.js`
- [ ] `test/unit/test-custom-element.js`

Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup)

---

### ⚠️ HTML files may still contain references

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- [ ] `examples/accordion.amp.html`
- [ ] `examples/amp-consent/amp-consent-3p-postmessage.html`
- [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html`
- [ ] `test/manual/amp-consent/amp-consent-granular-consent.html`

Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
@github-actions github-actions bot mentioned this issue May 1, 2024
Draft
23 tasks
github-actions bot pushed a commit to mohammed-ibra/amphtml that referenced this issue Jun 1, 2024
@mohammed-ibra
🚮 Sweep experiments older than 2023-06-01
8780983 
Sweep experiments last flipped globally up to 2023-06-01:

- (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1
- (2020-11-19, cac0248) `amp-accordion-display-locking`: 1
- (2020-08-14, 77ced1d) `expand-json-targeting`: 1
- (2021-01-27, b738789) `visibility-trigger-improvements`: 1
- (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1
- (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1
- (2021-03-17, db781bd) `amp-consent-granular-consent`: 1
- (2021-03-23, 1115f6c) `amp-cid-backup`: 1

---

### Cleanup issues

Close these once they've been addressed and this PR has been merged:

- [ ] `adsense-ad-size-optimization`: ampproject#24165
- [ ] `visibility-trigger-improvements`: ampproject#26823
- [ ] `amp-cid-backup`: ampproject#29484

---

### ⚠️ Javascript source files require intervention

The following may contain errors and/or require intervention to remove superfluous conditionals:

- [ ] `extensions/amp-a4a/0.1/amp-a4a.js`
- [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js`
- [ ] `extensions/amp-accordion/0.1/amp-accordion.js`
- [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js`
- [ ] `extensions/amp-analytics/0.1/analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-events.js`
- [ ] `extensions/amp-consent/0.1/amp-consent.js`
- [ ] `extensions/amp-consent/0.1/consent-ui.js`
- [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js`
- [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js`
- [ ] `src/custom-element.js`
- [ ] `src/service/cid-impl.js`
- [ ] `test/unit/test-custom-element.js`

Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup)

---

### ⚠️ HTML files may still contain references

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- [ ] `examples/accordion.amp.html`
- [ ] `examples/amp-consent/amp-consent-3p-postmessage.html`
- [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html`
- [ ] `test/manual/amp-consent/amp-consent-granular-consent.html`

Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
@github-actions github-actions bot mentioned this issue Jun 1, 2024
Draft
23 tasks
github-actions bot pushed a commit to mohammed-ibra/amphtml that referenced this issue Jul 1, 2024
@mohammed-ibra
🚮 Sweep experiments older than 2023-07-01
8c7f71e 
Sweep experiments last flipped globally up to 2023-07-01:

- (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1
- (2020-11-19, cac0248) `amp-accordion-display-locking`: 1
- (2020-08-14, 77ced1d) `expand-json-targeting`: 1
- (2021-01-27, b738789) `visibility-trigger-improvements`: 1
- (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1
- (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1
- (2021-03-17, db781bd) `amp-consent-granular-consent`: 1
- (2021-03-23, 1115f6c) `amp-cid-backup`: 1

---

### Cleanup issues

Close these once they've been addressed and this PR has been merged:

- [ ] `adsense-ad-size-optimization`: ampproject#24165
- [ ] `visibility-trigger-improvements`: ampproject#26823
- [ ] `amp-cid-backup`: ampproject#29484

---

### ⚠️ Javascript source files require intervention

The following may contain errors and/or require intervention to remove superfluous conditionals:

- [ ] `extensions/amp-a4a/0.1/amp-a4a.js`
- [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js`
- [ ] `extensions/amp-accordion/0.1/amp-accordion.js`
- [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js`
- [ ] `extensions/amp-analytics/0.1/analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-events.js`
- [ ] `extensions/amp-consent/0.1/amp-consent.js`
- [ ] `extensions/amp-consent/0.1/consent-ui.js`
- [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js`
- [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js`
- [ ] `src/custom-element.js`
- [ ] `src/service/cid-impl.js`
- [ ] `test/unit/test-custom-element.js`

Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup)

---

### ⚠️ HTML files may still contain references

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- [ ] `examples/accordion.amp.html`
- [ ] `examples/amp-consent/amp-consent-3p-postmessage.html`
- [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html`
- [ ] `test/manual/amp-consent/amp-consent-granular-consent.html`

Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Draft
23 tasks
github-actions bot pushed a commit to mohammed-ibra/amphtml that referenced this issue Aug 1, 2024
@mohammed-ibra
🚮 Sweep experiments older than 2023-08-01
3f6575c 
Sweep experiments last flipped globally up to 2023-08-01:

- (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1
- (2020-11-19, cac0248) `amp-accordion-display-locking`: 1
- (2020-08-14, 77ced1d) `expand-json-targeting`: 1
- (2021-01-27, b738789) `visibility-trigger-improvements`: 1
- (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1
- (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1
- (2021-03-17, db781bd) `amp-consent-granular-consent`: 1
- (2021-03-23, 1115f6c) `amp-cid-backup`: 1

---

### Cleanup issues

Close these once they've been addressed and this PR has been merged:

- [ ] `adsense-ad-size-optimization`: ampproject#24165
- [ ] `visibility-trigger-improvements`: ampproject#26823
- [ ] `amp-cid-backup`: ampproject#29484

---

### ⚠️ Javascript source files require intervention

The following may contain errors and/or require intervention to remove superfluous conditionals:

- [ ] `extensions/amp-a4a/0.1/amp-a4a.js`
- [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js`
- [ ] `extensions/amp-accordion/0.1/amp-accordion.js`
- [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js`
- [ ] `extensions/amp-analytics/0.1/analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-events.js`
- [ ] `extensions/amp-consent/0.1/amp-consent.js`
- [ ] `extensions/amp-consent/0.1/consent-ui.js`
- [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js`
- [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js`
- [ ] `src/custom-element.js`
- [ ] `src/service/cid-impl.js`
- [ ] `test/unit/test-custom-element.js`

Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup)

---

### ⚠️ HTML files may still contain references

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- [ ] `examples/accordion.amp.html`
- [ ] `examples/amp-consent/amp-consent-3p-postmessage.html`
- [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html`
- [ ] `test/manual/amp-consent/amp-consent-granular-consent.html`

Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
@github-actions github-actions bot mentioned this issue Aug 1, 2024
Draft
23 tasks
github-actions bot pushed a commit to mohammed-ibra/amphtml that referenced this issue Sep 1, 2024
@mohammed-ibra
🚮 Sweep experiments older than 2023-09-01
e48ff2f 
Sweep experiments last flipped globally up to 2023-09-01:

- (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1
- (2020-11-19, cac0248) `amp-accordion-display-locking`: 1
- (2020-08-14, 77ced1d) `expand-json-targeting`: 1
- (2021-01-27, b738789) `visibility-trigger-improvements`: 1
- (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1
- (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1
- (2021-03-17, db781bd) `amp-consent-granular-consent`: 1
- (2021-03-23, 1115f6c) `amp-cid-backup`: 1

---

### Cleanup issues

Close these once they've been addressed and this PR has been merged:

- [ ] `adsense-ad-size-optimization`: ampproject#24165
- [ ] `visibility-trigger-improvements`: ampproject#26823
- [ ] `amp-cid-backup`: ampproject#29484

---

### ⚠️ Javascript source files require intervention

The following may contain errors and/or require intervention to remove superfluous conditionals:

- [ ] `extensions/amp-a4a/0.1/amp-a4a.js`
- [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js`
- [ ] `extensions/amp-accordion/0.1/amp-accordion.js`
- [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/amp-accordion.js`
- [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js`
- [ ] `extensions/amp-analytics/0.1/analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js`
- [ ] `extensions/amp-analytics/0.1/test/test-events.js`
- [ ] `extensions/amp-consent/0.1/amp-consent.js`
- [ ] `extensions/amp-consent/0.1/consent-ui.js`
- [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js`
- [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js`
- [ ] `src/custom-element.js`
- [ ] `src/service/cid-impl.js`
- [ ] `test/unit/test-custom-element.js`

Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup)

---

### ⚠️ HTML files may still contain references

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- [ ] `examples/accordion.amp.html`
- [ ] `examples/amp-consent/amp-consent-3p-postmessage.html`
- [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html`
- [ ] `test/manual/amp-consent/amp-consent-granular-consent.html`

Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
@github-actions github-actions bot mentioned this issue Sep 1, 2024
Draft
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micajuine-ho micajuine-ho

Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code WG: analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🚮[amp-analytics] Clean up visibility trigger improvement experiment micajuine-ho/amphtml
5 participants
@kristoferbaxter @zhouyx @enderton @dreamofabear @micajuine-ho