🚮 Sweep experiments older than 2023-03-01 #423
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Previous history on prod-config.json: - a9e2778 - 2021-01-20T20:47:24+00:00 - Ramp up the adsense-ad-size-optimization experiment to 100%.
Previous history on prod-config.json: - cac0248 - 2020-11-19T12:26:09-05:00 - Increase from 10% to 100%
Previous history on prod-config.json: - 77ced1d - 2020-08-14T15:52:39-07:00 - Ramp json targeting expansion experiment to 100%
Previous history on prod-config.json: - b738789 - 2021-01-27T13:32:15-08:00 - Launch layout-aspect-ratio-css to 1% - c0de64d - 2021-01-19T20:39:22-05:00 - Revert "✨ Implement sticky ad bottom type ad on amp-ad (ampproject#31491)" - 5f43080 - 2021-01-07T13:54:47-08:00 - ✨ Implement sticky ad bottom type ad on amp-ad
Previous history on prod-config.json: - 77127c7 - 2021-03-05T09:36:06-08:00 - Turn on backupCid experiment in prod
Previous history on prod-config.json: - 1b7583d - 2021-03-12T07:22:55-08:00 - 🧪 [amp-consent] Turn on TCF PostMessage Proxy API Experiment
Previous history on prod-config.json: - db781bd - 2021-03-17T09:35:48-07:00 - turnOnGranularConsent
Previous history on prod-config.json: - 1115f6c - 2021-03-23T03:46:29+08:00 - Ramp up 3p-vendor-split experiment
Sweep experiments last flipped globally up to 2023-03-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 - (2020-11-19, cac0248) `amp-accordion-display-locking`: 1 - (2020-08-14, 77ced1d) `expand-json-targeting`: 1 - (2021-01-27, b738789) `visibility-trigger-improvements`: 1 - (2021-03-05, 77127c7) `disable-a4a-non-sd`: 1 - (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1 - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 - (2021-03-23, 1115f6c) `amp-cid-backup`: 1 --- ### Cleanup issues Close these once they've been addressed and this PR has been merged: - [ ] `adsense-ad-size-optimization`: ampproject#24165 - [ ] `visibility-trigger-improvements`: ampproject#26823 - [ ] `amp-cid-backup`: ampproject#29484 --- ###⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-a4a/0.1/amp-a4a.js` - [ ] `extensions/amp-a4a/0.1/test/test-amp-a4a.js` - [ ] `extensions/amp-accordion/0.1/amp-accordion.js` - [ ] `extensions/amp-accordion/0.1/test/test-amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/amp-accordion.js` - [ ] `extensions/amp-accordion/1.0/test/test-amp-accordion.js` - [ ] `extensions/amp-analytics/0.1/analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-analytics-root.js` - [ ] `extensions/amp-analytics/0.1/test/test-events.js` - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `src/service/cid-impl.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup) --- ###⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `examples/accordion.amp.html` - [ ] `examples/amp-consent/amp-consent-3p-postmessage.html` - [ ] `test/manual/amp-analytics/amp-analytics-multi-selector.html` - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/master/build-system/tasks/sweep-experiments/README.md#followup:html)
|
You may checkout this pull request to follow-up manually: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sweep experiments last flipped globally up to 2023-03-01:
adsense-ad-size-optimization: 1amp-accordion-display-locking: 1expand-json-targeting: 1visibility-trigger-improvements: 1disable-a4a-non-sd: 1tcf-post-message-proxy-api: 1amp-consent-granular-consent: 1amp-cid-backup: 1Cleanup issues
Close these once they've been addressed and this PR has been merged:
adsense-ad-size-optimization: Cleanup adsense-ad-size-optimization experiment ampproject/amphtml#24165visibility-trigger-improvements: I2I: Multi-selector support for visibility trigger ampproject/amphtml#26823amp-cid-backup: Backup the client ID in local storage ampproject/amphtml#29484The following may contain errors and/or require intervention to remove superfluous conditionals:
extensions/amp-a4a/0.1/amp-a4a.jsextensions/amp-a4a/0.1/test/test-amp-a4a.jsextensions/amp-accordion/0.1/amp-accordion.jsextensions/amp-accordion/0.1/test/test-amp-accordion.jsextensions/amp-accordion/1.0/amp-accordion.jsextensions/amp-accordion/1.0/test/test-amp-accordion.jsextensions/amp-analytics/0.1/analytics-root.jsextensions/amp-analytics/0.1/test/test-analytics-root.jsextensions/amp-analytics/0.1/test/test-events.jsextensions/amp-consent/0.1/amp-consent.jsextensions/amp-consent/0.1/consent-ui.jsextensions/amp-consent/0.1/test/test-amp-consent.jsextensions/amp-consent/0.1/test/test-consent-ui.jssrc/custom-element.jssrc/service/cid-impl.jstest/unit/test-custom-element.jsRefer to the removal guide for suggestions on handling these modified Javascript files.
The following HTML files contain references to experiment names which may be stale and should be manually removed:
examples/accordion.amp.htmlexamples/amp-consent/amp-consent-3p-postmessage.htmltest/manual/amp-analytics/amp-analytics-multi-selector.htmltest/manual/amp-consent/amp-consent-granular-consent.htmlRefer to the removal guide for suggestions on handling these HTML files.