Turn on visibility-trigger-improvments experiment in canary #30861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
We introduced the experiment flag because this is a behavior change as the selector now also select non AMP element. Shall we ship the change to canary first? |
|
Yes, that sounds good. Would you suggest 1 or 2 weeks in canary? |
|
I recommend 2 weeks if there's no urgent request. |
micajuine-ho
force-pushed
the
visibilityFlags
branch
from
7d9c524
to
b79d22c
Compare
micajuine-ho
changed the title
zhouyx
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on feature flag in canary for
visibility-trigger-improvments.Turn on the flag in prod 2 weeks from now.
For #26823