Rebrand Classic as Reader mode and Paired as Transitional mode; add Exit Reader Mode link #2034

felixarntz · 2019-03-28T09:28:06Z

Fixes #1943. Fixes #2022.

Replaces Classic mode with Reader mode in wording.
Adjusts relevant user-facing language to better match Reader mode intentions.
Renames Paired mode to Transitional mode.
Updates description of the modes.
Adds a link to the top-right corner of the Reader mode template which points to the same resource in non-AMP version.
Fixes erroneous inclusion of AMP panel in Customizer when theme support is present (these settings only apply to Reader mode).

I decided on going with an additional link to the canonical version because using the current comments link for that would be misleading. It points to the comments section of the post, where what we want is just a link to exit Reader mode and view the canonical version. Furthermore, if we just replaced that "Leave a Comment" link with an "Exit Reader Mode" link, it would be an unexpected location for such a link, as you typically add comments below a post.

felixarntz · 2019-03-28T09:32:04Z

includes/options/class-amp-options-menu.php

 						</label>
 					</dt>
 					<dd>
-						<?php esc_html_e( 'Display AMP responses in classic (legacy) post templates in a basic design that does not match your theme\'s templates.', 'amp' ); ?>
+						<?php esc_html_e( 'Display AMP responses in a simplified reader mode design that does not match your theme\'s templates.', 'amp' ); ?>


We might need to discuss how to best phrase this here. Do we want to highlight that it's not respecting the theme's design? Should we maybe phrase this as "separate from your theme" to sound less negative?

Display AMP responses in a simplified reader mode design separate from your theme could work

Another alternative: Generates AMP content using simplified templates, which are light but may not match the look-and-feel of your site

felixarntz · 2019-03-28T09:32:25Z

includes/templates/class-amp-post-template.php

+				'post_modified_timestamp'  => $post_modified_timestamp,
+				'post_author'              => $post_author,
+				'post_canonical_link_url'  => get_permalink( $this->ID ),
+				'post_canonical_link_text' => __( 'Exit Reader Mode', 'amp' ),


Alternatively, we could say "View Canonical". What do you think?

I don't think the average user knows what "Canonical" means in this context. Not to speak of translators. "Original" or "Full Version" would work better though

Exit Reader Mode sounds reasonable though.

For comparison, Safari uses "Hide Reader View".

I see the point of "View Canonical", but it is true that is will be confusing for most users. OTOH, having "Exit Reader Mode" implies that the user is aware that she is in Reader Mode. Probably we can express the duality by a exit route with a message along these lines: "You are viewing the Reader Mode version of <this post>", where <this post> links to the canonical version.

felixarntz · 2019-03-28T09:35:48Z

readme.txt

-1. A WP-CLI command is provided to check the URLs on a site for AMP validity. Results are available in the admin for inspection.
+2. Many themes can be served as AMP without any changes; the default experience is as if JavaScript is turned off in the browser since scripts are removed.
+3. Reader mode templates are still available, but they are are limited. Not only do they differ from the active theme, any validation errors are silently sanitized.
+4. Switch from Reader mode to Paired or Native mode in AMP settings screen. You may need to disable the admin bar in AMP if your theme has a larger amount of CSS.


Screenshots 3 and 4 need to be refreshed. @westonruter @ThierryA Do you have the originals there?

@felixarntz what to do you mean by originals?

Original screenshots? Yes. For screenshot 3 I just went to https://2017-theme.amp-wp.org/roads-of-the-city/ and enabled classic mode.

And I took the screenshot of the AMP settings screen from that environment too.

readme.md

felixarntz · 2019-03-28T17:03:42Z

I will continue work on this on Monday, and also cover the rebranding of Paired mode, per our earlier conversation.

amedina

We should add a configuration option on the Reader mode selection panel, where the user opts in to having the "Exit Reader" mode link added to their templates. This would be important in cases where the addition of the link would interfere with customizations made to classic templates.

…e it opt-in.

felixarntz · 2019-04-01T12:35:49Z

The latest commits take care of rebranding Paired Mode and making the Reader mode exit link opt-in via a Customizer control.

amedina · 2019-04-01T22:34:07Z

Another piece of this PR: rebranding of Native mode to Strict AMP Mode.

amedina · 2019-04-01T23:08:23Z

I can't see the Exit Reader Mode link anymore, or the configuration option.

felixarntz · 2019-04-02T11:31:54Z

@amedina

Another piece of this PR: rebranding of Native mode to Strict AMP Mode.

I think we should have a separate discussion around this and keep this PR focused on Reader and Paired modes. To me, Strict Mode is different from Native Mode:

While Native Mode ensures an AMP-compatible experience with auto-sanitization but potentially breaks JS-based content, Strict Mode pretty much provides a turnkey solution, as AMP-incompatible extensions can't be installed.
A developer with AMP experience might be unnecessarily restricted by Strict Mode, as they might know that a specific plugin is AMP-compatible even though it's not part of our official AMP whitelist. However, such users would still wanna benefit from Native Mode. I personally would for example fall under that group - I'd wanna use Native Mode, but not Strict Mode.
Native Mode can always be enabled, however Strict Mode as we've been envisioning it only really works well on a new site (see our previous WP3 discussions).

I think Strict Mode should either be a fourth mode, or a checkbox that is available when Native Mode is active.

I can't see the Exit Reader Mode link anymore, or the configuration option.

The exit link is now opt-in as you suggested. You can control it in the Customizer together with the other header bar customizations.

westonruter · 2019-04-03T20:28:55Z

includes/options/class-amp-options-menu.php

+
+		$native_description       = __( 'Reuses active theme\'s templates to display AMP responses but does not use separate URLs for AMP. This means your site is <b>AMP-first</b> and your canonical URLs are AMP.', 'amp' );
+		$transitional_description = __( 'Reuses active theme\'s templates to display AMP responses, but uses separate URLs for AMP. Each canonical URL may have a corresponding AMP URL, if the content is fully AMP valid.', 'amp' );
+		$reader_description       = __( 'Generates AMP content using simplified templates, which are light but may not match the look-and-feel of your site.', 'amp' );


I think this description should perhaps note something about classic, like “These include the classic templates.”

This also should note that only posts/pages can be served as AMP in this mode. It is not suitable for other kinds of queries.

westonruter · 2019-04-03T20:30:05Z

includes/options/class-amp-options-menu.php

+		$theme_support = AMP_Options_Manager::get_option( 'theme_support' );
+
+		$native_description       = __( 'Reuses active theme\'s templates to display AMP responses but does not use separate URLs for AMP. This means your site is <b>AMP-first</b> and your canonical URLs are AMP.', 'amp' );
+		$transitional_description = __( 'Reuses active theme\'s templates to display AMP responses, but uses separate URLs for AMP. Each canonical URL may have a corresponding AMP URL, if the content is fully AMP valid.', 'amp' );


I think the transitional mode and (especially) reader mode should both include a note that says mobile visitors to origin will not be automatically redirected to the AMP version. The AMP version is presented to mobile users encountering your content via Google Search, Twitter, etc.

westonruter · 2019-04-03T20:32:29Z

readme.txt

-1. Activate the plugin through the 'Plugins' menu in WordPress.
-1. If you currently use older versions of the plugin in `Classic mode`, it is strongly encouraged to migrate to `Paired` or `Native mode`.
+2. Activate the plugin through the 'Plugins' menu in WordPress.
+3. If you currently use older versions of the plugin in `Reader` mode, it is strongly encouraged to migrate to `Transitional` or `Native` mode.


The note about the behavior of reader/transitional modes should also be added here, that they are for mobile visitors from Google Search, Twitter, etc. No redirection is done. This is not a mobile theme.

/cc @amedina

Agree. Same line from the Admin Settings page would work.

westonruter

@amedina Here is is what the setting looks like:

With the exit link displayed:

@felixarntz There seems to be a styling issue with the link with the site icon.

…r-mode * 'develop' of github.com:ampproject/amp-wp: (50 commits) Fix printing of PHP upgrade notice Fix PHP notice for undefined theme support arg for service_worker Remove admin pointer tests that fail in 1.1 Discontinue showing theme support admin pointer in 1.1 Add tests for AMP integration with PWA plugin Ensure is_amp_endpoint() returns false for service worker requests Account for element attributes when determining if a parent is empty and can be removed Fix tests after always including Gutenberg Add check for argument type in add_google_fonts_caching; advise to update to PWA 0.2 Align default-enabled service worker features with ABE SW Remove todo resolved by GoogleChromeLabs/pwa-wp#147 Make AMP service worker opt-out instead of opt-in Opt-in to amp-img-auto-sizes experiment when there are converted images Remove obsolete add_auto_width_to_figure from #1086 Add test for sizes attribute being removed from converted img Improve aligncenter, alignwide, and alignfull in classic templates Rename method to adjust_twentynineteen_images Eliminate sizes from amp-img converted from img Ensure featured image gets responsive layout in Twenty Nineteen, as it is essentially alignwide Give responsive layout to alignwide/alignfull instead of intrinsic layout ...

westonruter · 2019-04-05T20:42:46Z

Updates to description after iterating with @amedina:

Outstanding is the styling of the exit link.

… is present

…an method

westonruter · 2019-04-05T22:35:21Z

When site icon is absent:

When site icon is present:

…r-mode * 'develop' of github.com:ampproject/amp-wp: Add missing amp-install-serviceworker script in classic mode

amedina · 2019-04-05T23:39:40Z

I like the design of the "Exit Reader Mode" style.

felixarntz added 2 commits March 28, 2019 10:18

Rebrand Classic mode as Reader mode.

3418a56

Add link for exiting reader mode to reader mode templates.

7d2c9ac

felixarntz requested review from westonruter and amedina March 28, 2019 09:28

googlebot added the cla: yes Signed the Google CLA label Mar 28, 2019

felixarntz commented Mar 28, 2019

View reviewed changes

Fix incorrect screenshot numbering in readme.

33a4cb4

felixarntz commented Mar 28, 2019

View reviewed changes

felixarntz mentioned this pull request Mar 28, 2019

Re-brand Paired mode as Transitional mode #2022

Closed

swissspidy reviewed Mar 28, 2019

View reviewed changes

readme.md Outdated Show resolved Hide resolved

felixarntz changed the title ~~Rebrand Classic mode as Reader mode~~ Rebrand Classic as Reader mode and Paired as Transitional mode Mar 28, 2019

amedina reviewed Mar 31, 2019

View reviewed changes

felixarntz added 4 commits April 1, 2019 12:01

Update reader mode description.

d5cdd94

Restore spaces in readme.

089fc62

Rebrand Paired as Transitional mode.

09df6d8

Introduce Customizer UI for controlling reader mode exit link and mak…

982bf65

…e it opt-in.

westonruter mentioned this pull request Apr 1, 2019

Extend classic/reader templates with commonly-requested features #2044

Closed

westonruter reviewed Apr 3, 2019

View reviewed changes

westonruter requested changes Apr 3, 2019

View reviewed changes

westonruter added this to the v1.1 milestone Apr 3, 2019

westonruter added 2 commits April 5, 2019 12:46

Update mode descriptions

c269707

Prevent showing any reader Customizer settings when AMP theme support…

b360935

… is present

westonruter added 2 commits April 5, 2019 14:43

Reuse rest_sanitize_boolean function instead of adding sanitize_boole…

11ea84c

…an method

Fix position of exit reader link when site icon present

611f53c

westonruter requested a review from amedina April 5, 2019 22:36

westonruter approved these changes Apr 5, 2019

View reviewed changes

westonruter added 2 commits April 5, 2019 15:46

Revert changes to legacy 0.3 templates since obsolete

5df747d

Merge branch 'develop' of github.com:ampproject/amp-wp into add/reade…

297e668

…r-mode * 'develop' of github.com:ampproject/amp-wp: Add missing amp-install-serviceworker script in classic mode

westonruter changed the title ~~Rebrand Classic as Reader mode and Paired as Transitional mode~~ Rebrand Classic as Reader mode and Paired as Transitional mode; add Exit Reader Mode link Apr 5, 2019

westonruter added the changelogged label Apr 5, 2019

westonruter and others added 5 commits April 5, 2019 16:54

Add note about dev work being needed for non-reader mode

e35d629

Add clarification about mobile redirections

a35e51f

Update screenshots and squooshify

c007f2f

Always include amp-wp-canonical-link style in customizer preview

cabdf2b

Update behavior description in readme

8026f7a

westonruter merged commit e33ba10 into develop Apr 6, 2019

westonruter deleted the add/reader-mode branch April 6, 2019 02:37

westonruter mentioned this pull request Jun 4, 2019

Phase out “Native” terminology in favor of “AMP-first” #2507

Closed

westonruter mentioned this pull request Dec 16, 2019

Problem with AMP to AMP navigation #3689

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebrand Classic as Reader mode and Paired as Transitional mode; add Exit Reader Mode link #2034

Rebrand Classic as Reader mode and Paired as Transitional mode; add Exit Reader Mode link #2034

felixarntz commented Mar 28, 2019 •

edited by westonruter

Loading

felixarntz Mar 28, 2019

swissspidy Mar 28, 2019

amedina Mar 30, 2019

felixarntz Mar 28, 2019

swissspidy Mar 28, 2019

amedina Mar 30, 2019

felixarntz Mar 28, 2019

ThierryA Apr 4, 2019

westonruter Apr 4, 2019

felixarntz commented Mar 28, 2019

amedina left a comment

felixarntz commented Apr 1, 2019

amedina commented Apr 1, 2019

amedina commented Apr 1, 2019

felixarntz commented Apr 2, 2019 •

edited

Loading

westonruter Apr 3, 2019

westonruter Apr 3, 2019

westonruter Apr 3, 2019

amedina Apr 5, 2019

westonruter left a comment

westonruter commented Apr 5, 2019

westonruter commented Apr 5, 2019 •

edited

Loading

amedina commented Apr 5, 2019

Rebrand Classic as Reader mode and Paired as Transitional mode; add Exit Reader Mode link #2034

Rebrand Classic as Reader mode and Paired as Transitional mode; add Exit Reader Mode link #2034

Conversation

felixarntz commented Mar 28, 2019 • edited by westonruter Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

felixarntz commented Mar 28, 2019

amedina left a comment

Choose a reason for hiding this comment

felixarntz commented Apr 1, 2019

amedina commented Apr 1, 2019

amedina commented Apr 1, 2019

felixarntz commented Apr 2, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

westonruter left a comment

Choose a reason for hiding this comment

westonruter commented Apr 5, 2019

westonruter commented Apr 5, 2019 • edited Loading

amedina commented Apr 5, 2019

felixarntz commented Mar 28, 2019 •

edited by westonruter

Loading

felixarntz commented Apr 2, 2019 •

edited

Loading

westonruter commented Apr 5, 2019 •

edited

Loading