Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase out “Native” terminology in favor of “AMP-first” #2507

Closed
westonruter opened this issue Jun 4, 2019 · 16 comments · Fixed by #2550
Closed

Phase out “Native” terminology in favor of “AMP-first” #2507

westonruter opened this issue Jun 4, 2019 · 16 comments · Fixed by #2550
Assignees
Labels
Enhancement New feature or improvement of an existing one P0 High priority
Milestone

Comments

@westonruter
Copy link
Member

westonruter commented Jun 4, 2019

The AMP settings screen describes the three modes: Reader, Transitional, and Native.

image

Originally Reader was called “Classic” and Transitional was called “Paired”, but these were renamed in #2034. The “Native” name was not changed, however. While it used to be called “canonical AMP” it is now termed “AMP first” as referenced in AMP as your web framework. While the Native mode description does reference AMP-first, the mode itself is not termed that yet. This should change.

Changing the mode name may need to be done as part of a redesign of the whole screen, as with #1288. This especially true as we hope to be able to default sites to AMP-first in the future (as opposed to Reader mode), per #1384.

@amedina
Copy link
Member

amedina commented Jun 4, 2019

A proposal for the naming, as discussed with @pbakaus, is the following:

  • AMP
  • Transitional
  • Reader

The idea is that AMP-first is really just AMP, and the AMP-first name is as confusing, or more, than Native AMP.

@pbakaus
Copy link

pbakaus commented Jun 4, 2019

My $0.02: Since this is a unique scenario where the ability to run AMP for the whole site appears directly in a list next to two other modes, my vote as per @amedina would be to call it just "AMP", or otherwise something like:

  • Default
  • Transitional
  • Reader

or

  • Complete
  • Transitional
  • Reader

or

  • Full
  • Transitional
  • Reader

or

  • Standard
  • Transitional
  • Reader

@westonruter
Copy link
Member Author

I think simply “AMP” is still insufficient because the other modes are also AMP, and even in “AMP” mode you can opt-out for specific posts/pages or for entire templates (e.g. homepage or shopping cart).

“Full” and “Complete” wouldn't work for the same reason, because you can conditionally opt-out of AMP.

“Default” is better, but it isn't the default now (as Reader is), so that could be confusing, at least until #1384.

“Standard” I think I like the most of all these.

@amedina
Copy link
Member

amedina commented Jun 6, 2019

I am leaning to just align with the overall trend and switch from "Native" .to "AMP-first".

It seems no matter what choice we make it will have drawbacks. Better err on the side of consistency then.

@westonruter
Copy link
Member Author

I like “Standard” though because it implies that the site is using AMP primarily, but there are exceptions, such as when there is opt-out at post or template level.

@amedina
Copy link
Member

amedina commented Jun 6, 2019

I see the semantic benefit of "Standard"; I hesitate because the meaning of "standard" is overloaded.

To follow up on your point, perhaps "Default AMP" would capture the goal of outputting AMP by default and allowing for exceptions.

Would you consider a good alternative to "Standard AMP"?

@westonruter
Copy link
Member Author

“Default” is ok, but the default mode now is Reader mode. So users would be confused thinking that Default means Reader, at least until #1384. While overloaded, I still like “Standard” more than these other options.

@amedina
Copy link
Member

amedina commented Jun 7, 2019

Makes sense. In lieu of "Native AMP", I'd vote for "Standard AMP" as well.

@pbakaus
Copy link

pbakaus commented Jun 7, 2019

Can we just do:

Standard (AMP-First)

?

@westonruter
Copy link
Member Author

Along with:

Transitional (Paired AMP)

?

@pbakaus
Copy link

pbakaus commented Jun 7, 2019

Works for me!

@westonruter westonruter added this to the v1.2 milestone Jun 7, 2019
@amedina
Copy link
Member

amedina commented Jun 8, 2019

If we are going to include AMP First why do we need Standard? Similarly, why adding back the Paired terminology we decided before to avoid?

It seems to me we would be regressing.

@westonruter westonruter mentioned this issue Jun 8, 2019
7 tasks
@westonruter
Copy link
Member Author

If we are going to include AMP First why do we need Standard? Similarly, why adding back the Paired terminology we decided before to avoid?

I don't think we were trying to avoid the “Paired” terminology. Mentioning “paired” with the mode explains what kind of AMP it is. We do mention “paired” in the description already:

image

Part of the problem comes down to it being redundant to say “AMP” in the modes, because they are all AMP. It's the AMP settings screen. If one mode has AMP in the name, then shouldn't they all? Does “AMP First” make sense when contrasted alongside “Transitional” and “Reader”?

If we have “AMP First” appearing after “Standard” then this explains what kind of AMP it is. It's not Paired AMP, it's AMP First.

So what about:

  • Standard (AMP First)
  • Transitional (Paired AMP)
  • Reader (Paired AMP)

@amedina
Copy link
Member

amedina commented Jun 9, 2019

Thinking this more through. I think we can go with either @westonruter suggestion of:

Standard (AMP First)
Transitional (Paired AMP)
Reader (Paired AMP)

Or with simply with @pbakaus suggestion:

Standard
Transitional
Reader

@pbakaus WDYT?

@amedina amedina added P0 High priority Enhancement New feature or improvement of an existing one labels Jun 9, 2019
@westonruter
Copy link
Member Author

The latter is less wordy, and the AMP scheme can be indicated in the description.

@pbakaus
Copy link

pbakaus commented Jun 10, 2019

second (less wordy) one works for me! Let's do it.

swissspidy pushed a commit that referenced this issue Jun 11, 2019
* Always allow switching from Transitional to Native on sites that are defined with `add_theme_support('amp', ['paired' => true])`. Fixes #2312.
* Restore suppression of validation error warnings appearing in Reader mode. Fixes #2311
* Add functionality for users to chose AMP + Stories, AMP-only, Stories-only. Fixes #2470
* Phase out “Native” terminology in favor of “AMP-first”. Fixes #2507.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one P0 High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants