Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-brand Paired mode as Transitional mode #2022

Closed
amedina opened this issue Mar 26, 2019 · 6 comments
Closed

Re-brand Paired mode as Transitional mode #2022

amedina opened this issue Mar 26, 2019 · 6 comments
Assignees
@amedina
Labels
P0 High priority
Milestone
v1.1

Comments

@amedina
Copy link
Member

amedina commented Mar 26, 2019

The paired mode is actually a transitional mode aimed at helping developers traverse the path from no AMP to native AMP in an easier way.

This issue addresses this by rebranding the Paired Mode to Transitional Mode.

/cc @westonruter
@amedina amedina added the P0 High priority label Mar 26, 2019
@amedina amedina self-assigned this Mar 26, 2019
@westonruter
Copy link
Member

See also #1943 (comment)

@felixarntz
Copy link
Collaborator

I suggest to create the branch for this from https://github.com/ampproject/amp-wp/tree/add/reader-mode (see #2034) to reduce the chance for merge conflicts.

@felixarntz felixarntz mentioned this issue Mar 28, 2019
Merged
@amedina
Copy link
Member Author

amedina commented Mar 28, 2019

+1. Good idea. Will do.

@westonruter
Copy link
Member

Note that #2034 includes the rebrand.

@westonruter
Copy link
Member

@amedina Is this targeted for 1.1? I assume so.

@westonruter westonruter added this to the v1.1 milestone Apr 3, 2019
@amedina
Copy link
Member Author

amedina commented Apr 3, 2019

Correct. Ideally we would have the rebranding of the modes, and the updates to the Compatibility Tool error status handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amedina amedina

Labels
P0 High priority
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
3 participants
@westonruter @amedina @felixarntz