Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore suppression of validation error warnings appearing in Reader mode #2311

Closed
swissspidy opened this issue May 14, 2019 · 3 comments · Fixed by #2550
Closed

Restore suppression of validation error warnings appearing in Reader mode #2311

swissspidy opened this issue May 14, 2019 · 3 comments · Fixed by #2550
Labels
P0 High priority Validation
Milestone

Comments

@swissspidy
Copy link
Collaborator

Introduced in #2143 and pointed out in #2143 (comment):

Note: One side effect of the changes here (specifically 4645a4a) is that making changes to non-story posts when in Reader mode will start to show the validation error messages. Previously the validation warnings would only be shown when in Native/Transitional mode. The validation notices will likely be a source of complaints for users when in Reader mode, since they would be reported as if the Transitional mode is active.

@westonruter westonruter added this to the v1.2 milestone May 14, 2019
@westonruter
Copy link
Member

Relates to #2202.

@westonruter westonruter added the P0 High priority label May 22, 2019
@westonruter westonruter self-assigned this May 22, 2019
@westonruter westonruter changed the title Reconsider showing validation errors in Reader mode Restore suppression of validation error warnings appearing in Reader mode Jun 8, 2019
@westonruter westonruter mentioned this issue Jun 8, 2019
7 tasks
@westonruter
Copy link
Member

westonruter commented Jun 9, 2019

When in Reader mode, and editing a non-Story post, the validation error warnings should not be displayed (at least for the time being). This was the behavior prior to adding stories, and it needs to be restored at least until the error messages are more user friendly; even more importantly, the warnings should not be displayed before the reader templates are sent through the post processor (#2202), since the validation errors would be coming from the theme template and not from the reader templates.

This is a restoration of #1132.

Testing Instructions

  1. Enable Reader mode.
  2. Add a Custom HTML block to a post, save, and a validation error warning should not appear.
  3. Add a Custom HTML block to a story, save, and a warning should appear.

Then:

  1. Enable Native (Standard) or Transitional mode.
  2. Add a Custom HTML block to a post, save, and a validation error warning should appear.
  3. Add a Custom HTML block to a story, save, and a warning should appear.

swissspidy pushed a commit that referenced this issue Jun 11, 2019
* Always allow switching from Transitional to Native on sites that are defined with `add_theme_support('amp', ['paired' => true])`. Fixes #2312.
* Restore suppression of validation error warnings appearing in Reader mode. Fixes #2311
* Add functionality for users to chose AMP + Stories, AMP-only, Stories-only. Fixes #2470
* Phase out “Native” terminology in favor of “AMP-first”. Fixes #2507.
@swissspidy swissspidy assigned csossi and unassigned westonruter Jun 11, 2019
@csossi
Copy link

csossi commented Jun 11, 2019

Verified in QA

@csossi csossi removed their assignment Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants