Merged
Conversation
It has known performance issues (more than 10x slower than cppcheck 1.9), so just get out early and don't run it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
aprotyas
reviewed
Jan 11, 2022
audrow
approved these changes
Jan 13, 2022
Contributor
audrow
left a comment
audrow
left a comment
There was a problem hiding this comment.
Looks good to me with green CI. I'm okay with the very specific environment variable.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
aprotyas
approved these changes
Jan 14, 2022
Contributor
aprotyas
left a comment
aprotyas
left a comment
There was a problem hiding this comment.
Small nit inline but approving regardless.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This was referenced Jan 25, 2023
MichaelOrlov
pushed a commit
to ros2/rosbag2
that referenced
this pull request
Jun 12, 2024
See ament/ament_lint#345 for details. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
pushed a commit
to ros2/rosbag2
that referenced
this pull request
Aug 9, 2024
See ament/ament_lint#345 for details. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
pushed a commit
to ros2/rosbag2
that referenced
this pull request
Aug 9, 2024
… to latest versions (#1709) * Use Ubuntu Noble distros for ci jobs on rolling Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Bump actions-ros-lint to version 0.1.3 and actions/checkout to v4 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Exclude cppcheck from CI due to known issue that it is very slow See ament/ament_lint#345 for details. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Bump mypy to version 1.9.0-4ubuntu1 to be aligned with Noble - Also add `--break-system-packages` to avoid error during pip uninstall Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Remove "sudo pip uninstall -y mypy" since it is not installed with pip Addressing the error message: Found existing installation: mypy 1.9.0 ERROR: Cannot uninstall mypy 1.9.0, RECORD file not found. Hint: The package was installed by debian. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Revert "Bump mypy to version 1.9.0-4ubuntu1 to be aligned with Noble" This reverts commit b5aa018 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Fixes for new mypy (Ubuntu 24.04) (#1763) * Apply new stubgen changes Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Update CI script and README.md Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> --------- Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Remove "--break-system-packages" flag from mypy install in README.md - Rationale: On Ubuntu 22.04 is an older version of the pip3 and python version which doesn't have this flag. - Also removed sudo before "pip3 install -U mypy==1.9" in README.md Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> Co-authored-by: Roman <rsokolkov@gmail.com>
mergify bot
pushed a commit
to ros2/rosbag2
that referenced
this pull request
Aug 9, 2024
… to latest versions (#1709) * Use Ubuntu Noble distros for ci jobs on rolling Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Bump actions-ros-lint to version 0.1.3 and actions/checkout to v4 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Exclude cppcheck from CI due to known issue that it is very slow See ament/ament_lint#345 for details. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Bump mypy to version 1.9.0-4ubuntu1 to be aligned with Noble - Also add `--break-system-packages` to avoid error during pip uninstall Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Remove "sudo pip uninstall -y mypy" since it is not installed with pip Addressing the error message: Found existing installation: mypy 1.9.0 ERROR: Cannot uninstall mypy 1.9.0, RECORD file not found. Hint: The package was installed by debian. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Revert "Bump mypy to version 1.9.0-4ubuntu1 to be aligned with Noble" This reverts commit b5aa018 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Fixes for new mypy (Ubuntu 24.04) (#1763) * Apply new stubgen changes Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Update CI script and README.md Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> --------- Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Remove "--break-system-packages" flag from mypy install in README.md - Rationale: On Ubuntu 22.04 is an older version of the pip3 and python version which doesn't have this flag. - Also removed sudo before "pip3 install -U mypy==1.9" in README.md Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> Co-authored-by: Roman <rsokolkov@gmail.com> (cherry picked from commit 27a6b60)
MichaelOrlov
pushed a commit
to ros2/rosbag2
that referenced
this pull request
Aug 9, 2024
… scripts to latest versions (backport #1709) (#1779) * Update CI scripts to use Ubuntu Noble distros and bump action scripts to latest versions (#1709) * Use Ubuntu Noble distros for ci jobs on rolling Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Bump actions-ros-lint to version 0.1.3 and actions/checkout to v4 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Exclude cppcheck from CI due to known issue that it is very slow See ament/ament_lint#345 for details. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Bump mypy to version 1.9.0-4ubuntu1 to be aligned with Noble - Also add `--break-system-packages` to avoid error during pip uninstall Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Remove "sudo pip uninstall -y mypy" since it is not installed with pip Addressing the error message: Found existing installation: mypy 1.9.0 ERROR: Cannot uninstall mypy 1.9.0, RECORD file not found. Hint: The package was installed by debian. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Revert "Bump mypy to version 1.9.0-4ubuntu1 to be aligned with Noble" This reverts commit b5aa018 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Fixes for new mypy (Ubuntu 24.04) (#1763) * Apply new stubgen changes Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Update CI script and README.md Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> --------- Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> * Remove "--break-system-packages" flag from mypy install in README.md - Rationale: On Ubuntu 22.04 is an older version of the pip3 and python version which doesn't have this flag. - Also removed sudo before "pip3 install -U mypy==1.9" in README.md Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com> Co-authored-by: Roman <rsokolkov@gmail.com> (cherry picked from commit 27a6b60) * Update github CI scripts to use jazzy instead of rolling Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has known performance issues (more than 10x slower than
cppcheck 1.9), so just get out early and don't run it.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org