Conversation
Previously, the version of cppcheck distributed in RHEL resulted in many (unactionable) linter failures only present on RHEL. Given the limited utility of running the linters on RHEL to begin with, we decided to simply skip the tests. Changes either to ament_cppcheck or the version of cppcheck distributed in RHEL now appear to allow these tests to run successfully, and the cost of maintaining this special case now outweigh the benefit. Reverts part of c0973c6.
It was most likely ament/ament_lint#345 ; cppcheck versions > 2.0 are ridiculously slow, so I ended up disabling them when we switched to Ubuntu 22.04. It looks like Almalinux 8 has cppcheck 2.4 and Almalinux 9 has cppcheck 2.9, so both of them are essentially "skipped" anyway. Anyway, since we are skipping this in code now, I'm happy to remove this bit from the CI scripts. |
|
So are we only running cppcheck tests on Humble then? Or I'd suppose Windows runs them? |
No, even on Humble it is disabled. I think we are only running them on Windows. In all honesty, we can probably drop |
delete-merged-branch
bot
deleted the
cottsay/drop-rhel-cppcheck-exclusion
branch
2 participants
Previously, the version of cppcheck distributed in RHEL resulted in many (unactionable) linter failures only present on RHEL. Given the limited utility of running the linters on RHEL to begin with, we decided to simply skip the tests.
Changes either to ament_cppcheck or the version of cppcheck distributed in RHEL now appear to allow these tests to run successfully, and the cost of maintaining this special case now outweigh the benefit.
Reverts part of #567
Rolling:
Iron:
Humble: