Skip to content

[jazzy] Update CI scripts to use Ubuntu Noble distros and bump action scripts to latest versions (backport #1709)#1779

Merged
MichaelOrlov merged 2 commits intojazzyfrom
mergify/bp/jazzy/pr-1709
Aug 9, 2024
Merged

[jazzy] Update CI scripts to use Ubuntu Noble distros and bump action scripts to latest versions (backport #1709)#1779
MichaelOrlov merged 2 commits intojazzyfrom
mergify/bp/jazzy/pr-1709

Conversation

@mergify
Copy link

@mergify mergify bot commented Aug 9, 2024

… to latest versions (#1709)

* Use Ubuntu Noble distros for ci jobs on rolling

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Bump actions-ros-lint to version 0.1.3 and actions/checkout to v4

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Exclude cppcheck from CI due to known issue that it is very slow

See ament/ament_lint#345 for details.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Bump mypy to version 1.9.0-4ubuntu1 to be aligned with Noble

- Also add `--break-system-packages` to avoid error during pip uninstall

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Remove "sudo pip uninstall -y mypy" since it is not installed with pip

Addressing the error message:
Found existing installation: mypy 1.9.0
ERROR: Cannot uninstall mypy 1.9.0, RECORD file not found. Hint:
The package was installed by debian.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Revert "Bump mypy to version 1.9.0-4ubuntu1 to be aligned with Noble"

This reverts commit b5aa018

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Fixes for new mypy (Ubuntu 24.04) (#1763)

* Apply new stubgen changes

Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com>

* Update CI script and README.md

Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com>

---------

Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com>

* Remove "--break-system-packages" flag from mypy install in README.md

- Rationale: On Ubuntu 22.04 is an older version of the pip3 and python
version which doesn't have this flag.
- Also removed sudo before "pip3 install -U mypy==1.9" in README.md

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: Roman Sokolkov <rsokolkov@gmail.com>
Co-authored-by: Roman <rsokolkov@gmail.com>
(cherry picked from commit 27a6b60)
@mergify mergify bot requested a review from a team as a code owner August 9, 2024 19:49
@mergify mergify bot requested review from gbiggs and jhdcs and removed request for a team August 9, 2024 19:49
@MichaelOrlov MichaelOrlov changed the title Update CI scripts to use Ubuntu Noble distros and bump action scripts to latest versions (backport #1709) [jazzy] Update CI scripts to use Ubuntu Noble distros and bump action scripts to latest versions (backport #1709) Aug 9, 2024
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov force-pushed the mergify/bp/jazzy/pr-1709 branch from 837e1cd to 5debb59 Compare August 9, 2024 20:59
@MichaelOrlov
Copy link
Contributor

The rosbag2_transport.RecordIntegrationTestFixture.can_record_again_after_stop is tend to be flaky.
Re-run Jpr job

@ros-pull-request-builder retest this please

@MichaelOrlov
Copy link
Contributor

The CI is green, merging without running CI on the build farm since changes only in git workflow, readme file and generated pyi files.

@MichaelOrlov MichaelOrlov merged commit ea10111 into jazzy Aug 9, 2024
@MichaelOrlov MichaelOrlov deleted the mergify/bp/jazzy/pr-1709 branch August 9, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants