Skip to content

Further update Granite to be compatible with Crystal 0.25 #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robacarp merged 7 commits into from
Jun 19, 2018
Merged

Further update Granite to be compatible with Crystal 0.25 #231

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d2a95a
Add string? to granite::base#new
robacarp Jun 16, 2018
7c8346e
update types and provide explicit overloads for initializer
robacarp Jun 18, 2018
a0c9f1c
Merge branch 'master' into granite_new_fix
robacarp Jun 18, 2018
a23fe89
Update mysql and sqlite:
robacarp Jun 18, 2018
78cf753
Implement Base#read_attribute to avoid depending on to_h for imports
robacarp Jun 18, 2018
e48f97f
Provide Base&initialize overloads for new JSON api
robacarp Jun 18, 2018
989bc23
Back out hacks added to make timestamps in sqlite work, no longer needed
robacarp Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/granite/base.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,15 @@ class Granite::Base
set_attributes(args.to_h)
end

def initialize(args : Hash(Symbol | String, String | JSON::Any))
def initialize(args : Hash(Symbol | String, String?))
set_attributes(args)
end

def initialize(args : Hash(Symbol | String, Granite::Fields::Type))

@eliasjpr eliasjpr Jun 18, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

set_attributes(args)
end

def initialize(args : Hash(Symbol | String, JSON::Any))
set_attributes(args)
end

Expand Down