Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panorama alignment with a reference camera #1334

Merged
merged 6 commits into from
Feb 21, 2023
Merged

Conversation

servantftechnicolor
Copy link
Contributor

@servantftechnicolor servantftechnicolor commented Jan 17, 2023

User can align the panorama horizontally with a target view. Need to select auto_from_cameras_x_axis in sfmTransform.

Copy link
Member

@fabiencastan fabiencastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 fixes needed

@fabiencastan fabiencastan added this to the 3.0.0 milestone Feb 14, 2023
@fabiencastan fabiencastan marked this pull request as draft February 14, 2023 18:56
@fabiencastan fabiencastan marked this pull request as ready for review February 17, 2023 11:51
Copy link
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Linux with alicevision/Meshroom#1876 on both pinhole and fisheye panoramas, with and without HDR.

For all the used datasets, the PR worked as intended (a rebase was needed, though).

@fabiencastan fabiencastan merged commit 03e6a7d into develop Feb 21, 2023
@fabiencastan fabiencastan deleted the dev/panoramaAlign branch February 21, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants