-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentinel-apache-dubbo-adapter not compatible dubbo 2.7.5 #1296
Conversation
The CI indicates test failure. Could you please resolve it? |
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
============================================
- Coverage 42.8% 42.71% -0.09%
+ Complexity 1606 1602 -4
============================================
Files 344 344
Lines 10182 10186 +4
Branches 1380 1380
============================================
- Hits 4358 4351 -7
- Misses 5281 5290 +9
- Partials 543 545 +2
Continue to review full report at Codecov.
|
OKay, Please review again |
Nice. Have you tested the backward compatibility for Dubbo 2.7.5-? |
The version of 2.7.3 , I tested, compatibility and passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing! |
ListenableFilter was deperated in dubbo 2.7.6 and onMessage method is renamed back to onResponse according to 2.7.6-release-note and Filter refactor, keep all callback methods inside Filter.Listener #5731 |
resolve #1231
resolve #1292