sentinel-apache-dubbo-adapter dubbo2.7.5 ERROR

[bxvs888]

Issue Description

Type: bug report or feature request

Describe what happened (or what feature you want)

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?

没有实现dubbo 2.7.5 onmessage方法。

[sczyh30]

It's due to the bad compatibility of Dubbo 2.7.x. In Dubbo 2.7.2-2.7.4, the Listener interface is:

https://github.com/apache/dubbo/blob/1d7e8fac4523d7482d5f2d8f25dd024807e3d3d5/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/Filter.java#L63-L68

While in 2.7.5, the onResponse method was renamed to onMessage:

https://github.com/apache/dubbo/blob/3b5dc6e53b04d313611ed907c0ba270f6ff06444/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/Filter.java#L63-L68

We might need to handle this in the next version.

[sczyh30]

@CodingSinger Any good suggestions?

[zhaoyuguang]

一个简单的临时建议
Override只是源码注解 如果方法声明与父类那一样会重写
是否可以把改为实现改成

    static class SentinelDubboListener implements Listener {

        public void onResponse(Result appResponse, Invoker<?> invoker, Invocation invocation) {
            onSuccess(appResponse, invoker);
        }

        public void onMessage(Result appResponse, Invoker<?> invoker, Invocation invocation) {
            onSuccess(appResponse, invoker);
        }

        private void onSuccess(Result appResponse, Invoker<?> invoker) {
            if (DubboConfig.getDubboBizExceptionTraceEnabled()) {
                traceAndExit(appResponse.getException(), invoker.getUrl());
            } else {
                traceAndExit(null, invoker.getUrl());
            }
        }

        @Override
        public void onError(Throwable t, Invoker<?> invoker, Invocation invocation) {
            traceAndExit(t, invoker.getUrl());
        }
    }

另一个是：看起来dubbo官方推荐实现org.apache.dubbo.rpc.Filter.Listener

[jasonjoo2010]

I don't know why 2.7.5 has so many compatibility issues and we all know a declaration should not be removed without several versions' deprecation especially for interface.

My suggestion is that just ignore it because of apache/dubbo#5639

[sczyh30]

Though Dubbo is fixing the compatibility in later versions, we may need to adapt to the 2.7.5. #1231 (comment) seems like a good idea for a temporary fix.

[zhaoyuguang]

Though Dubbo is fixing the compatibility in later versions, we may need to adapt to the 2.7.5. #1231 (comment) seems like a good idea for a temporary fix.

Okay, 我来修复下