Skip to content

Filter refactor, keep all callback methods inside Filter.Listener #5731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2020

Conversation

chickenlj
Copy link
Contributor

related: #5639 #5623

@codecov-io
Copy link

Codecov Report

Merging #5731 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5731      +/-   ##
============================================
- Coverage     61.43%   61.31%   -0.13%     
  Complexity      497      497              
============================================
  Files           932      927       -5     
  Lines         38098    37944     -154     
  Branches       5500     5480      -20     
============================================
- Hits          23405    23264     -141     
- Misses        12149    12150       +1     
+ Partials       2544     2530      -14
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/rpc/ListenableFilter.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rg/apache/dubbo/monitor/support/MonitorFilter.java 67.34% <100%> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/dubbo/rpc/filter/TimeoutFilter.java 58.33% <100%> (ø) 0 <0> (ø) ⬇️
...ache/dubbo/rpc/protocol/ProtocolFilterWrapper.java 68.51% <100%> (-1.13%) 0 <0> (ø)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 87.23% <100%> (ø) 0 <0> (ø) ⬇️
.../org/apache/dubbo/rpc/filter/CompatibleFilter.java 54.54% <100%> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 43.47% <100%> (ø) 0 <0> (ø) ⬇️
.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java 17.7% <100%> (ø) 0 <0> (ø) ⬇️
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 65.21% <100%> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/dubbo/rpc/filter/ContextFilter.java 93.18% <100%> (ø) 0 <0> (ø) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e72bf...b4a8977. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants