Remove redundant return in agreement/actions.go.#8
Closed
derbear wants to merge 1 commit intoalgorand:masterfrom
Closed
Remove redundant return in agreement/actions.go.#8derbear wants to merge 1 commit intoalgorand:masterfrom
derbear wants to merge 1 commit intoalgorand:masterfrom
Conversation
Contributor
Author
|
Closing for now. |
Karmastic
pushed a commit
that referenced
this pull request
Jun 12, 2019
* fix rpm bulid by passing env vars into it * commit bulidnumber.dat so that we have a clean checkout and precise hash to compile in * https and gpg key
derbear
pushed a commit
to derbear/go-algorand
that referenced
this pull request
Sep 27, 2019
Add txn SenderBalance to Teal
pzbitskiy
pushed a commit
to pzbitskiy/go-algorand
that referenced
this pull request
Mar 12, 2020
Implement app_write_local
bricerisingalgorand
referenced
this pull request
in bricerisingalgorand/go-algorand
Jun 25, 2020
Eric/use mule in jenkins
algonautshant
added a commit
that referenced
this pull request
Oct 13, 2021
commit 45374907a555ff57bbc0fa2f66ae8642f38fe514
Merge: 9f274c57 83bcaaa8
Author: algoidan <idan@algorand.com>
Date: Wed Oct 13 14:09:41 2021 +0300
Merge remote-tracking branch 'origin/master' into feature/dilithium-scheme-integration
commit 9f274c570ec75288d967ddf5f33bba75448d1166
Author: algoidan <f>
Date: Wed Oct 13 13:34:40 2021 +0300
fix txnsyc cert encoding bug
commit 919bdd2f8c3dd7eaa60124af15fa509b49b60856
Merge: 8aff58df a5165444
Author: algoidan <idan@algorand.com>
Date: Tue Oct 12 14:52:45 2021 +0300
Merge remote-tracking branch 'origin/master' into feature/dilithium-scheme-integration
commit 8aff58dfea5604edfec4b79b78413cbcadc28a39
Merge: 04dd9169 0d5b66ee
Author: algoidan <f>
Date: Sun Oct 10 18:28:23 2021 +0300
merge with txsync
commit 04dd9169bc000278ddc6c715e7fef86e1f508b57
Merge: 1ef5c6b2 926d7261
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Mon Oct 4 15:47:49 2021 +0300
Merge pull request #2991 from algoidan/feature/dilithium-scheme-integration
fixing comments and add PartitionTest
commit 926d7261ddab7299fed2a0adf09728db9d83355b
Author: algoidan <f>
Date: Mon Oct 4 14:08:22 2021 +0300
fix fmt problems.
commit 338873f0a66e0968826f03fbd604a2fd5c737ed3
Author: algoidan <idan@algorand.com>
Date: Mon Oct 4 13:47:57 2021 +0300
adding sync tests
commit 6ef20ce1fabc889a769b353ab954c19a79cf2ef2
Author: algoidan <idan@algorand.com>
Date: Mon Oct 4 12:23:07 2021 +0300
fixing comments and add PartitionTest
commit 1ef5c6b2addb05b01eab675a52f33db0e63f57f9
Merge: a9124a9e cfb49e66
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Sun Oct 3 16:09:54 2021 +0300
Merge pull request #2987 from algoidan/feature/dilithium-scheme-integration
Feature/dilithium scheme integration
commit cfb49e669b897381aae00aadb4721496f01a9a37
Author: algoidan <f>
Date: Sun Oct 3 13:44:38 2021 +0300
go mod fix
commit d70240486f888f377615a8f31c639a2ca594d4ea
Merge: a9124a9e f17f73ef
Author: algoidan <f>
Date: Sun Oct 3 13:13:41 2021 +0300
merge with master
commit a9124a9e8bedd6e41fd2bfe5b77aa5bd6fcce94f
Merge: aa635dad 66c5f41c
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Wed Sep 29 17:05:57 2021 +0300
Merge pull request #2946 from algonathan/e2e-no-stateproof-tests
E2E PR for new stateProof keys
commit 66c5f41c0ee04e764b7023ce7960f7f513645b63
Author: algoidan <idan@algorand.com>
Date: Wed Sep 29 14:22:17 2021 +0300
remove the long test.
commit aa635daddf34997a6b88fc2abfa32609e2eabaf6
Merge: 1f92b43b bbf2cf23
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Wed Sep 29 14:51:29 2021 +0300
Merge pull request #2888 from algonathan/benchmark-addition
added benchmark to participation. refactored fillDB benchmark too.
commit bbf2cf23a64f02782e1d5c982f401f4cd125e934
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Sep 29 13:36:52 2021 +0300
fix for review
commit a7b3208fda183d42e1f12b77d3eae783b292f199
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Sep 29 11:58:47 2021 +0300
removed test
commit 54f9352689433993422e1c98d6a545936c6ce7b4
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Sep 29 11:37:04 2021 +0300
changed todo
commit a2270abd8b55d25f10e947b013af9b2a38103f0b
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Sep 29 11:29:41 2021 +0300
added partitionTest to each test
commit cb1c6953782dbf8726033be658d5cc3cb959bb43
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sat Sep 25 14:43:47 2021 +0300
added a scenario that makes certain compact cert are being made after concensus upgrade
commit 4d6785a34a0e516c846fde365defbf8999bfea9d
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sat Sep 25 11:15:27 2021 +0300
added large participation key registration
commit 1188d66da2688e041bd365169fcf55408f726d03
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Fri Sep 24 17:09:29 2021 +0300
changed comments
commit eababac676738cbf268543fadb3f884819435856
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Fri Sep 24 16:53:17 2021 +0300
added test for participating after concensus upgrade
commit 232dd53f5640f733328361d2d07cbe6c4fb6fbd5
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Fri Sep 24 15:58:19 2021 +0300
refactored func signature to not pass fields of Fixture object
commit 2398a7f21e6ebf3bae1ef4e7305333c3de79951c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Sep 23 17:54:13 2021 +0300
added a test that inspects old keys can be made up to the version upgrade, and
that after ver upgrade new participation keys with stateproof keys can be made
commit ca66c85e3842aa0bd71e9d4c7c82fbddc5c6c402
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Sep 23 15:46:19 2021 +0300
refactored the way testing for upgrade and sending txns work
and added a test for v29
commit a647428bdf3e842cafcac10128b437fd2beeb655
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Sep 23 15:51:04 2021 +0300
concensus can keep on sending money after reaching version future from version V29
commit 3541bcae67f088d743c336ecc777fef4d109a4ee
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Tue Sep 14 18:15:30 2021 +0300
added benchmark to participation. refactored fillDB benchmark too.
commit 1f92b43b67160a7876604fe828b9b71ae76d1f92
Merge: 0665fe16 265cb5c9
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Sun Sep 12 14:42:42 2021 +0300
Merge pull request #2874 from algoidan/feature/dilithium-scheme-integration
update dilithium scheme integration branch with master
commit 265cb5c9b8222ac85444cc0afa664e6a03683455
Author: algoidan <f>
Date: Sun Sep 12 13:33:41 2021 +0300
reduce the default number of rounds
commit 7ac171b2e9ce231702b88e3baf52a4f825b03438
Merge: 0665fe16 b8b7281d
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Sun Sep 12 10:31:59 2021 +0300
Merge pull request #9 from algoidan/master
merge with master
commit 0665fe16780e36dca0ac6eb9e1da497fef0cdd8f
Merge: 177b067f 5c5cd067
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Sun Sep 12 10:08:32 2021 +0300
Merge pull request #2867 from algoidan/use-stateproof-in-compact-certificate
fix layer bug.
commit 5c5cd067f8e7c27424ae96e04731073c032dbf35
Author: algoidan <f>
Date: Fri Sep 10 21:18:21 2021 +0300
using copy instead of append
commit 69c2d78b61e66840ce6cad5aae6218657e59eb2c
Author: algoidan <f>
Date: Fri Sep 10 12:26:07 2021 +0300
fix layer bug.
commit 177b067fd4b4c0c7aae55b949fc1c495f8701045
Merge: ba8b5c45 58125ae8
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Thu Sep 9 15:12:26 2021 +0300
Merge pull request #2845 from algoidan/use-stateproof-in-compact-certificate
Compact certificate code now uses the state proof.
commit 58125ae89d0f282edf432e55cbf868955b1b758b
Author: algoidan <f>
Date: Thu Sep 9 12:25:07 2021 +0300
CR fix
commit f861f041d8e695fd2f201b0b29a2d6829d433424
Author: algoidan <f>
Date: Mon Sep 6 16:35:05 2021 +0300
the compact certificate code now uses the state proof.
commit ba8b5c45296d60b7bd618a86d4846c87a41526fd
Merge: 7f18e4b3 4c05db06
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Sun Sep 5 19:38:50 2021 +0300
Merge pull request #2843 from algoidan/feature/dilithium-scheme-integration
updateFeature/dilithium scheme integration with master changes
commit 4c05db066ea3504d451ec98fd63f134c83e68c77
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Sep 5 17:15:13 2021 +0300
fix: codegen_verification
commit 12d3da1f7dfcd6e5c6c6e2b2f4995728b03f0328
Merge: 7f18e4b3 f8169d29
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Sun Sep 5 14:14:32 2021 +0300
Merge pull request #8 from algoidan/master
update the dilithium
commit 7f18e4b3366110452494c94246835470ba5cf146
Author: Jonathan Weiss <85506383+algonathan@users.noreply.github.com>
Date: Sun Sep 5 11:58:46 2021 +0300
Compcert sumhash integration (#2816)
* comp-cert to use genericDigest, and sumhash
* fix: compactcertState had nil digest
* fix: daemon v1/handlers to use compactCertVoters as a generic digest
* using genericDigest instead of Digest in block's CompactCertState
* added magic num to crypto/compactcert
* changed ledger/voters to use the same hash in the tree build as expected in compactcert
* fix: using the size of the compactcert hash output instead of crypto.Digest
* fix: changing comments
* defined hash factory for the compactcerts
* fix: using hashsize in compactcert/worker_test
* removed TODO comment
* renamed SumHash into GenericHashObject
* removed unused function
* fix: using compacert.Hashsize in e2e test
* put matrix of sumhash creation inside init of crypto/hashes
in addition to that, i've updated it to the newest copy of the correct implemantation
* fix: using library number size for sha512_256ssize
* removing commitment type from crypto/compcert
* removed: newhashFactory from compcert
* move compcerts constants into a specific file
* changing the verification interface
* fix CR
* revert merklekeysotre to use ed25519 scheme for now
* contine the revert to ed25519 and sha512_256
* fixing the broken txn proof
* exporting the helper struct that validates transcation proof
* removed unused struct from unit-test in bookkeeping
Co-authored-by: algoidan <f>
commit 71dcb0f9a22bde38c2808615fccf2da1909dd06c
Author: Jonathan Weiss <85506383+algonathan@users.noreply.github.com>
Date: Wed Aug 25 21:02:38 2021 +0300
Subsetsum (#2786)
* msgpack updated
* using defer instead of goto
* added a hash factory
* wip: using hash factories inside merklearraytree
* removed code dup
* tree uses factory to use hash inside the tree
* fix: msgpack
* upWorkers now use hash from factory
* adding merklearray digest and returning root as TreeDigest
* WIP: using TreeDigest inside merklearray
* minor support for proof structs
* merklearray proof structs
* refactor: verify broken into sub functions, fixed issue with empty proof struct
* Verify expects merklearray.Digest instead of crypto.Digest inside verify function
* adjusted merkle keystore to work with the new merklearraytree api
* Adjusted crypto/compactcert to use merklearrayTree new API
* ledger, data, compactcert comply with the new merklearray api
* fix: daemon/algod/server handlers to work with the merklearray proof
* WIP: adding subset hash into merklearray and merklekeystore
* testing merklearraytree with another hash type
* fix: shouldn't have remove dtag from struct
* fix: unit test adjustment in e2e
* added unit tests to crypto.hashfactory
* fix: using crypto.HashSum in merklearray.tree
* reusing hashing code in merklearray
* exporting crypto/util.go's hashRep
* fix comment in merklearray/array.go
* fix: comment in merklearray signer
* fix: using hashSum instead of manually calculating the hash
* removed wrapper for waitgroup.done
* removed merklearray/pair.Hash()
* refactor: merklearray Verify function
* refactored the layer building of merklearray
* reseting hash before usage
* using const as magic number for digest size in merklekeystore
* fix: proof for nothing should include the correct hashFactory of the tree too
* added unit test for merklearray prove structure
* moved merklearray.Digest -> crypto.GenericDigest
* pass sanity checks
* removed digest interface, changed to work with genericDigest type
* fix: bug in verifying merklearray
* added unit test for empty merklearray tree
* removed unneeded hash reset
* fix: typo in file name: crypto/digest.go
* fix: reorder struct
* renamed the subsetsumhash const. fixed keystore size to the size of the subsetsumhash
commit bd11c41c7b4722c8bac8cc4732c287225090f834
Author: algoidan <f>
Date: Thu Aug 19 12:39:13 2021 +0300
fixing partitiontest in msgpack tests
commit de5304678fda51129650b327866e208ae4185c55
Merge: c6560bf5 e7788529
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Wed Aug 18 16:18:35 2021 +0300
Merge pull request #2765 from algoidan/feature/dilithium-scheme-integration
Feature/dilithium scheme integration
commit e778852913b26f7e16f3788560c1f484cd06d085
Author: algoidan <f>
Date: Wed Aug 18 14:34:35 2021 +0300
fixing msgp pack test
commit 032684333ed570d0e131143e082e034991f1a766
Merge: c6560bf5 f774e7e8
Author: algoidan <f>
Date: Wed Aug 18 12:54:30 2021 +0300
merge with master
commit c6560bf5c57cdba0a7e517f2ca3a767b4c27bdad
Merge: b327bac6 04a4a53e
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Wed Aug 11 18:50:29 2021 +0300
Merge pull request #2678 from algonathan/dil-sigs
Dil sigs
commit 04a4a53e2e332aeb5af71a53296d1db258593a0c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 11 17:10:04 2021 +0300
added test for dilithium hashable
commit ca217d679cf630ec2573a0b83910a3709c637137
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 11 15:29:58 2021 +0300
upgraded go-mod version of the algorand/dilithium fork
commit af30fe43668106262e4c0312276e5106dfd46b2d
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 11 13:59:01 2021 +0300
increased interval
commit 36a2d3ef245d71761efac280898ae890b5a4a1f3
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 11 11:43:11 2021 +0300
moved cdilithium wrapper to a different fork
commit 095631fce3e9ca3717a94f88134b274256979e26
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 11 08:23:17 2021 +0300
compiling withoung rnadomised sig flag
commit c46bd8f7d949dd8474691c3ee1865d2f3ccefbf2
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 11 08:22:29 2021 +0300
cannot have empty signature
commit 8d2e9bf5b0d6f74de449c861bd6358e844a4f46a
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 11 08:17:06 2021 +0300
changing the codec name of dilithium public key
commit 6110c7244fa13955d5c65bea3796d81d7a31cdae
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Aug 9 12:16:32 2021 +0300
added constant values
commit 38c5f51dfb44f27a2da323a6122396582df2985f
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Aug 9 11:51:56 2021 +0300
changed functions used from api.h
commit 4229124dd348bc0dd37c6d6d4a22162631b797b1
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Aug 9 10:21:01 2021 +0300
rearanging cdilithium directories, cdillithium to use dil3, and randomized signing
commit 3b7ae947986b6f8478be136989a548c42d9398f8
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Aug 9 09:15:59 2021 +0300
fix: typos in dilithium.go comments
commit 7db6a9d603b6f667ab6e4df81a32ebe28472f1fa
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Aug 9 09:14:32 2021 +0300
added unit test to crypto/dilithium
commit 234694aba05e9be215c98e3f305da14fbb0e5744
Merge: a953718c b327bac6
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 8 08:04:41 2021 +0300
merged from feature/dilithium-schem-integration
commit b327bac6d93b353c60f47b6a0dd684168f2e39a6
Merge: 630acdb1 39be0c77
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 8 08:02:11 2021 +0300
merged from main branch
commit 630acdb1c9ebe16681c8b994e1f18e94298d00c9
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Aug 5 18:32:33 2021 +0300
merged from main branch
commit a953718c295aae4b62614886fe9d2a4360b2ffda
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Aug 5 14:36:22 2021 +0300
check for arm64 integration tests
commit 78e73a35e209ed9cb95e57f315c83cbc0ac6c8f3
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Aug 5 11:25:32 2021 +0300
fix lint checks
commit 15d537d034ee2fb32c2116e9040071d21376b6f6
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Aug 5 11:00:49 2021 +0300
renamed dilithium library
commit 9721ab36efc26e13bd65780852c38185d1c7dd8e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Aug 5 10:12:52 2021 +0300
new participation key will use keydilution as compactcertround parameter when it is unspecified
commit 0181b530b8c9935e6b2e9a74b17bbe95fdcee01e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 4 19:50:06 2021 +0300
fix: go fmt
commit e338300c600012f2268b25cc8eceb3019c75e87f
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 4 19:30:16 2021 +0300
WIP: dilithium cgo, -o3 flag. still needs some configurations
commit 1f7518dbe073a5bebf1eaef8dc1c9f306c182ae7
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 4 14:46:35 2021 +0300
participation key creation will use concensus params to determine the compactcertRounds
commit 874cb97c935d30177d9b1f567ed9578902c027c1
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 4 10:47:05 2021 +0300
placeholder key turned into dilithium key
commit 29da4833b61cba3147ff4eafe689f18926e19d74
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Aug 4 09:33:44 2021 +0300
squashed changes from master
commit f647d09f72b7bf32575038c46dabbc70fe99746c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Aug 2 15:13:18 2021 +0300
dillithiumkey basic integration:
added key to the crypto library, made certain it supports signer interface.
integrated it into the merklekeystore
fix sanity-checks
commit 9997eef55d77f60af4b1cf983a514b92d7f299b0
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Aug 2 07:46:17 2021 +0300
fix:msggen
commit 396037d003263839a8ad40eb5355a5caf85b8de3
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Aug 2 07:15:47 2021 +0300
removing valid testing for signatureAlgos
commit 407f46263e6063ebf4b6985a709035ae8f0201e8
Merge: fdc2ed2d 4239dbe8
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Sun Aug 1 19:06:23 2021 +0300
Merge pull request #2620 from algonathan/merklekeys-partkey-integration
merkle-part-key-integration
commit 4239dbe87299e21dc3b0bbc60531bdb6304713c6
Merge: ac16412e fdc2ed2d
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 17:29:35 2021 +0300
Merge branch 'feature/dilithium-scheme-integration' into merklekeys-partkey-integration
commit ac16412e81eeb408b8a42ad87666b92a83606ae8
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 17:19:02 2021 +0300
concluded TODO in participation/account is not needed anymore
commit e6a78e3a913be13f78bba9293fac75c47b81c80e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 16:52:05 2021 +0300
Squashed Review commits, all messages are present below:
removed unused field from signature
fix: comment of HasValidRoot
removed unused function
fix: firstValid = 1 instead of firstvalid++
fix: removed uint test from wrong Test suite
added tests for signer creation with round zero
fix: removed unneeded unit-test
fix: error in unit test with bad merkle proof inside signature
added case to unit test of signer creation
added test case to trim:wq
commit 575b1708ded85a75b9069608f4f7571d38c258a8
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 16:49:48 2021 +0300
fix: fmt
commit fdc2ed2da5f0f86c466136a8ed3b5eea35043c29
Merge: a33bde62 8835bfdd
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 15:31:14 2021 +0300
Merge branch 'master' into feature/dilithium-scheme-integration
commit d1554d316786590fb72d4685fb128d966a22d43f
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 14:31:38 2021 +0300
added a way to dicern empty verifier from verifier that is tied to a signer
commit 73da6496a1d5461d5bbeb9625946d52f4fe17f6c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 13:02:10 2021 +0300
added unit tests
commit 0ebf6e40dba5e1489bda06e5d8fe0f1a4a61b25b
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 12:45:33 2021 +0300
fix: bug in new signer - overflow in roundToIndex, fixed by explicit writing the formula
commit 0c0b30eac60184705257e37a384a4ea303334fad
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 12:25:06 2021 +0300
fix: renamed functionality to get indices and rounds
commit 7e5e37725c99b4df00fdb1d607862ea70c6ffc0e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 11:18:07 2021 +0300
fix: changed receiver name to match signer first initial
commit 6cc73e29a590390f087a54fcce3154ed806deee2
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 11:16:26 2021 +0300
removed unneeded structure (EphemeralKeys) and merged into signer
commit c22ae9f43034dc3743661fbfbaaf155909a36c9b
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 11:03:57 2021 +0300
renamed firstValid
commit 82df1bd4b37f18952725816941d31db3891362af
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 11:02:32 2021 +0300
reverted one commit back
commit 8003b4b278b528292354b96697fbe8e92adf3db8
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 10:02:49 2021 +0300
fix: added Status to verifier
commit 867f775653d43ffd46ff69af9130cbe8b1ea521d
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 07:52:58 2021 +0300
fix: using round instead of indexToRound in verify func
commit cb948372c4e967f749c1310c3b1cba7a8082f400
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 07:50:13 2021 +0300
explicit init for ArrayBase
commit 4aa8766db99089ee3d0c0f97bfbf2c1cad69049c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 07:48:35 2021 +0300
removed unused code
commit 2ada1a8d0582eefd4392c2bae9709cc873c147db
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 07:47:55 2021 +0300
renamed field divisor to interval in merklekeystore.New function
commit d0f3014213e0d7e21adf32f8fd4f97dd86abeef4
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 07:45:40 2021 +0300
fix: removed unused function numkeys, changed names of params
from the roundToindex and IndexToRound
commit 2924e7fce27b78d2d6e5be9e9763b3dc454d8c22
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 07:44:08 2021 +0300
removed commented out code
commit 1c2244ce308a1d8192742e02bde3ea8dc63b34f0
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Aug 1 07:43:16 2021 +0300
changed codec name, and removed unused field from verifier
commit 569718c4536ae885d39102a2f13f22cb62c4ee90
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 29 14:46:06 2021 +0300
trim is set to work with specific keys only
commit 374b584efba0ae61c95c27bc77a4521f6d70b3d7
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 29 11:47:54 2021 +0300
renaming merklekeystore bases
commit cf28b369cd4e3a27c3896fccfc9763ade2d8e42a
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 29 10:59:25 2021 +0300
renamed divisor into interval
commit cbd5241520a98c8622463d45b7b08acb305da15d
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 29 07:27:23 2021 +0300
WIP: fixing trim
commit 6ae373cb025f8e24639d85ec8cdc6611b9086575
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 19:40:05 2021 +0300
added test for divisor >1 in deletion tests
commit d1e330e619241b17bd8ee2bbe3e2524d555d2bea
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 19:24:55 2021 +0300
ensuring no verification for round zero
commit f558a6b81e57be71d7fb13ef4f8bb38a9a50bcbd
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 19:21:34 2021 +0300
fix: forgot to copy merklekeystore.signer originRound
commit bda45988f958b8a6bd38d9a69bc61353f394188f
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 19:16:58 2021 +0300
fix code panic on 0 divisor
commit 67024ffc71bdd1a5ef45f06fa3992dbda4635cbb
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 19:02:52 2021 +0300
fix: signature and verification align with key spaces
commit 4336371f2330d876a869d98a25c84ede9456ee79
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 16:25:48 2021 +0300
fix: bug in libgoal/participation - did not check errors
commit 5be3594377ccd5d3467e6844abe4b00f191fb808
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 16:25:22 2021 +0300
fix: merklekeystore signer will not return invalid verifier
commit 501648dd8adccda1802e33fd69741299a1be0c3b
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 13:49:13 2021 +0300
decided not to support zero key, because it doesn't make sense
commit c05998892c77559f8b85f6ca11fcc3825a8b1fb1
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 11:40:44 2021 +0300
fix: sanity checks
commit bf94257474a686b08a99f68d058a5cf8f1ee60bd
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 11:25:48 2021 +0300
WIP: dividing key rounds in merklekeystore
commit 2e8e44f7f3d5538b0f296cf1a783d3f81f9525f3
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 09:54:16 2021 +0300
fix: removed bad comments
commit 874881a7eb90b4d8fa65b9090e3a7f52b5c92191
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 07:59:26 2021 +0300
fix: removed errors from Trim
commit dbd3b5977a58029b11151b6b5612eb735f1063a9
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 07:22:03 2021 +0300
fix: comment in participation struct
commit 3c44410d3fd0f7ecc37c95bd4e381cd7b8f33d12
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 07:20:07 2021 +0300
fix: import conventions
commit 02722f6a7122990ab820cd4b54afdf78cc63b4d7
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 28 07:18:17 2021 +0300
fix: using error.new instead of fmt.Errorf when possible
commit ffadbb81a1fee12baa357fc5794ab456ab35408e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 25 18:45:45 2021 +0300
fix: bad comment over Trim function
commit 8804d9a4bb420d25cbb6ee9b77a341b1374a62a2
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 25 18:39:42 2021 +0300
fix: comparision of merklekeystore.Signer inside tests
commit fca0f8df0238aae1c0c019bf81f03fcd26295f28
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 25 16:59:51 2021 +0300
removed test for valid blockproofPK - no such check for new type of key
commit 0e426672c69fd12b97809e88d6f31178aaa91a42
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 25 16:53:37 2021 +0300
added comments in merkle key store to fields in EphemeralKeys,Signer
commit 2a3fc455d3b4566f84a257f38fbbbc3b31286071
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 25 16:15:30 2021 +0300
added a trimming function to the merklekeystore.
commit cc85c8460a4c900c509172f2234729d94a0bb218
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 25 12:22:17 2021 +0300
removed unneeded firstRound param from signer
commit 1294ab9e344e4f3f11f03caa2aa7e8c5b3d5c422
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 22 17:37:35 2021 +0300
removed some spaces
commit bd36afe97be4bb2d25def994015c4a763a99a69c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 22 12:30:49 2021 +0300
fix: comment for EphemralKeys in merklekeystore
commit a33bde627200d28bfa551f41c9b61dbcc307def5
Merge: fa1a50ab 9bcee442
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 22 16:15:21 2021 +0300
Merge branch 'master' into feature/dilithium-scheme-integration
commit fa1a50ab2d2145c52f05e16969ab03d316485520
Merge: 752ab75d 97453b2f
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Thu Jul 22 15:38:43 2021 +0300
Merge pull request #2579 from algonathan/merklekeystore
Merklekeystore
commit 97453b2f28533305a95899742c16a64eccb3a1a7
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 22 14:43:31 2021 +0300
fix: bug in unit test
made comparision between pointer and struct
commit 343b2c3df2ba6e57278625cf04897fcad1238ca0
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 22 12:30:49 2021 +0300
fix: comment for EphemralKeys in merklekeystore
commit 3b4bd4a2dd35247578ce5af2d9fabbb918f7a55c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 22 10:23:05 2021 +0300
changed signature test in merklekeystore
commit 440760b8f881db963b01dd627583e1a8421dc479
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 22 10:13:16 2021 +0300
fix: msgpack for merklekeystore.Verifier
commit 59fdb5e198221f194c297ffee84b44d1c51e2f16
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 22 09:01:01 2021 +0300
changed name of ephemralpk
commit e0c0d1b051742186aa126d1f3cb97dc266384c40
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 21 17:45:26 2021 +0300
removed unused variable
commit 538b06b0c5897da2b1505282ab6f73a3f4bda88e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 21 17:08:50 2021 +0300
fix: import style convention
commit e29330fc61032565dbede57d2e363899c3c0f1bb
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 21 17:02:16 2021 +0300
fix: lexicographic order
commit 8db9ebccc87e6d58650ae9f23bebe0fda14ae893
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 21 16:55:07 2021 +0300
api change
commit f9327e085dd0ce59d65b031bb3c8258f5ce4964b
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 21 12:25:01 2021 +0300
fix: 'make sanity'
commit 45863aaac582912ffe351e9082d5d429ab1438f3
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 21 12:15:55 2021 +0300
extended unit tests
commit f9ad9421bde21754bb3929d200d06429892c36ac
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 21 11:29:03 2021 +0300
added const to EphemeralPublicKey ToBeHashed
commit 7142dcd0cf314d4ae6130a1e8a7279eb7a8d0e6e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 21 11:02:22 2021 +0300
WIP: adding round commitment to the merklekeystore keys
commit 6d30b99974a749b6afbf843e5759c0c887ed9516
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 21 09:21:27 2021 +0300
changed hashing function name for ephemeral keys
commit 9e87fb3bfbc9ee6fb1b59e745c5b1753e3c48cec
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 17:06:59 2021 +0300
changed the merklekeystore to not rely on basics package
commit 56cc5443e9158e2424f6777907d2e372e5bde628
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 16:12:44 2021 +0300
fix: test should've changed to inspect edge cases of getKeyPosition
commit 965285c68428b6a0fc60b3be61f73c96456df4b8
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 16:11:12 2021 +0300
added test case that ensures a single key is created with firstround=lastround
commit 60f69dad7335b3024f5c31534a38da41e4f5cbaf
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 16:09:49 2021 +0300
shortend codec name
commit d1fd32c02714737b421425a655cc0f55d087e6ad
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 16:05:43 2021 +0300
fix: removed test from within a test
commit 631d245a307969f205f391423ea38568d24e6124
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 14:43:17 2021 +0300
fix: pass make sanity
commit ac942cbaf921d192ce239f4a8039604a5812c479
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 14:42:55 2021 +0300
fix:removed unneeded param from New
commit 7249dff4d7153c1069cfc2f91101fe776e04643b
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 13:33:28 2021 +0300
refactor: changed types inside new function.
commit 3c734ecdc38d2a430d7dc6d4b8bec6a02367ba35
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 13:24:02 2021 +0300
fix: support creation of keys for all rounds
commit 30dfd7e18c1c49747edc80c0daf26baeea44eb50
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 10:08:56 2021 +0300
msgpack support for merklekeystore
commit 44fdb60a35a9c5f691f9f1ca9cead9d1b09477f8
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 08:38:01 2021 +0300
fix: added a test case to ensure signer always contains at least one key
commit 3562ad482876d464d766a1c0d963de7530764d12
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 08:32:52 2021 +0300
removed t.run() from tests
commit ae182b7ec731487c880eb86e0a2c1573d414128e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 08:26:41 2021 +0300
merklekeystore.signer expects key type to be provided
commit 4599f09d928707c5f20347aec05c663bb73338e5
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 08:22:59 2021 +0300
removed unneeded comment
commit fedd627cbac0ffa8cb6c2d833594aa07b490e27c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 08:21:37 2021 +0300
removed unneeded params from merklekeystore.Verifier
commit 98f09211fd224242c9be1b13f1fbbb64f52fbe07
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 08:19:28 2021 +0300
added codec to merklekeystore.signer
commit a3d883969cb8977f543a4e9ff6bc4bb92743acc8
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 19 08:17:54 2021 +0300
renamed ephemral keys
commit ed6736811009b4e41585c65c4236409207a86ff3
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 18 14:08:51 2021 +0300
fix: unit test failed because of parallel flag
commit 2308acc926dce5f5a9088cb33de5eea1ad16b3ff
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 18 13:24:19 2021 +0300
fix: code now aligns with sanity checks
commit a15cb6af310e534ba1b4f070e8407666fe949f33
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 18 11:25:10 2021 +0300
creating merkle key store
a package in crypto to support multiple key generation for rounds.
the merkle key store outputs a signer and a verifier to be used.
commit 25e832fa4612c95d6d34624c0dddcc359cda8f5e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 18 09:30:27 2021 +0300
verifyingKey conforms with Hashable interface
commit 752ab75d041b13b88d38e82690f4d83ae9d4cea5
Merge: 7e70ca2b 689f9fa0
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 15:19:45 2021 +0300
Merge branch 'feature/dilithium-scheme-integration' of github.com:algorand/go-algorand into feature/dilithium-scheme-integration
commit 7e70ca2b8f1a92f37727e575ee37935eec798277
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 13:35:22 2021 +0300
fix: make lint
commit 3cf4bbfa375b7cf1bfeb1ecd80d9e7a0c737d2d1
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 11:46:49 2021 +0300
gen generates blockProofPK only once the key is enabled
commit 2959e6bd423a354aa54e4cc74fb0404eaa8688bd
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 11:27:02 2021 +0300
corrected apply. added test for current ver and future ver
commit 07a1f614626c4baeed3590c93fdd9ff4dfbc24e3
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 10:57:58 2021 +0300
fix: reused comparision inside blockProofPKWellFormed
commit e9dfbff421d1bdbb12b86eb485a09d2f352c9152
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 10:55:33 2021 +0300
repositioned the checks for blockproofPK
commit 3d11029409877bd59c444f768e9df36e5ae9e17e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 07:33:54 2021 +0300
covered line in wellform check of the blockProofPK
commit 739d23b767a361a24adf1f94a22717abf528f7d7
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 07:27:27 2021 +0300
fix: go fmt
commit 1a7b98ce026d13c5b8ac30aba64b3f92567d9845
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 07:25:03 2021 +0300
removed unused function
commit 429e899f0cc68748db9f2f089ec418c48f9b9ec2
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 14 18:28:59 2021 +0300
keyreg txn creation takes into account the current version
commit d9756b621593088bf4827cfe7f0569deedd7cdaa
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 14 14:28:28 2021 +0300
fix: added to goal network genesis creation function the blockProofID too
commit 130841a2373b019d1ac2590f306d90da430724a8
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 14 11:48:41 2021 +0300
fix: blockProof wellformed checks that offline keyreg is correct
commit 3268e14ab64073df87128e209ed8d489da00cad1
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 14 11:08:57 2021 +0300
added wellFormed checks for offline
commit 1e07385cfc9f3ac21cf4df589798951b1abef0fc
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 12 18:47:53 2021 +0300
shorter codec names for blockProofPKs
commit de1566c27f25e0839622fc62e02d332b638f5b2f
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 12 18:43:25 2021 +0300
fix: didn't check offline requests on the blockProofPK
commit ae7a18d0a6161fcdfbb54d7a6c088196b8b130f1
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 12 11:19:14 2021 +0300
added test that inspects blockProofPK are stored in the account
commit 82dbcba4302bea1dae7d3c8aceb517d3a19fb923
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 12 08:50:32 2021 +0300
fix: correct keyregTXNfields for different version types
commit 1208690db89eb7e41e1ec226b512038ac9ed9fa5
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 17:35:42 2021 +0300
fix: because WellFormed is run before keyreg - no need to check BlockProofPK inside Keyreg
commit ce7f678adf4a738621560c6d3d329f407edb0ef5
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 16:10:42 2021 +0300
fix: transaction wellformed now checks if blockProofPK is valid
commit 02414eeb6da6a5ba76436d75a99b843fca07b1d7
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 16:03:39 2021 +0300
added unit test to keyreg apply
commit c6605aae4206835a8989d17eddae77f8befe59b6
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 15:03:50 2021 +0300
added basic support to wellformness of keyReg transaction
commit 87204adb40c2bfed175d2fa014af7de0dc79529d
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 13:12:05 2021 +0300
renamed blockProofPK
commit 5d2951aa415bf3c2d71cf02503ca110f5162e300
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 8 14:13:42 2021 +0300
added to structs in data package compact cert keys
commit db862c3335e6cda74a7d230f617e256a6b16976c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 12:55:32 2021 +0300
altered comments
commit 81229a05487c4d992bc53073b56b2892ac4e945b
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 12:46:50 2021 +0300
renamed partkeyInfo field
commit 1b0bb9ccb40603639023a3727ec77b70e6ec4e1f
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 08:00:46 2021 +0300
added liscenses to new files
commit b6b682d94d3af17889853d3a8599338b6e6ac880
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 07:52:00 2021 +0300
changed name of compactCert key
commit 164790a4d625a9aa4d14705529d8a9f20715627c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 8 19:41:32 2021 +0300
fix: changed comments
commit b34bcceb84d0314b77f2f1a5e5d030e293b4585b
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 8 13:29:02 2021 +0300
interface change
commit b687250b87d9b7ad10e3e754b282641a7345e87b
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 8 11:00:25 2021 +0300
refactor: cleaned if statement
commit 0317dc3d0bbc00cac29b8f6faf316396a0ddc2ee
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 8 10:48:41 2021 +0300
fix: part.CompactCertSigner returned nil, made certain to inspect that
commit a89dee56ea97baa4098e71c32fd019d7f4b6c1c2
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 14:21:00 2021 +0300
added space in a tx.Exec query string
commit 75869910844c2cea6df2d3865b8401c1c95aeede
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 10:52:52 2021 +0300
changed subTests into Tests
commit 9bddd1006b9ca6c9a833a1726bc427841880ac3c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 10:44:42 2021 +0300
move variable to test
commit edc8c706a3b6bc0b6f64a668f4390fc49d8c5989
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 10:40:49 2021 +0300
changed comment
commit 5fb257e18fafc5991d94e34b2d6b2be2389d079a
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 10:32:16 2021 +0300
fix: did not return error from function
commit be42ad969c0fcb0a65cb588ea717b8e2226ddebd
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 10:17:18 2021 +0300
fix: bad design in getting verifyingKey
commit 43033487aa702e6878e1d1e9939ba97f2e762db2
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 17:10:06 2021 +0300
changed Verifier interface
commit d8b71d0d6f6aaf6fd84f9d08cf2330cd97ae321a
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 16:20:20 2021 +0300
added test to retrieve participation keys from an unupdated DB
commit 3e5461ceb122ce4464c6a9bd5942f73b0454f26b
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 15:09:03 2021 +0300
lint fix
commit f4e90cefd8218041f70fa29d5d4b260fcd7889d3
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 14:14:49 2021 +0300
added migration tests to participation package
commit 936e59f24ef6f5eb12faf5089d9aa71262c7a99e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 11:49:35 2021 +0300
fix: bug in migrate, added a unit test to check migration
commit fd626513cdbfa19bfec7e9e220e658e9c82a0d40
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 09:59:09 2021 +0300
add unit test to participation_test
commit 55a859a3335b00fe37aa6a6300554297d0a3971f
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 16:43:58 2021 +0300
changed Signer, Verifier interfaces
commit f2750f505086bfa79ef11773967fd59487f061ba
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 15:43:30 2021 +0300
added to partkeyinfo command print of the compact cert
commit 6f63e7de3d39b9b753b8367a3177aa5fb9a115fb
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 15:42:42 2021 +0300
partKey load function from DB to support new compact cert key
commit ef8d14ac9e98b404fa6f09286c56ea0ae66948ca
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 15:32:27 2021 +0300
changed partMigrate function to support new version
commit 9804615e220e3c2753d28727d466a3ed846d8680
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 14:00:57 2021 +0300
persisting participation key will store the a key for compact certificate
commit 30419ab4daccbf0ce62cddee18a4dbf5649c6252
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 07:07:14 2021 +0300
changed participation compactCertKey to use the new abstraction
commit 7e6b78010f40c80f88c4cc8bf1904e2696b07db0
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 07:05:16 2021 +0300
added abstraction to signing keys
commit d339a87178b08ede3ac82fea71c7976b768c092a
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 1 20:32:50 2021 +0300
written SignatureAlgorithm and verifyingKey types
commit 61b6602d66191e3514c9bec3bedb3e1303b94f1e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 1 15:12:23 2021 +0300
added compact cert creation to participation struct
commit 5dbd0bc610cdfdaa144ca719e165375709351865
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 1 14:48:18 2021 +0300
wip: added placeholder object to represent key
commit 689f9fa08ab0c51a4fda5550067993ea63f4cd6b
Merge: 94643c1c 90c132eb
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Thu Jul 15 14:36:48 2021 +0300
Merge pull request #2518 from algonathan/key-reg
blockproofkey-registration
commit 90c132eb398a895d3a4239489b67bfbbd54b25ad
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 13:35:22 2021 +0300
fix: make lint
commit 87a6b0b1cbb3e419d5ebb0bb6ba732b9679eae6f
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 11:46:49 2021 +0300
gen generates blockProofPK only once the key is enabled
commit 3c9c2bf26b2fa052334ab2435e50f57f7a4e886e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 11:27:02 2021 +0300
corrected apply. added test for current ver and future ver
commit ba4ad34c6f8bd25004c61d22f6792c55de71c3c2
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 10:57:58 2021 +0300
fix: reused comparision inside blockProofPKWellFormed
commit 7ee971e5cb5ba221fd765d3194f28d83594f73d9
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 10:55:33 2021 +0300
repositioned the checks for blockproofPK
commit 5e5043dbc32a031b311cafdb59f74174bc3b86d0
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 07:33:54 2021 +0300
covered line in wellform check of the blockProofPK
commit 17386d3d2d45b1dc74b4a8e99f25d925df3936c5
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 07:27:27 2021 +0300
fix: go fmt
commit 4828bb2990530e208b1ab22553ebcd8d58b99659
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 15 07:25:03 2021 +0300
removed unused function
commit 2612251ac51485eacedcd93bcf171a6753e309f1
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 14 18:28:59 2021 +0300
keyreg txn creation takes into account the current version
commit b6802d58edbf95f8230ac38bc593a3f6c8532072
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 14 14:28:28 2021 +0300
fix: added to goal network genesis creation function the blockProofID too
commit 2e6e2211a663b00c3fb1105ce777ae85327045ad
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 14 11:48:41 2021 +0300
fix: blockProof wellformed checks that offline keyreg is correct
commit 281d01595c57a1b62449032598ef69660906f9d2
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 14 11:08:57 2021 +0300
added wellFormed checks for offline
commit 030062056d186e4e4d294ee0e679547859b0a13a
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 12 18:47:53 2021 +0300
shorter codec names for blockProofPKs
commit 77d7385a786a53a2fe80af703a01ffff2e2987fa
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 12 18:43:25 2021 +0300
fix: didn't check offline requests on the blockProofPK
commit dd3ad384fd8e97c377a7237202ec30e787d35610
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 12 11:19:14 2021 +0300
added test that inspects blockProofPK are stored in the account
commit 64a2c3b5b2bcd090b9915feb6a038d0270caa0d2
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 12 08:50:32 2021 +0300
fix: correct keyregTXNfields for different version types
commit 29c7cef33443cf4f5e71abdce2c0a16339be9654
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 17:35:42 2021 +0300
fix: because WellFormed is run before keyreg - no need to check BlockProofPK inside Keyreg
commit 33867e6079a690f5599a623d7a26048c4d70af74
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 16:10:42 2021 +0300
fix: transaction wellformed now checks if blockProofPK is valid
commit cae501b6417af8e831728376c1edbdd55de54001
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 16:03:39 2021 +0300
added unit test to keyreg apply
commit c57757a97bdf80af7f4453009fe34ebca4645615
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 15:03:50 2021 +0300
added basic support to wellformness of keyReg transaction
commit 94643c1cd335e65c13ec4272323888201371dc60
Merge: 415d82cd f00603c4
Author: algoidan <79864820+algoidan@users.noreply.github.com>
Date: Sun Jul 11 13:45:08 2021 +0300
Merge pull request #2501 from algonathan/signer
add-participation-key-for-compact-cert
commit ec56aa26a0f7265142cbfcaf984437b8f09294c9
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 13:12:05 2021 +0300
renamed blockProofPK
commit 0a0cc84d04fb09e8d2d5d51f1068ff28757ae94c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 8 14:13:42 2021 +0300
added to structs in data package compact cert keys
commit f00603c4c16ee77e1ec11c823ac55f7a17c03804
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 12:55:32 2021 +0300
altered comments
commit ee5246ca6b1bb4fbb22b9feffb1d4ad2144aedd5
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 12:46:50 2021 +0300
renamed partkeyInfo field
commit c79463a84439cddded532dbc865076526e0af7f8
Merge: 3afdb9a7 415d82cd
Author: algonathan <85506383+algonathan@users.noreply.github.com>
Date: Sun Jul 11 10:21:38 2021 +0300
Merge branch 'algorand:master' into signer
commit 3afdb9a72f543e8c7133a2da645c891b34e05c42
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 08:00:46 2021 +0300
added liscenses to new files
commit 78cf451315712dcf2a8b20fe2d64af07a7736bb5
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 11 07:52:00 2021 +0300
changed name of compactCert key
commit 3b0c35845a70cd6494e7705c94f57e10a54457de
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 8 19:41:32 2021 +0300
fix: changed comments
commit 5e564044e77b88bd9ab315cf3602ab7875710a14
Merge: e649a375 3ac481ec
Author: algonathan <85506383+algonathan@users.noreply.github.com>
Date: Thu Jul 8 15:11:13 2021 +0300
Merge branch 'algorand:master' into signer
commit e649a375371068016f9ac74e3a6b17fd6ae79eeb
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 8 13:29:02 2021 +0300
interface change
commit f69615d02db7746a05ac3aa93804d5fb62f24020
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 8 11:00:25 2021 +0300
refactor: cleaned if statement
commit bc8e0ebc3e2768f55ab7cf462e65a2e2d5476362
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 8 10:48:41 2021 +0300
fix: part.CompactCertSigner returned nil, made certain to inspect that
commit b4093f5478396135843a4387b5d9730a9619baeb
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 14:21:00 2021 +0300
added space in a tx.Exec query string
commit ecb8871f7907b0daf94bfa9d730edbfa6d9d6ae9
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 10:52:52 2021 +0300
changed subTests into Tests
commit f5448f45b4f6d8530af0dd76877639dc7492b4ff
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 10:44:42 2021 +0300
move variable to test
commit 6e952b29dc22d0c0e192be7b1d81d0791038a07c
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 10:40:49 2021 +0300
changed comment
commit 63247238b13aafdf7456e446d31fd2a78765a9f9
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 10:32:16 2021 +0300
fix: did not return error from function
commit e0b81094f365a5b6a46118a6ca35f0030ed30f1e
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Wed Jul 7 10:17:18 2021 +0300
fix: bad design in getting verifyingKey
commit f50696f0dc4364cfcdd637f1eef46aa31e3e5fbf
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 17:10:06 2021 +0300
changed Verifier interface
commit 63f906f3cc9c0093d0dd1609a9a277926a9588ec
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 16:20:20 2021 +0300
added test to retrieve participation keys from an unupdated DB
commit 296ab931a5c12aaaf963ea81d4099f95e9d1e37f
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 15:09:03 2021 +0300
lint fix
commit 76ef7a08c83dd4be8b0bd123254032765b327db6
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 14:14:49 2021 +0300
added migration tests to participation package
commit dc13ec58e085ae5fb9b38ee208dee08d0ad225c9
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 11:49:35 2021 +0300
fix: bug in migrate, added a unit test to check migration
commit dccb6afd22b7c185d99854d532212bdeb6b7935f
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Mon Jul 5 09:59:09 2021 +0300
add unit test to participation_test
commit b548391ef9bbb97120aeb6e3fcfe06f8a1a419e1
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 16:43:58 2021 +0300
changed Signer, Verifier interfaces
commit 29790394859d2621542c1b58b1a5e56305f15bf9
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 15:43:30 2021 +0300
added to partkeyinfo command print of the compact cert
commit 94e6fdc73f0b7f9b22c8ed460a9013ee7b169ca7
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 15:42:42 2021 +0300
partKey load function from DB to support new compact cert key
commit b3a6c214f5523c6deb120da0c3a26843994dcc28
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 15:32:27 2021 +0300
changed partMigrate function to support new version
commit c2432d7f7aa6f8bd2224b1e2210ea86fd6f086d0
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 14:00:57 2021 +0300
persisting participation key will store the a key for compact certificate
commit 2e003a405dc00d84b96815a54e5de266ec770a29
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 07:07:14 2021 +0300
changed participation compactCertKey to use the new abstraction
commit 5016ab1a397e5895660e1b788bcadf23cfac7f4d
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Sun Jul 4 07:05:16 2021 +0300
added abstraction to signing keys
commit a04011fe612f8fbf29954e2ebb60cbe360d23e49
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 1 20:32:50 2021 +0300
written SignatureAlgorithm and verifyingKey types
commit 63f8a81c8c690903813284e794f94a35ce9b9016
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 1 15:12:23 2021 +0300
added compact cert creation to participation struct
commit 5fff52dc72de06e6324c8978c42ab6369c5f9016
Author: Jonathan Weiss <jonathan.weiss@algorand.com>
Date: Thu Jul 1 14:48:18 2021 +0300
wip: added placeholder object to represent key
shiqizng
pushed a commit
to shiqizng/go-algorand
that referenced
this pull request
Apr 5, 2022
btcgenz
added a commit
to Swarm-Cool/swm-miner
that referenced
this pull request
Apr 7, 2025
garyrob
pushed a commit
to garyrob/go-hedgecoin
that referenced
this pull request
Feb 22, 2026
## Changes to spec.md ### Issue algorand#1: HTTP Status Code Handling Added proper status code checking in `doRequest()`: - Read full body with `io.ReadAll` before checking status - Handle non-2xx responses by trying to parse JSON error, otherwise return generic HTTP error ### Issue algorand#2 & algorand#3: Request Body Type Field - Explicitly stated that the `type` field is **removed** from request bodies - Added new section showing simplified request structs without `Type` field - Updated request/response documentation to note this change ### Issue algorand#4: Response Body Draining - Changed from `json.Decoder.Decode()` to `io.ReadAll()` + `json.Unmarshal()` - This ensures full body consumption for connection reuse even on error paths ### Issue algorand#5: Error Response Handling - Added structured error handling that distinguishes: - Non-2xx HTTP status: Try to parse JSON error from body, wrap as `DaemonError` or generic error - Connection errors: Return as-is ### Issue algorand#6: Python Daemon Error Format - Added `_send_json_response()` and `_send_json_error()` helper methods - All errors return JSON responses, not HTML - Error codes map to appropriate HTTP status codes ### Issue algorand#7: SetTimeouts() Implementation - Changed to use per-request context with timeout (`http.NewRequestWithContext`) - Dial timeout configured in Transport, query timeout used in context ### Issue algorand#8: Implementation Steps Order - Combined "Update Go Client" and "Update Go Test Server" into a single step - Updated plan.md to reflect this consolidation (now 3 implementation steps instead of 4) ### Additional Improvements - Added graceful shutdown documentation for Python daemon using `HTTPServer.shutdown()` - Added dial timeout configuration in Transport's DialContext
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.