websocket: terminate flushThread on Close() without writeTimeout#5
Merged
zeldovich merged 1 commit intoalgorand:masterfrom Jun 13, 2019
Merged
Conversation
|
|
algobolson
approved these changes
Jun 13, 2019
pzbitskiy
pushed a commit
to pzbitskiy/go-algorand
that referenced
this pull request
Mar 9, 2020
Implement txna and gtxna
bricerisingalgorand
referenced
this pull request
in bricerisingalgorand/go-algorand
Jun 10, 2020
Change waitForRoundOne timeout back to 1 minute
algorandskiy
referenced
this pull request
in algorandskiy/go-algorand
Jan 14, 2022
onetechnical
added a commit
that referenced
this pull request
Nov 16, 2022
go-algorand v3.11.3-stable
cce
pushed a commit
that referenced
this pull request
Nov 8, 2024
…asswd goal: add "wallet new" non-interactive flag (no password)
btcgenz
added a commit
to Swarm-Cool/swm-miner
that referenced
this pull request
Apr 7, 2025
garyrob
pushed a commit
to garyrob/go-hedgecoin
that referenced
this pull request
Feb 22, 2026
## Changes to spec.md ### Issue algorand#1: HTTP Status Code Handling Added proper status code checking in `doRequest()`: - Read full body with `io.ReadAll` before checking status - Handle non-2xx responses by trying to parse JSON error, otherwise return generic HTTP error ### Issue algorand#2 & algorand#3: Request Body Type Field - Explicitly stated that the `type` field is **removed** from request bodies - Added new section showing simplified request structs without `Type` field - Updated request/response documentation to note this change ### Issue algorand#4: Response Body Draining - Changed from `json.Decoder.Decode()` to `io.ReadAll()` + `json.Unmarshal()` - This ensures full body consumption for connection reuse even on error paths ### Issue algorand#5: Error Response Handling - Added structured error handling that distinguishes: - Non-2xx HTTP status: Try to parse JSON error from body, wrap as `DaemonError` or generic error - Connection errors: Return as-is ### Issue algorand#6: Python Daemon Error Format - Added `_send_json_response()` and `_send_json_error()` helper methods - All errors return JSON responses, not HTML - Error codes map to appropriate HTTP status codes ### Issue algorand#7: SetTimeouts() Implementation - Changed to use per-request context with timeout (`http.NewRequestWithContext`) - Dial timeout configured in Transport, query timeout used in context ### Issue algorand#8: Implementation Steps Order - Combined "Update Go Client" and "Update Go Test Server" into a single step - Updated plan.md to reflect this consolidation (now 3 implementation steps instead of 4) ### Additional Improvements - Added graceful shutdown documentation for Python daemon using `HTTPServer.shutdown()` - Added dial timeout configuration in Transport's DialContext
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.