txHandler: do not drop accepted mgs#6257
Merged
algorandskiy merged 2 commits intoalgorand:masterfrom Feb 20, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6257 +/- ##
==========================================
- Coverage 51.79% 51.77% -0.02%
==========================================
Files 644 644
Lines 86511 86512 +1
==========================================
- Hits 44805 44794 -11
- Misses 38834 38846 +12
Partials 2872 2872 ☔ View full report in Codecov by Sentry. |
jannotti
approved these changes
Feb 19, 2025
gmalouf
approved these changes
Feb 19, 2025
cce
approved these changes
Feb 20, 2025
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
(!isCMEnabled && congestedERL)condition in incomingMsgErlCheck added at some point to relief the spam congestion has the following side effect when:isCMEnabled) not enabled yet (it will be after the currentConsumeCapacityinvocation)In this case the condition
(!isCMEnabled && congestedERL)triggers congestion control to be enabled and dropping this message. In the same time consecutive messages would come through becauseisCMEnabledis set anderl.cm.ShouldDrop(c)might allow it due to messages rate.Fixed by enabling congestion control but accepting the message if
(!isCMEnabled && congestedERL)is met.Note to reviewers:
This fix came out from ERL work and is is also integrated into the ERL change #6176
Test Plan
Rely on existing tests