Skip to content

txHandler: do not drop accepted mgs #6257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
algorandskiy merged 2 commits into from
Feb 20, 2025
+5 −5
Merged

txHandler: do not drop accepted mgs #6257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b00534
txHandler: do not drop accepted mgs
algorandskiy Feb 15, 2025
2805a8d
fix misplaced comments
algorandskiy Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions data/txHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,15 +638,15 @@ func (handler *TxHandler) incomingMsgErlCheck(sender network.DisconnectableAddre
// is sufficient to indicate that we should enable Congestion Control, because
// an issue in vending capacity indicates the underlying resource (TXBacklog) is full
capguard, isCMEnabled, err = handler.erl.ConsumeCapacity(sender.(util.ErlClient))
if err != nil || // did ERL ask to enable congestion control?
(!isCMEnabled && congestedERL) { // is CM not currently enabled, but queue is congested?
if err != nil { // did ERL ask to enable congestion control?
handler.erl.EnableCongestionControl()
// if there is no capacity, it is the same as if we failed to put the item onto the backlog, so report such
transactionMessagesDroppedFromBacklog.Inc(nil)
return capguard, true
}
// if the backlog Queue has 50% of its buffer back, turn congestion control off
if !congestedERL {
} else if !isCMEnabled && congestedERL { // is CM not currently enabled, but queue is congested?
handler.erl.EnableCongestionControl()
} else if !congestedERL {
// if the backlog Queue has 50% of its buffer back, turn congestion control off
handler.erl.DisableCongestionControl()
}
}
Expand Down