txHandler: Use IP address instead of IP:port pair#6176
Merged
algorandskiy merged 14 commits intoalgorand:masterfrom Feb 21, 2025
Merged
txHandler: Use IP address instead of IP:port pair#6176algorandskiy merged 14 commits intoalgorand:masterfrom
algorandskiy merged 14 commits intoalgorand:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6176 +/- ##
==========================================
+ Coverage 51.76% 51.80% +0.04%
==========================================
Files 644 644
Lines 86506 86548 +42
==========================================
+ Hits 44777 44840 +63
+ Misses 38852 38842 -10
+ Partials 2877 2866 -11 ☔ View full report in Codecov by Sentry. |
cce
reviewed
Nov 20, 2024
algorandskiy
commented
Feb 14, 2025
jannotti
reviewed
Feb 19, 2025
cce
reviewed
Feb 20, 2025
cce
reviewed
Feb 20, 2025
Contributor
Author
|
Remerged, fixed a possible race condition in closer |
jannotti
reviewed
Feb 20, 2025
Co-authored-by: John Jannotti <jannotti@gmail.com>
jannotti
approved these changes
Feb 21, 2025
cce
approved these changes
Feb 21, 2025
algogm
previously approved these changes
Feb 21, 2025
gmalouf
approved these changes
Feb 21, 2025
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make ERL more strict by distinguishing IP addresses instead of connections.
Idea (basically as suggested in this comment: #6176 (comment))
erlClientMapperentity that maps sender's addresses to a meta peererlIPClient.erlIPClientfor senders (connections) with the same address and it's logic not changed.erlIPClienttracks senders with the same address.erlIPClientsets ownOnClosehandlers so that when network actually closes a connection, this handler is called.OnClosecalled to notify ERL about this client termination.Test Plan
erlIPClientunit testMemory use remained the same but the test does not have thousands of clients to tell for sure.