Skip to content

AVM: Add support for Boxes#4149

Merged
michaeldiamant merged 227 commits intomasterfrom
feature/avm-box
Oct 31, 2022
Merged

AVM: Add support for Boxes#4149
michaeldiamant merged 227 commits intomasterfrom
feature/avm-box

Conversation

@michaeldiamant
Copy link
Copy Markdown
Contributor

@michaeldiamant michaeldiamant commented Jun 17, 2022 •
edited
Loading

Provides an integration branch PR to simplify tracking changes to feature/avm-box in support of #3890.

Zeph Grunschlag and others added 29 commits June 8, 2022 09:27
README.md as committed to in the last retro + just for temporary fun:…
37dbc22 
… justfile
wrong box name
d583864
@tzaffi @algochoi
Update cmd/goal/README.md
269cdfb 
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
add the TEAL code for app as well
82bf313
Merge branch 'readme-examples-for-goal' of github.com:tzaffi/go-algor…
a167359 
…and into readme-examples-for-goal
per CR suggestion - explain the expectations around go-algorand insta…
fe0f0c9 
…llation and goal's executable path
@tzaffi
Update cmd/goal/examples/boxes.teal
7824071
clear program as well
3472e15
Merge branch 'readme-examples-for-goal' of github.com:tzaffi/go-algor…
28abc2b 
…and into readme-examples-for-goal
@tzaffi
Update cmd/goal/examples/justfile
d61627b
@tzaffi
Update cmd/goal/examples/justfile
02a82ec
@tzaffi
Update cmd/goal/examples/justfile
40e29af
@jannotti
AVM: Add an unlimited global storage mechanism - Boxes. (#4001)
48994e3 
At least three four left to consider, as well as extensive testing.

Catchpoints, LRU cache, new hash costs
remove justfile
6635ffb
Merge remote-tracking branch 'algorand/feature/avm-box' into readme-e…
7866008 
…xamples-for-goal
flesh out the readme with more examples and clearer instructions
270d495
@jannotti
Merge master to f/avm-box (#4138)
f84af7e
Merge remote-tracking branch 'algorand/feature/avm-box' into readme-e…
5d43a4a 
…xamples-for-goal
@ahangsu
remove not my stuffs
b4e7edb
@tzaffi
Merge pull request #4095 from tzaffi/readme-examples-for-goal
10e29e1 
* README.md as committed to in the last retro
* See https://gist.github.com/tzaffi/d57018cb826f4766f8f4ce2ba4dbaec8 for the Justfile that was originally in the PR.
@ahangsu
per pr review, start e2e test in restClient test
d841a9a
@ahangsu
update e2e testcase
4077642
@ahangsu
update handler to follow convension
073a71b
@tzaffi
Readme fix (#4141)
d2c7c46
@ahangsu
rewrite boxes param description per pr comment
bdae462
@ahangsu
update e2e test
91a14fc
@ahangsu
per review comment
1b451c9
@ahangsu
use sql string
4bedff5
@ahangsu
better set of e2e test
4c377d8
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #4149 (238906c) into master (ab87a8a) will decrease coverage by 0.31%.
The diff coverage is 61.12%.

@@            Coverage Diff             @@
##           master    #4149      +/-   ##
==========================================
- Coverage   54.49%   54.18%   -0.32%     
==========================================
  Files         407      413       +6     
  Lines       52425    53408     +983     
==========================================
+ Hits        28569    28939     +370     
- Misses      21472    22060     +588     
- Partials     2384     2409      +25
Impacted Files Coverage Δ
catchup/ledgerFetcher.go 39.32% <0.00%> (-0.91%) ⬇️
cmd/goal/interact.go 3.62% <0.00%> (ø)
cmd/tealdbg/localLedger.go 64.81% <0.00%> (-0.41%) ⬇️
config/localTemplate.go 40.00% <ø> (ø)
daemon/algod/api/server/v2/dryrun.go 70.60% <0.00%> (-0.22%) ⬇️
daemon/algod/api/server/v2/utils.go 12.92% <0.00%> (-0.27%) ⬇️
data/basics/userBalance.go 29.72% <0.00%> (-1.41%) ⬇️
data/transactions/logic/doc.go 61.53% <ø> (ø)
data/transactions/logic/fields.go 75.12% <ø> (ø)
data/transactions/logic/fields_string.go 44.44% <ø> (ø)
... and 70 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

algorandskiy
algorandskiy previously approved these changes Oct 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I disagree with not storing any bits of boxes in ApplyData, everything else looks good for me.

@jannotti jannotti requested review from cce and jasonpaulos October 31, 2022 12:46
@michaeldiamant michaeldiamant changed the title AVM: Merge feature/avm box into master AVM: Add support for Boxes Oct 31, 2022
@michaeldiamant michaeldiamant mentioned this pull request Oct 31, 2022
Closed
5 tasks
@michaeldiamant
Copy link
Copy Markdown
Contributor Author

michaeldiamant commented Oct 31, 2022

PR looks ready to merge. Since I opened it, I can't approve.

Note - Calling it out so it's not forgotten: #4704 is also needed for the release.

jasonpaulos
jasonpaulos previously approved these changes Oct 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the whole looks good. I left some nits but I don't view them as blockers

Comment thread data/transactions/logic/parsing_test.go Outdated
Comment thread data/transactions/logic/box.go Outdated
cce
cce reviewed Oct 31, 2022
View reviewed changes
Comment thread ledger/internal/applications.go
)

type logicLedger struct {
cow cowForLogicLedger
Copy link
Copy Markdown
Contributor

@cce cce Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed, the cowForLogicLedger interface is now no longer used as a type anywhere in the code — I guess the interface listing below mostly exists as documentation (??) but could be removed

Copy link
Copy Markdown
Contributor

@jannotti jannotti Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing. I thought I had - maybe it came back in a merge.

cce
cce reviewed Oct 31, 2022
View reviewed changes
Comment thread util/db/dbutil.go
@michaeldiamant michaeldiamant merged commit 0cb9a2e into master Oct 31, 2022
@michaeldiamant michaeldiamant deleted the feature/avm-box branch October 31, 2022 18:41
@michaeldiamant michaeldiamant mentioned this pull request Oct 31, 2022
Merged
@michaeldiamant michaeldiamant restored the feature/avm-box branch October 31, 2022 20:00
This was referenced Oct 31, 2022
Merged
Merged
Merged
Merged
@algorandskiy algorandskiy mentioned this pull request Nov 1, 2022
Merged
@Algo-devops-service Algo-devops-service mentioned this pull request Nov 1, 2022
Merged
@michaeldiamant michaeldiamant deleted the feature/avm-box branch November 2, 2022 12:54
@michaeldiamant michaeldiamant mentioned this pull request Nov 5, 2022
Open
@Algo-devops-service Algo-devops-service mentioned this pull request Nov 10, 2022
Closed
@Algo-devops-service Algo-devops-service mentioned this pull request Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cce cce cce left review comments

@jannotti jannotti jannotti left review comments

@algorandskiy algorandskiy algorandskiy left review comments

@icorderi icorderi Awaiting requested review from icorderi

+5 more reviewers

@winder winder winder left review comments

@barnjamin barnjamin barnjamin left review comments

@ahangsu ahangsu ahangsu left review comments

@jasonpaulos jasonpaulos jasonpaulos approved these changes

@tzaffi tzaffi tzaffi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.