Boxes: Add support for Boxes by michaeldiamant · Pull Request #341 · algorand/go-algorand-sdk

michaeldiamant · 2022-07-06T20:46:54Z

Adds SDK support for Boxes introduced in algorand/indexer#1168 and algorand/go-algorand#4149.

* Merge develop into feature/box-storage * Finish merging makefile

* Github-Actions: Adding pr title and label checks (#336) * Dev Tools: Source map decoder (#335) * Updated CHANGELOG.md * AVM: Consolidate TEAL and AVM versions (#345) * Testing: Use Dev mode network for cucumber tests (#349) * AVM: Use avm-abi repo (#352) * Updated CHANGELOG.md * Enhancement: Use Sandbox for Testing (#360) Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * Bug-Fix: passthru verbosity (#371) * Enhancement: Deprecating use of langspec (#366) Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * StateProof: State proof support (#374) * Regenerate client. * Update txn and block objects, cucumber tests passing. * Enable cucumber tests. * Update types/stateproof.go * Add transactions-root-256 * Remove unused code. * Remove unused file * Add txn commitments blockheader fields * Rename signature, add allocbound definitions * Add txn commitment to header * PR comments * Remove unused file Co-authored-by: Will Winder <wwinder.unh@gmail.com> * State Proofs: Use generic type for StateProof txn field. (#378) * Use generic type for StateProof txn field. * Add missing type. * Remove GenericDigest. * fix type assertion on source map version (#370) * let the json package figure out how to decode the elements of the incoming map (#380) * StateProof: State Proof Verification additions (#377) * Regenerate client. * Remove unused file * moved files from stateproof verification repo * now using updated go-stateproof-verification * fixed go mod * moved consts near their usage * added working state proof verifier test * added unit test and resources * now using go 1.15 supported function * changes to avoid dependency of stateproof verification on SDK * added needed types to stateproof.go for message hashing * reverted packages, now using up to date go-stateproof-verification * CR: renamed verification functions * hashing sp message is now in crypto * removed hashing of light block header * CR: now allocating space upfront in hashing state proof message * attempting to use embedded files * CR: using GenericDigest in block.go * CR: Renamed package to match directory * Removed go 1.15 from CI * improved embed usage * CR: removed stateproof verification logic * tidied go mod file Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: Eric Warehime <eric.warehime@gmail.com> * State Proofs: added compute leaf function for light block header to sdk (#382) * added compute leaf function for light block header to sdk * renamed blockheader256 * changed passed type to pointer * reverted back to copying * renamed light block header hash func (#383) * Enable stpf cucumber unit tests (#386) Co-authored-by: Jack <87339414+algojack@users.noreply.github.com> Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Jack Smith <jack.smith@algorand.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com> Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com> Co-authored-by: Barbara Poon <barbara.poon@algorand.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> Co-authored-by: Eric Warehime <eric.warehime@gmail.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: Almog Tal <107349997+almog-t@users.noreply.github.com>

* Add generated code paths for indexer boxes * Add indexer path tests for boxes * Temporarily point testing branch to indexer-boxes * next * uniform with prev style * @unit.applications.boxes * Update .test-env Co-authored-by: Hang Su <hang.su@algorand.com> Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>

* add indexer impl in sdk * merge step for indexer * add indexer confirmed steps * remove all the logs, hope sleep do the trick * minor * sleep as ms * per new step expectation * unify with applications.boxes * phrasing * Update .test-env * minor

ahangsu

approving for parts other than test looks right to me

tzaffi

LGTM

jasonpaulos · 2022-09-23T22:49:18Z

I've created child PRs #410 and #411 to address my above comments -- review would be welcome

Co-authored-by: Hang Su <hang.su@algorand.com>

WIP: Update update master

Boxes: Support for Box array transaction field (#337)

87bbe39

michaeldiamant added the New Feature label Jul 6, 2022

michaeldiamant and others added 9 commits July 8, 2022 13:30

Boxes: Query algod Box by application ID and Box name (#338)

3956391

Boxes: Add convenience methods for encoding Box names (#342)

475a670

Boxes: Support GetApplicationBoxes (#344)

69644b7

Merge develop into feature/box-storage (#353)

42ba3e3

* Merge develop into feature/box-storage * Finish merging makefile

Merge branch 'develop' into feature/box-storage

1e09eac

boxes integration algod test

6b2f7ba

ahangsu reviewed Sep 15, 2022

View reviewed changes

Comment thread .test-env Outdated

tzaffi reviewed Sep 20, 2022

View reviewed changes

Comment thread test/integration.tags Outdated

ahangsu marked this pull request as ready for review September 20, 2022 17:03

remove unnecessary @Applications tag

266621b

tzaffi reviewed Sep 21, 2022

View reviewed changes

Comment thread encoding/box_query_encoding.go Outdated

ahangsu reviewed Sep 21, 2022

View reviewed changes

Comment thread future/transaction.go

remove unnecessary func

64001fb

ahangsu approved these changes Sep 21, 2022

View reviewed changes

tzaffi reviewed Sep 21, 2022

View reviewed changes

Comment thread test/algodclientv2_test.go Outdated

refactoring in algodclientv2 test

c5e5af8

tzaffi approved these changes Sep 21, 2022

View reviewed changes

jasonpaulos reviewed Sep 23, 2022

View reviewed changes

Comment thread client/v2/common/models/boxes_response.go

Comment thread future/transaction.go Outdated

Comment thread encoding/box_query_encoding.go Outdated

Comment thread test/applications_integration_test.go Outdated

Comment thread test/applications_integration_test.go Outdated

This was referenced Sep 23, 2022

Box storage improvements from review #410

Merged

Re-run generator for boxes branch #411

Merged

jasonpaulos and others added 2 commits September 26, 2022 09:30

Re-run generator for boxes branch (#411)

fab3e31

Box storage improvements from review (#410)

a042df9

Co-authored-by: Hang Su <hang.su@algorand.com>

jasonpaulos approved these changes Sep 26, 2022

View reviewed changes

jasonpaulos mentioned this pull request Sep 30, 2022

Box storage: Improvements from generator #417

Merged

jasonpaulos and others added 14 commits October 12, 2022 10:38

Merge branch 'develop' into feature/box-storage

15c411b

Remove newline

fef13bc

Box storage merge develop (#425)

5e94270

Merge branch 'box-storage-merge-develop' into feature/box-storage

e2ec98f

Merge branch 'develop' into feature/box-storage

5d2e5cf

Box storage: Improvements from generator (#417)

600e1df

Re-generate sources from upstream AVM branches

9ae6afa

Merge branch 'develop' into update_master

1236c6a

update circle go orb

906ec89

don't test unsupported version 1.16 on circle

87f2a33

Update .gitignore

47ac940

Update .circleci/config.yml

4ca3bd3

revert

86d287b

Merge pull request #429 from algorand/update_update_master

9d69302

WIP: Update update master

michaeldiamant changed the title ~~Boxes: Merge feature/box-storage into develop~~ Boxes: Add support for Boxes Oct 31, 2022

michaeldiamant commented Nov 2, 2022

View reviewed changes

Comment thread .test-env Outdated

Revert SDK_TESTING_BRANCH to master

80e7f91

michaeldiamant merged commit e9c1b3d into develop Nov 2, 2022

michaeldiamant deleted the feature/box-storage branch November 2, 2022 12:53

This was referenced Nov 2, 2022

Feature: Box Storage algorand/algorand-sdk-testing#192

Merged

Regenerate code with the latest specification file (f37bbe89) #431

Closed

Regenerate code with the latest specification file (e6f39565) #430

Closed

excalq mentioned this pull request Nov 3, 2022

FOR REVIEW ONLY - go-algorand-sdk v1.23.0 #432

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Boxes: Add support for Boxes#341

Boxes: Add support for Boxes#341
michaeldiamant merged 30 commits into
developfrom
feature/box-storage

michaeldiamant commented Jul 6, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahangsu left a comment

Uh oh!

Uh oh!

tzaffi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasonpaulos commented Sep 23, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

michaeldiamant commented Jul 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahangsu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tzaffi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasonpaulos commented Sep 23, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

michaeldiamant commented Jul 6, 2022 •

edited

Loading