Skip to content

Readme fix#4141

Merged
jannotti merged 5 commits into
algorand:feature/avm-boxfrom
tzaffi:README-fix
Jun 16, 2022
Merged

Readme fix#4141
jannotti merged 5 commits into
algorand:feature/avm-boxfrom
tzaffi:README-fix

Conversation

@tzaffi
Copy link
Copy Markdown
Contributor

@tzaffi tzaffi commented Jun 15, 2022

Fixing the last Q/A and removing the msgpack output which lulled me into falsely believing that the box create actually worked.

@tzaffi tzaffi changed the base branch from master to feature/avm-box June 15, 2022 21:12
Comment thread cmd/goal/README.md
Comment thread cmd/goal/README.md
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 15, 2022

Codecov Report

Merging #4141 (f9dc409) into feature/avm-box (10e29e1) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f9dc409 differs from pull request most recent head 0e844ce. Consider uploading reports for the commit 0e844ce to get more accurate results

@@                 Coverage Diff                 @@
##           feature/avm-box    #4141      +/-   ##
===================================================
- Coverage            54.56%   54.55%   -0.01%     
===================================================
  Files                  392      392              
  Lines                49085    49085              
===================================================
- Hits                 26782    26779       -3     
- Misses               20047    20051       +4     
+ Partials              2256     2255       -1     
Impacted Files Coverage Δ
util/metrics/reporter.go 56.31% <0.00%> (-4.86%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
ledger/tracker.go 73.16% <0.00%> (-1.30%) ⬇️
data/transactions/verify/txn.go 44.15% <0.00%> (-0.87%) ⬇️
network/wsPeer.go 67.67% <0.00%> (-0.83%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (-0.20%) ⬇️
ledger/acctupdates.go 64.89% <0.00%> (+0.60%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e29e1...0e844ce. Read the comment docs.

Comment thread cmd/goal/README.md Outdated
Comment thread cmd/goal/README.md Outdated
Comment thread cmd/goal/README.md
Comment thread cmd/goal/README.md Outdated
Comment thread cmd/goal/README.md Outdated
@tzaffi
Copy link
Copy Markdown
Contributor Author

tzaffi commented Jun 16, 2022

Hopefully my final question @jannotti :

image

Is this overkill? Should I try and fund with the minimum necessary to run the example?

@jannotti
Copy link
Copy Markdown
Contributor

Hopefully my final question @jannotti :

image

Is this overkill? Should I try and fund with the minimum necessary to run the example?

I think it's fine either way, I don't expect anyone reading this doc is worried about following it to the letter.

A nice addition, in another PR, would be showing how to add another user account. I imagine that devs might need that next. They have one well-funded account, how do they do things between two different accounts with a minimum of fuss? Only then might you worry about give too much money out to the other accounts.

Comment thread cmd/goal/README.md
@tzaffi tzaffi requested a review from jannotti June 16, 2022 19:13
@jannotti jannotti merged commit d2c7c46 into algorand:feature/avm-box Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants