Skip to content

🎨 Palette: Enhance proof card focus and tactile active states - #728

Closed
alehar9320 wants to merge 1 commit into
mainfrom
palette/proof-card-focus-tactile-10490047230253201515
Closed

alehar9320 wants to merge 1 commit into
mainfrom
palette/proof-card-focus-tactile-10490047230253201515

Conversation

@alehar9320

@alehar9320 alehar9320 commented Aug 27, 2026 •

Copy link
Copy Markdown
Owner

Enhances UX and accessibility for .proof-card elements on index.astro and work.astro by aligning :focus-visible outlines with the card's border-radius (preventing rectangular focus overflow) and adding a tactile :active scale transition gated behind prefers-reduced-motion.


PR created automatically by Jules for task 10490047230253201515 started by @alehar9320

Summary by CodeRabbit

  • Style
    • Improved rounded corners and focus outlines on proof cards.
    • Added subtle pressed-state scaling for tactile feedback.
    • Respects reduced-motion preferences by disabling the animation when requested.

Explicitly align proof card focus-visible outline with card border radius
and add motion-safe tactile active scaling feedback.

Co-authored-by: alehar9320 <5390430+alehar9320@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@alehar9320
alehar9320 temporarily deployed to palette/proof-card-focus-tactile-10490047230253201515 - astro-cloudflare-personal-website-web-service PR #728 August 27, 2026 02:33 — with Render Destroyed
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
me 42c1c6b Commit Preview URL

Branch Preview URL
Aug 27 2026, 02:34 AM

@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 17b86501-ba0e-4981-be88-a3e84d133e46

📥 Commits

Reviewing files that changed from the base of the PR and between 6e43d52 and 42c1c6b.

📒 Files selected for processing (3)
  • .Jules/palette.md
  • src/pages/index.astro
  • src/pages/work.astro

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change updates .proof-card styling on the index and work pages. It adds rounded focus treatment, motion-safe pressed-state scaling, and reduced-motion handling. The palette journal records the implementation.

Changes

Proof-card styling

Layer / File(s) Summary
Proof-card focus and pressed states
src/pages/index.astro, src/pages/work.astro, .Jules/palette.md
.proof-card now uses a matching border radius. Motion-enabled users receive a transform transition and scale(0.98) active state. Reduced-motion users receive no transform. The palette journal records these changes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 42c1c

This localized accessibility and interaction update is merge-ready after normal checks and review, with no actionable merge-blocking risk remaining.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: improved proof card focus styling and tactile active states. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/proof-card-focus-tactile-10490047230253201515

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/pages/index.astro

typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1
typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1

Oops! Something went wrong! :(

ESLint: 10.9.1

Error: typescript-eslint does not support TS 7.0.
at Object. (/.eslint-tmp/node_modules/typescript-eslint/dist/index.js:52:11)
at Module._compile (node:internal/modules/cjs/loader:1830:14)
at Object..js (node:internal/modules/cjs/loader:1961:10)
at Module.load (node:internal/modules/cjs/loader:1553:32)
at Module._load (node:internal/modules/cjs/loader:1355:12)
at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
at loadCJSModuleWithModuleLoad (node:internal/modules/esm/translators:326:3)
at ModuleWrap. (node:internal/modules/esm/translators:231:7)
at ModuleJob.run (node:internal/modules/esm/module_job:437:25)
at async node:internal/modules/esm/loader:639:26

src/pages/work.astro

ESLint skipped: the matched ESLint configuration already failed (config-incompatibility).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

Affected Assets, Files, and Routes:

view changes for bundle: molecular-mars-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_astro/page.XC_-8Hsc.js (New) 271.68kB 271.68kB 100.0% 🚀
_astro/PostHog.astro_astro_type_script_index_0_lang.BIr4jtL-.js (New) 240.64kB 240.64kB 100.0% 🚀
_astro/Chat.astro_astro_type_script_index_0_lang.DYeiRymb.js (New) 9.53kB 9.53kB 100.0% 🚀
_astro/hire-analytics.D0d0Dl98.js (New) 924 bytes 924 bytes 100.0% 🚀
_astro/BaseLayout.astro_astro_type_script_index_0_lang.GsWz1Ulz.js (New) 598 bytes 598 bytes 100.0% 🚀
_astro/contact.astro_astro_type_script_index_0_lang.-1D6I-HA.js (New) 554 bytes 554 bytes 100.0% 🚀
_astro/page.CbMXyTV6.js (Deleted) -271.68kB 0 bytes -100.0% 🗑️
_astro/PostHog.astro_astro_type_script_index_0_lang.BZRCmEhJ.js (Deleted) -240.64kB 0 bytes -100.0% 🗑️
_astro/Chat.astro_astro_type_script_index_0_lang.BOVvbDKh.js (Deleted) -9.53kB 0 bytes -100.0% 🗑️
_astro/hire-analytics.Cho8HBD8.js (Deleted) -924 bytes 0 bytes -100.0% 🗑️
_astro/BaseLayout.astro_astro_type_script_index_0_lang.v40waB-l.js (Deleted) -598 bytes 0 bytes -100.0% 🗑️
_astro/contact.astro_astro_type_script_index_0_lang.DIKclNVc.js (Deleted) -554 bytes 0 bytes -100.0% 🗑️

@mergify

mergify Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@alehar9320
alehar9320 marked this pull request as draft August 27, 2026 02:35
@alehar9320

Copy link
Copy Markdown
Owner Author

Closing unmerged as Jules. Converted to draft first to disarm auto-merge/Mergify, then closed. No freeze of this PR, no dual PASS, so it was never merge-eligible.

Same Palette class as #715/#701/#673/#663/#652/#639/#622: component CSS + .Jules/palette.md journal in one branch. Standing policy stands — no Palette onto main as a class. Substantively this is the proof-card cousin of #715 (Chat :focus-visible + scale() tactile + journal): here the same kernel lands on .proof-card in index.astro / work.astro. Do not merge. Do not reopen as Jules.

Two specific reasons beyond the class:

  1. The accessibility kernel is already on live 6e43d52. Both pages already give .proof-card:focus-visible outline: 2px solid var(--accent-regular) and outline-offset: 4px — our 4px spatial model. This PR does not add missing rings. On work.astro the card already has border-radius: 1.5rem; restating it on :focus-visible is redundant. On index.astro the cards are unboxed text links (background: none; border: 0); adding border-radius: 0.375rem invents a visual box that is not in the live design. The scale(0.98) / translateY(0) scale(0.98) tactile layer is the same decorative farm as 🎨 Palette: Enhance focus states and tactile feedback in Chat UI controls #715's scale(0.96) and the CTA tactile class (Jules: CallToAction Tactile Compression Enhancement #726/Jules: Call To Action Ambient Glow Enhancement #699/Jules: Call To Action Ambient Glow Enhancement #650). Cosmetic. Not a visitor outcome. work.astro also duplicates :active once unconditionally and once inside the hover media, then overrides under prefers-reduced-motion: reduce — messy, not a clean cut.

  2. The journal entry is dated 2026-05-20 and inserted above the 2026-05-17 entry, while the branch was pushed 2026-08-27. Same backdated journal artifact we closed 🎨 Palette: Enhance focus states and tactile feedback in Chat UI controls #715 on.

No kernel to queue for Dan. Focus rings already match the 4px spatial model. Do not cherry-pick the radius or the scale. Not now.

Hire path stays LinkedIn. Overlay 69ca717 stays. Live 6e43d52 stands. Stay off #698 #691 #597. Queue 0.

@alehar9320 alehar9320 closed this Aug 27, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing unmerged as Jules. Converted to draft first to disarm auto-merge/Mergify, then closed. No freeze of this PR, no dual PASS, so it was never merge-eligible.

Same Palette class as #715/#701/#673/#663/#652/#639/#622: component CSS + .Jules/palette.md journal in one branch. Standing policy stands — no Palette onto main as a class. Substantively this is the proof-card cousin of #715 (Chat :focus-visible + scale() tactile + journal): here the same kernel lands on .proof-card in index.astro / work.astro. Do not merge. Do not reopen as Jules.

Two specific reasons beyond the class:

  1. The accessibility kernel is already on live 6e43d52. Both pages already give .proof-card:focus-visible outline: 2px solid var(--accent-regular) and outline-offset: 4px — our 4px spatial model. This PR does not add missing rings. On work.astro the card already has border-radius: 1.5rem; restating it on :focus-visible is redundant. On index.astro the cards are unboxed text links (background: none; border: 0); adding border-radius: 0.375rem invents a visual box that is not in the live design. The scale(0.98) / translateY(0) scale(0.98) tactile layer is the same decorative farm as 🎨 Palette: Enhance focus states and tactile feedback in Chat UI controls #715's scale(0.96) and the CTA tactile class (Jules: CallToAction Tactile Compression Enhancement #726/Jules: Call To Action Ambient Glow Enhancement #699/Jules: Call To Action Ambient Glow Enhancement #650). Cosmetic. Not a visitor outcome. work.astro also duplicates :active once unconditionally and once inside the hover media, then overrides under prefers-reduced-motion: reduce — messy, not a clean cut.

  2. The journal entry is dated 2026-05-20 and inserted above the 2026-05-17 entry, while the branch was pushed 2026-08-27. Same backdated journal artifact we closed 🎨 Palette: Enhance focus states and tactile feedback in Chat UI controls #715 on.

No kernel to queue for Dan. Focus rings already match the 4px spatial model. Do not cherry-pick the radius or the scale. Not now.

Hire path stays LinkedIn. Overlay 69ca717 stays. Live 6e43d52 stands. Stay off #698 #691 #597. Queue 0.

Understood. Acknowledging that this pull request is closed and stopping work on this task.

This branch was successfully deployed

No deployments
palette/proof-card-focus-tactile-10490047230253201515 - astro-cloudflare-personal-website-web-service PR #728 — 42c1c6b0 Deployed Aug 27, 2026 by alehar9320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant