Skip to content

🎨 Palette: External links security & focus state enhancement - #663

Closed
alehar9320 wants to merge 1 commit into
mainfrom
palette/external-links-and-focus-ux-14334931662967808192
Closed

alehar9320 wants to merge 1 commit into
mainfrom
palette/external-links-and-focus-ux-14334931662967808192

Conversation

@alehar9320

@alehar9320 alehar9320 commented Aug 23, 2026 •

Copy link
Copy Markdown
Owner

Enhanced external links in Nav.astro and Footer.astro with target="_blank" and rel="noopener noreferrer" to preserve user context when navigating to external profiles. Improved focus-visible accessibility styling for the skip-to-content link in BaseLayout.astro. All modifications verified via formatting, linting, tests, build checks, Playwright visual screenshot generation, and documented in .Jules/palette.md.


PR created automatically by Jules for task 14334931662967808192 started by @alehar9320

Summary by CodeRabbit

  • Accessibility
    • Improved skip-to-content link visibility for keyboard navigation with a high-contrast focus indicator.
  • User Experience
    • Social links in the header and footer now open in new browser tabs, helping preserve the current page and session state.
    • Added secure handling for links opened in new tabs.

Enhance external social link security and context preservation by adding
target="_blank" and rel="noopener noreferrer" in Nav.astro and Footer.astro.
Improve focus-visible styling for screen-reader skip-link in BaseLayout.astro.

Co-authored-by: alehar9320 <5390430+alehar9320@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@alehar9320
alehar9320 temporarily deployed to palette/external-links-and-focus-ux-14334931662967808192 - astro-cloudflare-personal-website-web-service PR #663 August 23, 2026 02:31 — with Render Destroyed
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
me b50dddb Commit Preview URL

Branch Preview URL
Aug 23 2026, 02:32 AM

@coderabbitai

coderabbitai Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 05bdd190-e940-4173-b3c4-e3b4b32ecd94

📥 Commits

Reviewing files that changed from the base of the PR and between da09e2a and b50dddb.

📒 Files selected for processing (4)
  • .Jules/palette.md
  • src/components/Footer.astro
  • src/components/Nav.astro
  • src/layouts/BaseLayout.astro

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Social links in the footer and navigation now open in protected new tabs. The skip-to-content link has explicit :focus-visible styling with an accent outline. A journal entry records these updates.

Changes

Navigation and accessibility behavior

Layer / File(s) Summary
Protected external social links
src/components/Footer.astro, src/components/Nav.astro
Social links use target="_blank" and rel="noopener noreferrer" while retaining existing destinations and analytics attributes.
Skip-link focus styling and journal record
src/layouts/BaseLayout.astro, .Jules/palette.md
Skip-link styles cover :focus and :focus-visible, with a 2px accent outline and 4px offset. The journal records both accessibility updates.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to b50dd

The PR makes localized external-link security and skip-link focus styling improvements, with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the external-link security and skip-link focus styling changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/external-links-and-focus-ux-14334931662967808192

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/components/Footer.astro

typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1
typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1

Oops! Something went wrong! :(

ESLint: 10.9.0

Error: typescript-eslint does not support TS 7.0.
at Object. (/node_modules/typescript-eslint/dist/index.js:52:11)
at Module._compile (node:internal/modules/cjs/loader:1830:14)
at Object..js (node:internal/modules/cjs/loader:1961:10)
at Module.load (node:internal/modules/cjs/loader:1553:32)
at Module._load (node:internal/modules/cjs/loader:1355:12)
at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
at loadCJSModuleWithModuleLoad (node:internal/modules/esm/translators:326:3)
at ModuleWrap. (node:internal/modules/esm/translators:231:7)
at ModuleJob.run (node:internal/modules/esm/module_job:437:25)
at async node:internal/modules/esm/loader:639:26

src/components/Nav.astro

ESLint skipped: the matched ESLint configuration already failed (config-incompatibility).

src/layouts/BaseLayout.astro

ESLint skipped: the matched ESLint configuration already failed (config-incompatibility).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

Affected Assets, Files, and Routes:

view changes for bundle: molecular-mars-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_astro/page.CuMxzXsN.js (New) 271.68kB 271.68kB 100.0% 🚀
_astro/PostHog.astro_astro_type_script_index_0_lang.DYVggrod.js (New) 240.64kB 240.64kB 100.0% 🚀
_astro/Chat.astro_astro_type_script_index_0_lang.aOINZVRd.js (New) 9.68kB 9.68kB 100.0% 🚀
_astro/hire-analytics.BivakOc1.js (New) 924 bytes 924 bytes 100.0% 🚀
_astro/BaseLayout.astro_astro_type_script_index_0_lang.CrbTpZQe.js (New) 598 bytes 598 bytes 100.0% 🚀
_astro/contact.astro_astro_type_script_index_0_lang.CIs2Wrx2.js (New) 554 bytes 554 bytes 100.0% 🚀
_astro/page.5FrBVo4o.js (Deleted) -271.68kB 0 bytes -100.0% 🗑️
_astro/PostHog.astro_astro_type_script_index_0_lang.Dgp3HkS7.js (Deleted) -240.64kB 0 bytes -100.0% 🗑️
_astro/Chat.astro_astro_type_script_index_0_lang.B_samZHu.js (Deleted) -9.68kB 0 bytes -100.0% 🗑️
_astro/hire-analytics.C4Sh47d4.js (Deleted) -924 bytes 0 bytes -100.0% 🗑️
_astro/BaseLayout.astro_astro_type_script_index_0_lang.Cwqt4HtM.js (Deleted) -598 bytes 0 bytes -100.0% 🗑️
_astro/contact.astro_astro_type_script_index_0_lang.Ci0dm6QZ.js (Deleted) -554 bytes 0 bytes -100.0% 🗑️

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@mergify

mergify Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@alehar9320
alehar9320 marked this pull request as draft August 23, 2026 02:32
@alehar9320

Copy link
Copy Markdown
Owner Author

Closed unmerged. Same class as #622/#639/#652: Nav/Footer socials target=_blank rel=noopener + skip-link :focus-visible + .Jules/palette.md. Do not merge. Do not reopen as Jules.

Kernel later weekday: Aria/Sid, if skip-link focus or social noopener is still missing on live da09e2a, Dan clean cut, no journal. Not now.

Overlay 69ca717 stays. Live da09e2a stands. Queue 0.

@alehar9320 alehar9320 closed this Aug 23, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closed unmerged. Same class as #622/#639/#652: Nav/Footer socials target=_blank rel=noopener + skip-link :focus-visible + .Jules/palette.md. Do not merge. Do not reopen as Jules.

Kernel later weekday: Aria/Sid, if skip-link focus or social noopener is still missing on live da09e2a, Dan clean cut, no journal. Not now.

Overlay 69ca717 stays. Live da09e2a stands. Queue 0.

Understood. Acknowledging that this pull request is closed unmerged and stopping work on this task.

This branch was successfully deployed

No deployments
palette/external-links-and-focus-ux-14334931662967808192 - astro-cloudflare-personal-website-web-service PR #663 — b50dddbd Deployed Aug 23, 2026 by alehar9320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant