Skip to content

⚡ Bolt: Module-level static RegExp hoisting in release utilities - #1225

Closed
alehar9320 wants to merge 1 commit into
mainfrom
bolt/static-regexp-hoisting-release-utils-9205216601649717314
Closed

alehar9320 wants to merge 1 commit into
mainfrom
bolt/static-regexp-hoisting-release-utils-9205216601649717314

Conversation

@alehar9320

@alehar9320 alehar9320 commented Sep 10, 2026 •

Copy link
Copy Markdown
Owner

What

Hoisted static regular expression literals to module-level constants and simplified regex execution in src/utils/github-releases.ts and src/utils/release-summary.ts.

Why

Dynamic RegExp literals instantiated inside frequently called helper functions (splitReleaseBody, parseReleaseItem, stripExecBanned, metricTokens) cause repeated RegExp compilation overhead and temporary heap allocations on Cloudflare Workers edge runtimes. In addition, splitReleaseBody executed regex matching twice per line (.test + .replace); using .exec with .slice reduces regex evaluations to 1x per line.

Impact

  • Edge SSR Performance: Eliminates 9 dynamic RegExp object allocations and compilation passes per release body parse / text sanitization call on Cloudflare Workers.
  • CPU Overhead: Cuts regex line scanning passes in splitReleaseBody from 2x to 1x per line.

How to verify

  • Run npm run test (all 368 tests pass).
  • Run npm run build (build completes without warnings or errors).

PR created automatically by Jules for task 9205216601649717314 started by @alehar9320

Summary by CodeRabbit

  • Performance

    • Improved internal regular-expression handling for release parsing and summary generation.
    • Maintained existing behavior while reducing repeated pattern creation during processing.
  • Documentation

    • Added a changelog entry documenting the regular-expression optimization.

Hoisted static regular expression literals to top-level module constants in src/utils/github-releases.ts and src/utils/release-summary.ts. In splitReleaseBody, replaced dual test/replace execution passes with a single .exec match and .slice. This avoids dynamic RegExp compilation and GC allocation overhead on edge SSR requests.

Co-authored-by: alehar9320 <5390430+alehar9320@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@alehar9320
alehar9320 temporarily deployed to bolt/static-regexp-hoisting-release-utils-9205216601649717314 - astro-cloudflare-personal-website-web-service PR #1225 September 10, 2026 01:00 — with Render Destroyed
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
me bc265fd Commit Preview URL

Branch Preview URL
Sep 10 2026, 01:00 AM

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b8da3c5b-e0c8-4376-a1bd-bb940184833d

📥 Commits

Reviewing files that changed from the base of the PR and between 903d441 and bc265fd.

📒 Files selected for processing (3)
  • .Jules/bolt.md
  • src/utils/github-releases.ts
  • src/utils/release-summary.ts

📝 Walkthrough

Walkthrough

The change hoists static regular expressions in github-releases.ts and release-summary.ts. Parsing and sanitization functions now reuse module-level constants. A changelog entry documents the change.

Changes

Release utility regex hoisting

Layer / File(s) Summary
Hoist and reuse regular expressions
src/utils/github-releases.ts, src/utils/release-summary.ts, .Jules/bolt.md
Release parsing and summary sanitization use module-level regular expression constants. The implementation replaces repeated inline expressions while preserving behavior. Comments and the changelog describe the update.

Estimated code review effort: 1 (Trivial) | ~5 minutes

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bolt/static-regexp-hoisting-release-utils-9205216601649717314

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/utils/github-releases.ts

typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1
typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1

Oops! Something went wrong! :(

ESLint: 10.10.0

Error [ERR_INTERNAL_ASSERTION]: This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
Please open an issue with this stack trace at https://github.com/nodejs/node/issues

at assert (node:internal/assert:11:11)
at loadCJSModuleWithModuleLoad (node:internal/modules/esm/translators:323:3)
at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:231:7)
at ModuleJob.run (node:internal/modules/esm/module_job:437:25)
at async node:internal/modules/esm/loader:639:26
at async dynamicImportConfig (/.eslint-tmp/node_modules/eslint/lib/config/config-loader.js:185:17)
at async loadConfigFile (/.eslint-tmp/node_modules/eslint/lib/config/config-loader.js:275:9)
at async ConfigLoader.calculateConfigArray (/.eslint-tmp/node_modules/eslint/lib/config/config-loader.js:594:23)
at async `#calculateConfigArray` (/.eslint-tmp/node_modules/eslint/lib/config/config-loader.js:369:19)
at async Promise.all (index 0)
src/utils/release-summary.ts

ESLint skipped: the matched ESLint configuration already failed (config-incompatibility).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 562.07kB (-48.89%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
molecular-mars-esm 587.7kB -562.07kB (-48.89%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: molecular-mars-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_astro/page.KApe3WWp.js (New) 331.33kB 331.33kB 100.0% 🚀
_astro/module.BTHGWi8s.js (New) 240.43kB 240.43kB 100.0% 🚀
_astro/Chat.astro_astro_type_script_index_0_lang.D1TYk9GM.js (New) 11.15kB 11.15kB 100.0% 🚀
_astro/PostHog.astro_astro_type_script_index_0_lang.CZDj7QKI.js (New) 2.17kB 2.17kB 100.0% 🚀
_astro/hire-analytics.-UfKbXEM.js (New) 1.37kB 1.37kB 100.0% 🚀
_astro/BaseLayout.astro_astro_type_script_index_0_lang.BHs0CpRK.js (New) 690 bytes 690 bytes 100.0% 🚀
_astro/contact.astro_astro_type_script_index_0_lang.BcSS-GE-.js (New) 554 bytes 554 bytes 100.0% 🚀
chunks/whats-new_BankhB0t.mjs (Deleted) -280.3kB 0 bytes -100.0% 🗑️
chunks/default-handler_DqHG8eeJ.mjs (Deleted) -192.27kB 0 bytes -100.0% 🗑️
chunks/traceData_Dr_fxZBz.mjs (Deleted) -126.65kB 0 bytes -100.0% 🗑️
chunks/schemas_Cot3sONg.mjs (Deleted) -126.52kB 0 bytes -100.0% 🗑️
chunks/server_2oEWh56Y.mjs (Deleted) -105.31kB 0 bytes -100.0% 🗑️
chunks/assets_lTcd8Z19.mjs (Deleted) -57.34kB 0 bytes -100.0% 🗑️
chunks/sequence_CaMmmLod.mjs (Deleted) -47.7kB 0 bytes -100.0% 🗑️
_astro/whats-new.Bf7CHJhQ.css (Deleted) -43.09kB 0 bytes -100.0% 🗑️
chunks/shorthash_CUWuunCX.mjs (Deleted) -29.34kB 0 bytes -100.0% 🗑️
chunks/image-binding-transform_Cf-85Vgs.mjs (Deleted) -24.19kB 0 bytes -100.0% 🗑️
chunks/_astro_data-layer-content_BvrnG9KS.mjs (Deleted) -19.62kB 0 bytes -100.0% 🗑️
virtual_astro_middleware.mjs (Deleted) -15.63kB 0 bytes -100.0% 🗑️
chunks/parse_Ba8fytvn.mjs (Deleted) -15.01kB 0 bytes -100.0% 🗑️
chunks/chat_zD7YyXHs.mjs (Deleted) -12.01kB 0 bytes -100.0% 🗑️
chunks/visits_CH9uXrqX.mjs (Deleted) -8.18kB 0 bytes -100.0% 🗑️
chunks/visitor-changelog_BxY0qWCV.mjs (Deleted) -6.98kB 0 bytes -100.0% 🗑️
chunks/github-releases_BV2_eBm_.mjs (Deleted) -6.7kB 0 bytes -100.0% 🗑️
entry.mjs (Deleted) -5.7kB 0 bytes -100.0% 🗑️
chunks/release-summary_38ArvXd3.mjs (Deleted) -4.97kB 0 bytes -100.0% 🗑️
chunks/release-summary_CjrmKGpt.mjs (Deleted) -4.91kB 0 bytes -100.0% 🗑️
chunks/_virtual_astro_session-driver__DuTqh8b.mjs (Deleted) -3.47kB 0 bytes -100.0% 🗑️
chunks/static-image-collection_BCOQ0UCH.mjs (Deleted) -2.85kB 0 bytes -100.0% 🗑️
chunks/releases_BfVji4Vx.mjs (Deleted) -2.19kB 0 bytes -100.0% 🗑️
chunks/image-transform-endpoint_iHq_WzOS.mjs (Deleted) -1.83kB 0 bytes -100.0% 🗑️
chunks/compiler_CI7zcT-L.mjs (Deleted) -1.77kB 0 bytes -100.0% 🗑️
chunks/consts_J54VxCWf.mjs (Deleted) -1.12kB 0 bytes -100.0% 🗑️
chunks/image-service-workerd_DAtwUGVM.mjs (Deleted) -960 bytes 0 bytes -100.0% 🗑️
chunks/rolldown-runtime_CsW08brr.mjs (Deleted) -941 bytes 0 bytes -100.0% 🗑️
chunks/_virtual_astro_server-island-manifest_ms-rvHw7.mjs (Deleted) -798 bytes 0 bytes -100.0% 🗑️
chunks/content-assets_CKY12EWb.mjs (Deleted) -732 bytes 0 bytes -100.0% 🗑️
chunks/noop-entrypoint_BWurWioB.mjs (Deleted) -680 bytes 0 bytes -100.0% 🗑️

@alehar9320-bot
alehar9320-bot marked this pull request as draft September 10, 2026 01:01
@alehar9320-bot

Copy link
Copy Markdown
Collaborator

HARD ABORT — farm restack of open canonical #1204 (Bolt hoist static RegExp across github-releases / visitor-changelog / release-summary).

@jules Do not restack, reopen, or push follow-ups on this PR. The RegExp-hoist work stays on #1204 only. Same class as closed #1206.

Closing unmerged as duplicate / overlapping farm tip.

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@alehar9320-bot

Copy link
Copy Markdown
Collaborator

CLOSED unmerged HARD ABORT — overlapping Dual-path #1204. Do not reopen as Jules.

This branch was successfully deployed

No deployments
bolt/static-regexp-hoisting-release-utils-9205216601649717314 - astro-cloudflare-personal-website-web-service PR #1225 — bc265fd7 Deployed Sep 10, 2026 by alehar9320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants