Repository navigation
⚡ Bolt: Single-pass What's New glance construction & zero redundant title transforms - #1151
Conversation
…itle transforms - Refactor `collectItems` in `src/utils/whats-new-glance.ts` to iterate over releases directly and use pre-transformed bullet titles, eliminating redundant array allocation and duplicate regex transforms. - Refactor `buildWhatsNewGlance` to extract weekly items and theme groups in single-pass `for...of` loops, avoiding 5 intermediate array allocations per call on edge Worker SSR. - Document learnings in `.Jules/bolt.md`. Co-authored-by: alehar9320 <5390430+alehar9320@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Render
Destroyed
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change refactors ChangesWhats-new glance processing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🟡 Moderate · up to What’s New glance titles now bypass the former title conversion. Validate that bullet and fallback titles retain identical visitor-facing formatting before merging to avoid visible changelog-title regressions. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
me | f8d0b4e | Commit Preview URL Branch Preview URL |
Sep 07 2026, 12:47 AM |
Bundle ReportChanges will decrease total bundle size by 562.1kB (-48.89%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: molecular-mars-esmAssets Changed:
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Tick the box to add this pull request to the merge queue (same as
|
alehar9320-bot
left a comment
alehar9320-bot
left a comment
There was a problem hiding this comment.
Eng PASS tip f8d0b4e3 FULL f8d0b4e3c0563e9447970ca0d2ddc9f9a0a2827c
Value: Edge SSR micro-opt on visitor /whats-new/ glance (follow-on to merged #1138). Not junk, not #800 farm, hire/overlay untouched.
Correctness: toVisitorRelease already runs toVisitorChangelogTitle in the body; skipping the second call on item.message is safe (toVisitorChangelogTitle is idempotent on visitor copy). Single-pass thisWeek / theme ranking preserves sort order and the top-3 / top-4 limits.
HOLD Dual CLOSE until Johan+Vera OWN of f8d0b4e3, then Nick FINAL READY. Converted to draft (overnight-farm / auto-merge risk). Do not squash/merge/restack yet.
Soft dims N/A. Overlay 69ca717. Hire LinkedIn. Stay off #800.
alehar9320-bot
left a comment
alehar9320-bot
left a comment
There was a problem hiding this comment.
Dual OWN (Johan / visitor-experience) — tip f8d0b4e
Verdict: Dual OWN PASS · stay DRAFT until Dual CLOSE
Tip / preview
- Head SHA matches:
f8d0b4e3c0563e9447970ca0d2ddc9f9a0a2827c - isDraft: true
- Preview: https://a22b0ee1-me.alehar.workers.dev
- SENTRY release MATCH: yes (
f8d0b4e3c0563e9447970ca0d2ddc9f9a0a2827c)
Visitor surface
- Files:
src/utils/whats-new-glance.ts(SSR util) +.Jules/bolt.md(eng-only) - Real #1138 follow-on: single-pass weekly/theme construction; drop redundant
toVisitorChangelogTitleaftertoVisitorRelease - Visible glance copy unchanged vs live
46a02398— no invented-copy / farm UI
Brand glance
CLEAN — hire LinkedIn only; chat docked; no Explore junk; stay off #800 / Lidköping; overlay untouched.
Elevated taste
No AI-slop chrome; no motion/token churn. Soft dims N/A.
APPROVE for Dual OWN. Do not ready-for-review until Dual CLOSE.
|
Owner sweep (Nick) — Daily PR queue · 2026-09-07 ~08:40 CEST Bob: squash NOW — Dual CLOSE PASS tip Same Dual CLOSE green path (squash after #1151 lands, one at a time; HOLD LIVE Dual until prod SENTRY MATCH of each squash SHA):
Live main SENTRY MATCH Bot-CI HOLD pile (alehar9320-bot, Quality+CodeQL never attach): stay HOLD — do not re-squash #845/#850/#912/#935/#962/#998/#1005/#881… Needs Alexander close+reopen as alehar9320. Do not draft Jules back. Overlay |
What
Refactored
src/utils/whats-new-glance.tsto eliminate 6 intermediate array allocations per edge SSR request and avoid duplicate regular expression transformations on release bullet titles.Why
On Cloudflare Workers edge runtimes,
collectItemswas invokingreleases.map(toVisitorRelease)(allocating an extra array of releases) and callingtoVisitorChangelogTitlea second time on strings that were already transformed into visitor copy bytoVisitorRelease. Additionally,buildWhatsNewGlanceused array allocation chains (.filter().map().slice(),.flatMap(),.map()) when building the weekly list and theme clusters.Impact
/whats-new/SSR request.Maplookups on every release bullet.How to verify
Run
npm run testandnpm run buildto verify all 340 tests pass and edge builds succeed without regressions.PR created automatically by Jules for task 7736077669945620577 started by @alehar9320
Summary by CodeRabbit