Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implements lists restore handlers #4831

Closed
wants to merge 9 commits into from
Closed

implements lists restore handlers #4831

wants to merge 9 commits into from

Conversation

HiteshRepo
Copy link
Contributor

adds lists restore handler to:

  • create list
  • create list items
  • delete list

Does this PR need a docs update or release note?

  • ⛔ No

Type of change

  • 🌻 Feature

Issue(s)

#4754

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@HiteshRepo HiteshRepo added restore sharepoint lists category of sharepoint service labels Dec 12, 2023
@HiteshRepo HiteshRepo self-assigned this Dec 12, 2023
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Dec 12, 2023 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@HiteshRepo HiteshRepo changed the base branch from main to 4754-restore-1 December 12, 2023 08:03
ryanfkeepers
ryanfkeepers reviewed Dec 12, 2023
View reviewed changes
src/internal/m365/collection/site/collection_test.go
@@ -282,65 +279,3 @@ func (suite *SharePointCollectionSuite) TestCollection_streamItems() {
})
}
}

// TestRestoreListCollection verifies Graph Restore API for the List Collection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please separate code movement and code changes into different PRs for ease of review.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@HiteshRepo
Copy link
Contributor Author

closing this PR as this has been bifurcated to smaller PRs:

@HiteshRepo HiteshRepo closed this Dec 14, 2023
@HiteshRepo HiteshRepo deleted the 4754-restore-2 branch December 28, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanfkeepers ryanfkeepers ryanfkeepers left review comments

Assignees

@HiteshRepo HiteshRepo

Labels
lists category of sharepoint service restore sharepoint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiteshRepo @ryanfkeepers