-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implements lists backup handler #4786
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
eeca2ec
introduce sharepoint backup handler
HiteshRepo 0ea2c23
implement lists backup handler
HiteshRepo 116e529
add mock getItemByIDer for list backup handler
HiteshRepo f88a1e7
create and propagate lists backup handler
HiteshRepo 44b2d64
add tests for CollectLists and rename corresponding test suite
HiteshRepo a2637a9
address review comments
HiteshRepo 3971031
fetches lists using Lists client wrapper (#4787)
HiteshRepo 3aa0e91
merge conflicts with 4754-backup-1
HiteshRepo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package site | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/microsoftgraph/msgraph-sdk-go/models" | ||
) | ||
|
||
type backupHandler interface { | ||
getItemByIDer | ||
} | ||
|
||
type getItemByIDer interface { | ||
GetItemByID(ctx context.Context, itemID string) (models.Listable, error) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package site | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/microsoftgraph/msgraph-sdk-go/models" | ||
|
||
"github.com/alcionai/corso/src/pkg/services/m365/api" | ||
) | ||
|
||
var _ backupHandler = &listsBackupHandler{} | ||
|
||
type listsBackupHandler struct { | ||
ac api.Lists | ||
protectedResource string | ||
} | ||
|
||
func NewListsBackupHandler(protectedResource string, ac api.Lists) listsBackupHandler { | ||
return listsBackupHandler{ | ||
ac: ac, | ||
protectedResource: protectedResource, | ||
} | ||
} | ||
|
||
func (bh listsBackupHandler) GetItemByID(ctx context.Context, itemID string) (models.Listable, error) { | ||
return bh.ac.GetListByID(ctx, bh.protectedResource, itemID) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package mock | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/microsoftgraph/msgraph-sdk-go/models" | ||
|
||
"github.com/alcionai/corso/src/internal/common/ptr" | ||
) | ||
|
||
type GetList struct { | ||
Err error | ||
} | ||
|
||
func (m GetList) GetItemByID(ctx context.Context, itemID string) (models.Listable, error) { | ||
lst := models.NewList() | ||
lst.SetId(ptr.To(itemID)) | ||
|
||
return lst, m.Err | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it's likely we'll later want to expand this to mock the whole backup handler. Might as well set it up now.