Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate location for all Exchange data types #2829

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Populate location for all Exchange data types #2829

merged 5 commits into from
Apr 3, 2023

Conversation

ashmrtn
Copy link
Contributor

@ashmrtn ashmrtn commented Mar 16, 2023

Always populate the location field of backup details
for Exchange data types

Fix bug where ParentPath for calendar items used
folder IDs instead of display names

Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Test
  • 💻 CI/Deployment
  • 🧹 Tech Debt/Cleanup

Issue(s)

merge after:

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ashmrtn ashmrtn added bug Something isn't working backup exchange labels Mar 16, 2023
@ashmrtn ashmrtn self-assigned this Mar 16, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Mar 16, 2023 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

@ashmrtn ashmrtn temporarily deployed to Testing March 16, 2023 00:24 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing March 16, 2023 00:24 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing March 16, 2023 00:24 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing March 16, 2023 00:25 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing March 16, 2023 00:25 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing March 16, 2023 00:25 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing March 16, 2023 00:26 — with GitHub Actions Inactive
ryanfkeepers
ryanfkeepers approved these changes Mar 16, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ashmrtn ashmrtn force-pushed the 2486-populate-resolver-locs branch 2 times, most recently from f981cfb to 946df98 Compare March 28, 2023 22:55
Base automatically changed from 2486-populate-resolver-locs to main March 29, 2023 01:20
@ashmrtn ashmrtn temporarily deployed to Testing March 29, 2023 01:59 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing March 29, 2023 01:59 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing March 29, 2023 02:00 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing March 29, 2023 02:00 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing March 29, 2023 02:00 — with GitHub Actions Inactive
@ashmrtn
Always populate location path
aa09690 
Populate location path for all Exchange data types so we have it in
backup details.
@ashmrtn
Use display name for parent paths
4e623ee
@ashmrtn
Add CHANGELOG entry for bugfix
a10c846
@aviator-app aviator-app bot temporarily deployed to Testing April 3, 2023 18:12 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing April 3, 2023 18:12 Inactive
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Apr 3, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Apr 3, 2023

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Linting

@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 18:20 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 18:20 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 18:20 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 18:21 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 18:21 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 18:21 — with GitHub Actions Inactive
@ashmrtn ashmrtn removed the blocked Upstream item prevents completion label Apr 3, 2023
@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Apr 3, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Apr 3, 2023

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Test-Suite-Trusted

@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 19:33 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 19:33 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 19:33 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 19:33 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 19:33 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 19:33 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing April 3, 2023 19:33 — with GitHub Actions Inactive
@ashmrtn ashmrtn removed the blocked Upstream item prevents completion label Apr 3, 2023
@aviator-app aviator-app bot merged commit 16d1e68 into main Apr 3, 2023
@aviator-app aviator-app bot deleted the 2486-populate-loc branch April 3, 2023 20:22
@ashmrtn ashmrtn mentioned this pull request Apr 3, 2023
Closed
@ashmrtn ashmrtn mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanfkeepers ryanfkeepers ryanfkeepers approved these changes

Assignees

@ashmrtn ashmrtn

Labels
backup bug Something isn't working exchange mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calendar event parent path shows folder IDs
2 participants
@ashmrtn @ryanfkeepers