Minor cleanup to mail resolver fetch #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old code that explicitly fetched the Inbox. The issue in Graph SDK that was causing this is no longer present.
Current Aviator status
This PR was merged using Aviator. |
ryanfkeepers
approved these changes
Mar 15, 2023
|
PR failed to merge with reason: some CI status(es) failed. |
This was referenced Mar 16, 2023
|
PR failed to merge with reason: some CI status(es) failed. |
|
PR failed to merge with reason: some CI status(es) failed. |
|
Kudos, SonarCloud Quality Gate passed!
|
aviator-app bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
Always generate both a path of IDs and a path of display names for folders in the container resolver. Changes in internal/connector/exchange/service_functions.go keep the behavior of the overall system from changing --- #### Does this PR need a docs update or release note? - [ ] ✅ Yes, it's included - [ ] 🕐 Yes, but in a later PR - [x] ⛔ No #### Type of change - [x] 🌻 Feature - [ ] 🐛 Bugfix - [ ] 🗺️ Documentation - [ ] 🤖 Test - [ ] 💻 CI/Deployment - [x] 🧹 Tech Debt/Cleanup #### Issue(s) * #2486 merge after: * #2808 #### Test Plan - [x] 💪 Manual - [x] ⚡ Unit test - [ ] 💚 E2E
aviator-app bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
Always populate the location field of backup details for Exchange data types Fix bug where ParentPath for calendar items used folder IDs instead of display names --- #### Does this PR need a docs update or release note? - [x] ✅ Yes, it's included - [ ] 🕐 Yes, but in a later PR - [ ] ⛔ No #### Type of change - [x] 🌻 Feature - [x] 🐛 Bugfix - [ ] 🗺️ Documentation - [ ] 🤖 Test - [ ] 💻 CI/Deployment - [ ] 🧹 Tech Debt/Cleanup #### Issue(s) * #2486 * closes #2827 merge after: * #2826 * #2808 * #2828 #### Test Plan - [x] 💪 Manual - [ ] ⚡ Unit test - [ ] 💚 E2E
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old code that explicitly fetched the Inbox. The issue in Graph SDK that was causing this is no longer present.
Retrieval of Inbox is tested by test for making collections
Does this PR need a docs update or release note?
Type of change
Issue(s)
Test Plan