Populate location in Exchange container resolver #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. |
12 tasks
ryanfkeepers
approved these changes
Mar 16, 2023
ashmrtn
force-pushed
the
2486-populate-resolver-locs
branch
from
535bbc9
to
6a787b8
Compare
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): Test-Suite-Trusted |
Container resolver indexes by ID already so just populate the location path for all items and have the other path use IDs only. This means any consumer of the container resolver can request either: * a path consisting of folder IDs only * a path consisting of folder display names only Update some of the surrounding code to perform path comparisons properly when looking at Exchange folders and return a location path where a location path is expected. This preserves previous behavior for mail and contacts.
Since all caches now have both ID and display name paths, remove the bool that would help switch between the two.
Allow looking up a display name path in the cache since PathInCache uses the ID path format. Adjust tests and code accordingly.
ashmrtn
force-pushed
the
2486-populate-resolver-locs
branch
from
f981cfb
to
946df98
Compare
|
SonarCloud Quality Gate failed.
|
aviator-app bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
Always populate the location field of backup details for Exchange data types Fix bug where ParentPath for calendar items used folder IDs instead of display names --- #### Does this PR need a docs update or release note? - [x] ✅ Yes, it's included - [ ] 🕐 Yes, but in a later PR - [ ] ⛔ No #### Type of change - [x] 🌻 Feature - [x] 🐛 Bugfix - [ ] 🗺️ Documentation - [ ] 🤖 Test - [ ] 💻 CI/Deployment - [ ] 🧹 Tech Debt/Cleanup #### Issue(s) * #2486 * closes #2827 merge after: * #2826 * #2808 * #2828 #### Test Plan - [x] 💪 Manual - [ ] ⚡ Unit test - [ ] 💚 E2E
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always generate both a path of IDs and a path of
display names for folders in the container resolver.
Changes in internal/connector/exchange/service_functions.go
keep the behavior of the overall system from changing
Does this PR need a docs update or release note?
Type of change
Issue(s)
merge after:
Test Plan