Skip to content

build: drop HDR/Terrain Variation/Helper from AIO#69

Merged
alandtse merged 1 commit into
devfrom
build/aio-exclude-davo-features
Jun 1, 2026
Merged

build: drop HDR/Terrain Variation/Helper from AIO#69
alandtse merged 1 commit into
devfrom
build/aio-exclude-davo-features

Conversation

@alandtse
Copy link
Copy Markdown
Owner

@alandtse alandtse commented Jun 1, 2026

What

Exclude three non-CORE features from the AIO bundle by setting autoupload = false:

Feature Nexus
HDR Display 179371
Terrain Variation 148123
Terrain Helper 143149

Why

These are davo's features; the fork does not redistribute them in the AIO. Users who want them install from their own Nexus pages.

How it works

The AIO ships CORE features plus any non-CORE feature whose .ini sets autoupload = true (feature_is_autoupload in CMakeLists.txt). Flipping these three to false drops them from the AIO stage/archive.

Scope

.ini-only — no shader, HLSL, or runtime behavior change. Affects only AIO packaging composition, hence build: (no release impact).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Disabled automatic upload for HDR Display, Terrain Helper, and Terrain Variation features.

Set autoupload = false on three non-CORE features so they are excluded
from the AIO bundle (the AIO ships CORE features plus non-CORE features
with autoupload = true; see feature_is_autoupload in CMakeLists.txt):

- HDR Display (Nexus 179371)
- Terrain Variation (Nexus 148123)
- Terrain Helper (Nexus 143149)

These are davo's features; the fork does not redistribute them in the
AIO. Users who want them install from their own Nexus pages. No shader or
runtime behavior changes — this only affects AIO packaging composition.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 1, 2026 09:13
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 92994442-b793-493a-9f6d-fb5b57c82dc9

📥 Commits

Reviewing files that changed from the base of the PR and between 077dd72 and f090d50.

📒 Files selected for processing (3)
  • features/HDR Display/Shaders/Features/HDRDisplay.ini
  • features/Terrain Helper/Shaders/Features/TerrainHelper.ini
  • features/Terrain Variation/Shaders/Features/TerrainVariation.ini

📝 Walkthrough

Walkthrough

Three shader feature configuration files disable Nexus autoupload by setting the autoupload parameter from true to false in the [Nexus] section. The change affects HDR Display, Terrain Helper, and Terrain Variation features consistently.

Changes

Disable Nexus Autoupload Across Shader Features

Layer / File(s) Summary
Disable autoupload in Nexus shader feature configurations
features/HDR Display/Shaders/Features/HDRDisplay.ini, features/Terrain Helper/Shaders/Features/TerrainHelper.ini, features/Terrain Variation/Shaders/Features/TerrainVariation.ini
Autoupload setting is changed from true to false in the [Nexus] section across all three shader feature configuration files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Three shaders rest, their uploads now sleep,
Autoupload disabled, the Nexus keeps deep,
A toggle so simple, a change so clean—
Configuration flows, where configs convene!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: disabling autoupload for three features (HDR, Terrain Variation, Terrain Helper) to exclude them from the AIO bundle, which matches the core objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build/aio-exclude-davo-features

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

No actionable suggestions for changed features.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates feature metadata to exclude three non-CORE, third-party features from the AIO bundle by disabling autoupload in their feature .ini files, aligning AIO packaging with redistribution constraints.

Changes:

  • Set autoupload = false for HDR Display, Terrain Variation, and Terrain Helper feature configs.
  • Ensures these features are excluded from AIO staging/archiving unless explicitly overridden via build configuration.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
features/Terrain Variation/Shaders/Features/TerrainVariation.ini Disables autoupload so the feature is excluded from AIO packaging by default.
features/Terrain Helper/Shaders/Features/TerrainHelper.ini Disables autoupload so the feature is excluded from AIO packaging by default.
features/HDR Display/Shaders/Features/HDRDisplay.ini Disables autoupload so the feature is excluded from AIO packaging by default.

@alandtse alandtse merged commit 95ad392 into dev Jun 1, 2026
22 checks passed
@alandtse alandtse deleted the build/aio-exclude-davo-features branch June 1, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants