build: drop HDR/Terrain Variation/Helper from AIO#69
Conversation
Set autoupload = false on three non-CORE features so they are excluded from the AIO bundle (the AIO ships CORE features plus non-CORE features with autoupload = true; see feature_is_autoupload in CMakeLists.txt): - HDR Display (Nexus 179371) - Terrain Variation (Nexus 148123) - Terrain Helper (Nexus 143149) These are davo's features; the fork does not redistribute them in the AIO. Users who want them install from their own Nexus pages. No shader or runtime behavior changes — this only affects AIO packaging composition. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree shader feature configuration files disable Nexus autoupload by setting the ChangesDisable Nexus Autoupload Across Shader Features
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No actionable suggestions for changed features. |
There was a problem hiding this comment.
Pull request overview
Updates feature metadata to exclude three non-CORE, third-party features from the AIO bundle by disabling autoupload in their feature .ini files, aligning AIO packaging with redistribution constraints.
Changes:
- Set
autoupload = falsefor HDR Display, Terrain Variation, and Terrain Helper feature configs. - Ensures these features are excluded from AIO staging/archiving unless explicitly overridden via build configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| features/Terrain Variation/Shaders/Features/TerrainVariation.ini | Disables autoupload so the feature is excluded from AIO packaging by default. |
| features/Terrain Helper/Shaders/Features/TerrainHelper.ini | Disables autoupload so the feature is excluded from AIO packaging by default. |
| features/HDR Display/Shaders/Features/HDRDisplay.ini | Disables autoupload so the feature is excluded from AIO packaging by default. |
What
Exclude three non-CORE features from the AIO bundle by setting
autoupload = false:Why
These are davo's features; the fork does not redistribute them in the AIO. Users who want them install from their own Nexus pages.
How it works
The AIO ships CORE features plus any non-CORE feature whose
.inisetsautoupload = true(feature_is_autouploadinCMakeLists.txt). Flipping these three tofalsedrops them from the AIO stage/archive.Scope
.ini-only — no shader, HLSL, or runtime behavior change. Affects only AIO packaging composition, hencebuild:(no release impact).🤖 Generated with Claude Code
Summary by CodeRabbit