ci: auto-upload AIO to Nexus on stable release#76
Conversation
|
Warning Review limit reached
More reviews will be available in 20 minutes and 19 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR modifies the release build workflow to enable real uploads to Nexus instead of dry-run uploads. The ChangesEnable real Nexus uploads in release job
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Switches the release-build workflow's Nexus upload step from a dry-run of the CORE artifact to a real auto-upload of the AIO archive on stable releases, and wires in the session cookie secret required for real uploads.
Changes:
- Renames step from "Nexus Upload (dry run)" to "Nexus Upload" and sets
dry_run: "false". - Removes
artifact_patternoverride so aio mode uses its defaultCommunityShaders_AIO-*.7z. - Passes
UNEX_NEXUSMODS_SESSION_COOKIEsecret through to the reusable workflow.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release-build.yaml (1)
191-197: 💤 Low valueConsider renaming the job ID to match its new behavior.
The job ID
nexus-dry-runis now misleading sincedry_runis set to"false"and it performs real uploads. Consider renaming tonexus-uploadfor clarity.Note: If this job ID is referenced by branch protection rules or external status checks, renaming may require updating those references.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release-build.yaml around lines 191 - 197, Rename the misleading job ID `nexus-dry-run` to `nexus-upload` to reflect that `dry_run: "false"` performs real uploads; update the job definition name and any references to the job ID used elsewhere (branch protection rules, external status checks, workflows calling this job) to avoid broken links or checks, and run CI/permissions checks after renaming to ensure external integrations still reference the new `nexus-upload` ID.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/release-build.yaml:
- Around line 191-197: Rename the misleading job ID `nexus-dry-run` to
`nexus-upload` to reflect that `dry_run: "false"` performs real uploads; update
the job definition name and any references to the job ID used elsewhere (branch
protection rules, external status checks, workflows calling this job) to avoid
broken links or checks, and run CI/permissions checks after renaming to ensure
external integrations still reference the new `nexus-upload` ID.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 42edabf5-8472-4e84-a639-a60db34453e5
📒 Files selected for processing (1)
.github/workflows/release-build.yaml
The release-build Nexus job was a dry-run that also targeted the CORE archive (artifact_pattern: CommunityShaders-*.7z) instead of the AIO. Now that the aio upload is proven end-to-end (v1.6.1 shipped to mod 180419): - Drop the artifact_pattern override so aio mode uses its default (CommunityShaders_AIO-*.7z) — the actual fork distributable. - Flip dry_run to false so a published stable release auto-uploads the AIO to 180419 (the reusable workflow skips a version already on Nexus). - Use `secrets: inherit` so the nested nexus-upload workflow receives the UNEX_* secrets. Nested reusable workflows don't auto-inherit repo secrets; the prior call passed only UNEX_APIKEY (enough for the dry-run version check) but a real upload also needs UNEX_NEXUSMODS_SESSION_COOKIE. Pre-release tags are still skipped (the `-` guard). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
cedf87e to
b72214a
Compare
The job id was still `nexus-dry-run` after flipping it to a real upload — misleading. Rename to `nexus-upload` (display name already updated). No other job/branch-protection references it (grep-verified), so the rename is internal-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What
Turn the release-build Nexus step from a dry-run-of-the-wrong-artifact into a real AIO upload on stable releases:
artifact_pattern: "CommunityShaders-*.7z"(the CORE archive) soaiomode uses its defaultCommunityShaders_AIO-*.7z— the actual fork distributable.dry_run: "false"→ a published stable tag now uploads the AIO to mod 180419 automatically (matching the manual flow that shipped v1.6.1).UNEX_NEXUSMODS_SESSION_COOKIE(real upload needs it).Safety
!contains(tag, '-')).upload-nexusruns withcheck_existing→ a version already on Nexus is skipped, so re-runs / re-published releases are idempotent.Validated by the v1.6.1 manual upload (same aio path) succeeding end-to-end.
🤖 Generated with Claude Code
Summary by CodeRabbit