fix(aio): include Terrain Helper in AIO bundle#73
Conversation
The Terrain Helper author has approved bundling, so re-enable its AIO inclusion (autoupload = true). This also resolves the v1.6.0 issue where Terrain Helper's TerrainHelper.esp leaked into the AIO while its shaders were stripped (the exclusion logic only removes Shaders/ paths) — the feature is now shipped complete instead of partially. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe Terrain Helper shader feature's autoupload configuration is enabled by setting the ChangesTerrain Helper Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Actionable Suggestions
|
There was a problem hiding this comment.
Pull request overview
This PR restores Terrain Helper to the AIO bundle by marking it as autoupload-enabled in its feature metadata, aligning AIO packaging behavior with the intended shipped feature set.
Changes:
- Set
autoupload = truefor Terrain Helper so it is included in the AIO selection logic (and related automation that keys offautoupload).
There was a problem hiding this comment.
🧹 Nitpick comments (1)
features/Terrain Helper/Shaders/Features/TerrainHelper.ini (1)
1-9: 💤 Low valueConsider adding an issue reference if applicable.
Since this PR fixes a bug (the partial Terrain Helper feature ship from v1.6.0), consider adding an appropriate GitHub keyword to the PR description if there's a related issue:
- "Fixes
#123" or "Closes#123" for the bug fixThis helps with automatic issue tracking and provides better traceability. As per coding guidelines, bug fixes should reference related issues when available.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@features/Terrain` Helper/Shaders/Features/TerrainHelper.ini around lines 1 - 9, Add a GitHub issue reference to the PR description for the bug fix (e.g., "Fixes `#123`" or "Closes `#123`") so the partial Terrain Helper fix is tracked; mention the affected feature by name ("Terrain Helper" / nexusfilename = Terrain Helper) and the release version (Version = 1-0-1) in the PR description so the automatic issue-closing works and traceability is clear.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@features/Terrain` Helper/Shaders/Features/TerrainHelper.ini:
- Around line 1-9: Add a GitHub issue reference to the PR description for the
bug fix (e.g., "Fixes `#123`" or "Closes `#123`") so the partial Terrain Helper fix
is tracked; mention the affected feature by name ("Terrain Helper" /
nexusfilename = Terrain Helper) and the release version (Version = 1-0-1) in the
PR description so the automatic issue-closing works and traceability is clear.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b432a324-76ca-42a1-b5d4-562e5f673e6e
📒 Files selected for processing (1)
features/Terrain Helper/Shaders/Features/TerrainHelper.ini
2f81e8c to
5955714
Compare
Cherry-pick (path-scoped) the AuditVersion opt-out from upstream community-shaders community-shaders#2444 into tools/feature_version_audit.py — applied only to the audit script, not the 5 diverged pipeline workflows that PR also touched (those would conflict against our fork's AIO/aio-mode pipeline). Mark Terrain Helper AuditVersion = false: it is activation-only (no shaders under features/, all logic in src/Features/TerrainHelper.cpp), so the audit should not demand a version bump when only its toggle .ini changes. This makes the PR audit pass and stops the release --apply-bumps from spuriously bumping it — it stays 1-0-1 while remaining in the AIO (autoupload = true). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Superseded by #74, which folds the Terrain Helper |
What
Re-enable Terrain Helper in the AIO (
autoupload = true) now that its author approved bundling, and stop the feature audit from churning on it.Changes
features/Terrain Helper/.../TerrainHelper.ini:autoupload = true+AuditVersion = false.tools/feature_version_audit.py: path-scoped cherry-pick of theAuditVersionopt-out from upstream community-shaders ci: fix release build and nexus upload pipeline after 1.6 community-shaders/skyrim-community-shaders#2444 — applied only to the audit script (the other 5 files that PR touched are pipeline workflows our fork has diverged on; a full cherry-pick would conflict).Why
AuditVersion = falseTerrain Helper is activation-only:
features/Terrain Helper/has no shaders (just the toggle.ini+.esp); all logic is insrc/Features/TerrainHelper.cpp. So a version bump when only its.inichanges is meaningless churn. With the opt-out, the audit skips it — the PR check passes and the release--apply-bumpswon't spuriously bump it (stays1-0-1), while it ships in the AIO.Release
fix(aio):→ semantic-release cuts v1.6.1 (patch). Supersedes v1.6.0 (which shipped a partial Terrain Helper).🤖 Generated with Claude Code