Skip to content

fix(aio): include Terrain Helper in AIO bundle#73

Closed
alandtse wants to merge 2 commits into
devfrom
fix/aio-include-terrain-helper
Closed

fix(aio): include Terrain Helper in AIO bundle#73
alandtse wants to merge 2 commits into
devfrom
fix/aio-include-terrain-helper

Conversation

@alandtse
Copy link
Copy Markdown
Owner

@alandtse alandtse commented Jun 1, 2026

What

Re-enable Terrain Helper in the AIO (autoupload = true) now that its author approved bundling, and stop the feature audit from churning on it.

Changes

Why AuditVersion = false

Terrain Helper is activation-only: features/Terrain Helper/ has no shaders (just the toggle .ini + .esp); all logic is in src/Features/TerrainHelper.cpp. So a version bump when only its .ini changes is meaningless churn. With the opt-out, the audit skips it — the PR check passes and the release --apply-bumps won't spuriously bump it (stays 1-0-1), while it ships in the AIO.

Release

fix(aio): → semantic-release cuts v1.6.1 (patch). Supersedes v1.6.0 (which shipped a partial Terrain Helper).

🤖 Generated with Claude Code

The Terrain Helper author has approved bundling, so re-enable its AIO
inclusion (autoupload = true). This also resolves the v1.6.0 issue where
Terrain Helper's TerrainHelper.esp leaked into the AIO while its shaders
were stripped (the exclusion logic only removes Shaders/ paths) — the
feature is now shipped complete instead of partially.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 1, 2026 18:26
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

The Terrain Helper shader feature's autoupload configuration is enabled by setting the autoupload flag from false to true in its INI configuration file.

Changes

Terrain Helper Configuration

Layer / File(s) Summary
Enable autoupload setting
features/Terrain Helper/Shaders/Features/TerrainHelper.ini
The autoupload setting is toggled from false to true, enabling automatic uploading for the Terrain Helper feature.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • alandtse/open-shaders#69: Inverse change that disables autoupload for the same Terrain Helper configuration, directly opposing this PR's modification.

Poem

🐰 A toggle flipped with rabbit care,
Uploads flow through the shader air,
From false to true, the setting springs,
Helper features take their wings! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: enabling Terrain Helper in the AIO bundle by setting autoupload to true, which directly addresses the file modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/aio-include-terrain-helper

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Actionable Suggestions

  • Terrain Helper (Alan Tse): Needs version bump to 1-0-2

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores Terrain Helper to the AIO bundle by marking it as autoupload-enabled in its feature metadata, aligning AIO packaging behavior with the intended shipped feature set.

Changes:

  • Set autoupload = true for Terrain Helper so it is included in the AIO selection logic (and related automation that keys off autoupload).

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
features/Terrain Helper/Shaders/Features/TerrainHelper.ini (1)

1-9: 💤 Low value

Consider adding an issue reference if applicable.

Since this PR fixes a bug (the partial Terrain Helper feature ship from v1.6.0), consider adding an appropriate GitHub keyword to the PR description if there's a related issue:

  • "Fixes #123" or "Closes #123" for the bug fix

This helps with automatic issue tracking and provides better traceability. As per coding guidelines, bug fixes should reference related issues when available.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@features/Terrain` Helper/Shaders/Features/TerrainHelper.ini around lines 1 -
9, Add a GitHub issue reference to the PR description for the bug fix (e.g.,
"Fixes `#123`" or "Closes `#123`") so the partial Terrain Helper fix is tracked;
mention the affected feature by name ("Terrain Helper" / nexusfilename = Terrain
Helper) and the release version (Version = 1-0-1) in the PR description so the
automatic issue-closing works and traceability is clear.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@features/Terrain` Helper/Shaders/Features/TerrainHelper.ini:
- Around line 1-9: Add a GitHub issue reference to the PR description for the
bug fix (e.g., "Fixes `#123`" or "Closes `#123`") so the partial Terrain Helper fix
is tracked; mention the affected feature by name ("Terrain Helper" /
nexusfilename = Terrain Helper) and the release version (Version = 1-0-1) in the
PR description so the automatic issue-closing works and traceability is clear.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b432a324-76ca-42a1-b5d4-562e5f673e6e

📥 Commits

Reviewing files that changed from the base of the PR and between 8ff96d1 and 5955714.

📒 Files selected for processing (1)
  • features/Terrain Helper/Shaders/Features/TerrainHelper.ini

@alandtse alandtse force-pushed the fix/aio-include-terrain-helper branch from 2f81e8c to 5955714 Compare June 1, 2026 18:37
Copilot AI review requested due to automatic review settings June 1, 2026 18:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Cherry-pick (path-scoped) the AuditVersion opt-out from upstream
community-shaders community-shaders#2444 into tools/feature_version_audit.py — applied only
to the audit script, not the 5 diverged pipeline workflows that PR also
touched (those would conflict against our fork's AIO/aio-mode pipeline).

Mark Terrain Helper AuditVersion = false: it is activation-only (no shaders
under features/, all logic in src/Features/TerrainHelper.cpp), so the audit
should not demand a version bump when only its toggle .ini changes. This
makes the PR audit pass and stops the release --apply-bumps from spuriously
bumping it — it stays 1-0-1 while remaining in the AIO (autoupload = true).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@alandtse
Copy link
Copy Markdown
Owner Author

alandtse commented Jun 2, 2026

Superseded by #74, which folds the Terrain Helper autoupload = true delta into the upstream v1.6.1 hotfix sync (the AuditVersion opt-out now arrives natively from upstream community-shaders#2444, so the path-scoped cherry-pick here is redundant).

@alandtse alandtse closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants