refactor #870 #886
Merged
refactor #870 #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +54,8 @@ class TabbedView extends Component { | |||
| return; | |||
| } | |||
| this.renderedSceneKeys[key] = true; | |||
| scenes.push(this.renderScene(item, i)); | |||
| const {navigationBarStyle,titleStyle} = this.props.navigationState; | |||
| scenes.push(this.renderScene({navigationBarStyle,titleStyle,...item}, i)); | |||
| }); | |||
| return ( | |||
| <View style={this.props.style}> | |||
There was a problem hiding this comment.
as i've found today this commit broke my app :(
There was a problem hiding this comment.
@aksonov sorry about that! what did it break?
There was a problem hiding this comment.
Right button style and overall style for own nav bar passed to Router globally
Pavel.
5 июля 2016 г., в 17:44, Joe Noon [email protected] написал(а):
In src/TabbedView.js:
@@ -54,7 +54,8 @@ class TabbedView extends Component {
return;
}
this.renderedSceneKeys[key] = true;
scenes.push(this.renderScene(item, i));const {navigationBarStyle,titleStyle} = this.props.navigationState;scenes.push(this.renderScene({navigationBarStyle,titleStyle,...item}, i));
return (
@aksonov sorry about that! what did it break?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #870
seems like a safe way to go? lets the item still have last say