Breaks when minified

[jacob-israel-turner]

When I bundle/minify my app, this library breaks. For some reason, the component names don't get added to the Actions object after minification.

Object.keys(Actions) prior to minification:

["push", "PUSH", "pop", "POP", "dismiss", "DISMISS", "preSplash", "splash", "login", "register", "etc."]

Object.keys(Actions) after minifcation:

[ 'push', 'PUSH', 'pop', 'POP', 'dismiss', 'DISMISS' ]

[aksonov]

Thanks, it seems to be real issue - probably because Actions are generated in runtime, not compile time and minificator brakes it somehow. But it seems to be out of my control, any idea how to make it work with minification?

4 сент. 2015, в 13:25, Jacob Turner notifications@github.com написал(а):

When I bundle/minify my app, this library breaks. For some reason, the component names don't get added to the Actions object after minification.

Object.keys(Actions) prior to minification:

["push", "PUSH", "pop", "POP", "dismiss", "DISMISS", "preSplash", "splash", "login", "register", "formOne", "formTwo", "formThree", "formFour", "formFive", "floor", "post", "composePost", "explore", "conversations", "chat",
"ownProfile", "otherProfile", "editProfile", "editBio", "about", "contactUs", "terms", "privacy", "changePassword", "passwordReset", "settings"]
Object.keys(Actions) after minifcation:

[ 'push', 'PUSH', 'pop', 'POP', 'dismiss', 'DISMISS' ]
—
Reply to this email directly or view it on GitHub #4.

[jacob-israel-turner]

I'll take a look at it this afternoon, I honestly have no idea how your library works yet. 😄 I'll let ya know what I find.

[aksonov]

It works in straightforward way: it just adds new functions during processing of «Route» children to alt Actions object. Maybe I need to ask within alt github how to add custom actions in runtime correctly.

4 сент. 2015, в 13:31, Jacob Turner notifications@github.com написал(а):

I'll take a look at it this afternoon, I honestly have no idea how your library works yet. :P I'll let ya know what I find.

—
Reply to this email directly or view it on GitHub #4 (comment).

[aksonov]

Please check latest version 0.1.0, this bug should be fixed.

[jacob-israel-turner]

@aksonov Thanks. We ended up going with an unminified bundle because of time restraints. I'll take a look at 0.1.0 for our next release.