Bulk load CDK: run cleaner once per class#58675
Merged
Edward Gao (edgao) merged 3 commits intomasterfrom Apr 25, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| // we want to run the cleaner exactly once per test class. | ||
| // technically this is a little inefficient - e.g. multiple test classes could reuse the same | ||
| // cleaner, so we'd prefer to only them once. |
Contributor
There was a problem hiding this comment.
I think you are missing a word here
Francis Genet (frifriSF59)
approved these changes
Apr 25, 2025
Edward Gao (edgao)
added a commit
that referenced
this pull request
Apr 29, 2025
This reverts commit 74a52ef.
ericvanbenschoten-dv01
pushed a commit
to ericvanbenschoten-dv01/airbyte_ev
that referenced
this pull request
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/12566
just move the hasRunCleaner from the companion object into an instance val
this is probably why s3-data-lake wasn't correctly deleting stuff from glue, even though we have nightlies
(this will also be useful for bigquery, where different cleaners will point at different rawTableDataset)