Skip to content

Bulk load CDK: run cleaner once per class #58675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Edward Gao (edgao) merged 3 commits into from
Apr 25, 2025
Merged

Bulk load CDK: run cleaner once per class #58675

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf2f590
run cleaner once per class
edgao Apr 25, 2025
be637ed
comment on why not AfterAll
edgao Apr 25, 2025
6dcb631
derp
edgao Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...k/bulk/core/load/src/testFixtures/kotlin/io/airbyte/cdk/load/test/util/IntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,15 @@ abstract class IntegrationTest(
// multiple times.
val destinationProcessFactory = DestinationProcessFactory.get(additionalMicronautEnvs)

// we want to run the cleaner exactly once per test class.
// technically this is a little inefficient - e.g. multiple test classes could reuse the same
// cleaner, so we'd prefer to only call each of them once.
// but this is simpler to implement than tracking hasRunCleaner across test classes,
// and then also requiring cleaners to be able to recognize themselves as identical.
// (you would think this is just an AfterAll method, but junit requires those to be static,
// so we wouldn't have access to the cleaner instance >.>)
private val hasRunCleaner = AtomicBoolean(false)

@Suppress("DEPRECATION") private val randomSuffix = RandomStringUtils.randomAlphabetic(4)
private val timestampString =
LocalDateTime.ofInstant(Instant.now(), ZoneOffset.UTC)
Expand Down Expand Up @@ -329,8 +338,6 @@ abstract class IntegrationTest(
return namespaceCreationDate.isBefore(cleanupCutoffDate)
}

private val hasRunCleaner = AtomicBoolean(false)

// Connectors are calling System.getenv rather than using micronaut-y properties,
// so we have to mock it out, instead of just setting more properties
// inside NonDockerizedDestination.
Expand Down
Loading