Bulk load CDK: destinationcleaner must be singleton#59137
Merged
Edward Gao (edgao) merged 8 commits intomasterfrom May 1, 2025
Merged
Bulk load CDK: destinationcleaner must be singleton#59137Edward Gao (edgao) merged 8 commits intomasterfrom
Edward Gao (edgao) merged 8 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
nope, everything still sucks, this only worked in mock test b/c the cleaner is an |
Edward Gao (edgao)
force-pushed
the
edgao/actually_run_cleaner_once_per_instance
branch
from
e867596 to
4b074d2
Compare
Edward Gao (edgao)
changed the title
Francis Genet (frifriSF59)
approved these changes
Apr 29, 2025
Edward Gao (edgao)
force-pushed
the
edgao/actually_run_cleaner_once_per_instance
branch
from
27d8725 to
f34449f
Compare
# Conflicts: # airbyte-integrations/connectors/destination-mssql/src/test-integration/kotlin/io/airbyte/integrations/destination/mssql/v2/MSSQLWriterTest.kt
Edward Gao (edgao)
deleted the
edgao/actually_run_cleaner_once_per_instance
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/12662
force the data cleaner to be a singleton, revert #58675 so that we run the cleaner exactly once per gradle invocation
and update s3datalake+mssql to be singleton